Point at where clauses where the associated item was restricted #65994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I would also like to also handle the case in |
This comment has been minimized.
This comment has been minimized.
Aaron1011
reviewed
Oct 31, 2019
| LL | type Assoc; | ||
| | ----- associated type defined here | ||
| ... | ||
| LL | impl Bat for () { |
There was a problem hiding this comment.
I think the error would be clearer if this part came first, followed by the explanation of the origin of the requirement.
There was a problem hiding this comment.
This is borne of a limitation we have today, we can't have subdiagnostics with multiple span labels, so it's either this or the more verbose "one subdiagnostic per span" output, which I try to avoid.
nikomatsakis
approved these changes
Nov 8, 2019
|
@bors r+ |
|
📌 Commit 9534b58 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 8, 2019
Point at where clauses where the associated item was restricted CC rust-lang#57663. r? @nikomatsakis
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 9, 2019
Point at where clauses where the associated item was restricted CC rust-lang#57663. r? @nikomatsakis
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 9, 2019
Point at where clauses where the associated item was restricted CC rust-lang#57663. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Nov 9, 2019
Rollup of 6 pull requests Successful merges: - #65949 (Move promotion into its own pass) - #65994 (Point at where clauses where the associated item was restricted) - #66050 (Fix C aggregate-passing ABI on powerpc) - #66134 (Point at formatting descriptor string when it is invalid) - #66172 (Stabilize @file command line arguments) - #66226 (add link to unstable book for asm! macro) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #57663.
r? @nikomatsakis