-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade openssl and openssl-sys #66008
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
or maybe @sfackler would be a better choice =) |
Looks good to me, thanks! I think though you'll need to run |
Will do. 👍 |
The bootstrap is still trying to update submodules and will most likely have to download the bootstrap itself afterwards (right?). I have a very bad internet connection and really don't have the time to see this through. Is a maintainer here able to make the changes? I'll close this PR if so! |
Covered in #66241 now, so closing. |
Fixes #65808
This PR updates
openssl
andopenssl-sys
to support newer versions oflibressl
inrust
builds. I can confirm (at least on my machine) thatrust
builds and works successfully with the newer versions oflibressl
.This is my first contribution to
rust
, apologies if I have done this incorrectly. For reference, I have based this PR on a previous PR which updates these two dependencies to fix a similar issue. #57263Thanks / Ευχαριστώ 👍