Skip to content

Prevent building the clippy plugin in rustbuild #66052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Prevent building the clippy plugin in rustbuild #66052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bootstrap/tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ impl Step for ToolBuild {
_ => panic!("unexpected Mode for tool build")
}

let cargo = prepare_tool_cargo(
let mut cargo = prepare_tool_cargo(
builder,
compiler,
self.mode,
Expand All @@ -74,6 +74,11 @@ impl Step for ToolBuild {
&self.extra_features,
);

// Pass the --bin flags to tell Cargo that is should only build the tool binaries.
// If not, Cargo will build everything by default, including the deprecated clippy plugin
// that causes failure on cross-compiled platforms.
cargo.arg("--bin").arg(&tool);

builder.info(&format!("Building stage{} tool {} ({})", compiler.stage, tool, target));
let mut duplicates = Vec::new();
let is_expected = compile::stream_cargo(builder, cargo, vec![], &mut |msg| {
Expand Down