Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some build-pass ui tests to use check-pass where applicable #66087

Merged
merged 7 commits into from
Nov 8, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/ui/async-await/issue-61793.rs
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
// while those two fields were at the same offset (which is impossible).
// That is, memory ordering of `(X, ())`, but offsets of `((), X)`.

// build-pass (FIXME(62277): could be check-pass?)
// build-pass
// edition:2018

async fn foo<F>(_: &(), _: F) {}
2 changes: 1 addition & 1 deletion src/test/ui/async-await/issues/issue-53249.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// edition:2018

#![feature(arbitrary_self_types)]
2 changes: 1 addition & 1 deletion src/test/ui/async-await/issues/issue-54974.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// edition:2018

use std::sync::Arc;
2 changes: 1 addition & 1 deletion src/test/ui/async-await/issues/issue-60518.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// edition:2018

// This is a regression test to ensure that simple bindings (where replacement arguments aren't
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

// rust-lang/rust#55552: The strategy pnkfelix landed in PR #55274
// (for ensuring that NLL respects user-provided lifetime annotations)
2 changes: 1 addition & 1 deletion src/test/ui/closure-expected-type/issue-24421.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

fn test<F: Fn(&u64, &u64)>(f: F) {}

2 changes: 1 addition & 1 deletion src/test/ui/consts/issue-62045.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

fn main() {
assert_eq!(&mut [0; 1][..], &mut []);
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

// rust-lang/rust#56327: Some occurrences of `dyn` within a macro are
// not instances of identifiers, and thus should *not* be caught by the
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
// `#![macro_escape]` is incompatible with crate-level `#![macro_use]`
// already present in issue-43106-gating-of-builtin-attrs.

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![macro_escape]
//~^ WARN macro_escape is a deprecated synonym for macro_use
2 changes: 1 addition & 1 deletion src/test/ui/generator/issue-53548-1.rs
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
// but which encountered the same ICE/error. See `issue-53548.rs`
// for details.
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

use std::cell::RefCell;
use std::rc::Rc;
2 changes: 1 addition & 1 deletion src/test/ui/generator/issue-53548.rs
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
// also analogous to what we would do for higher-ranked regions
// appearing within the trait in other positions).
//
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(generators)]

2 changes: 1 addition & 1 deletion src/test/ui/impl-trait/issues/issue-42479.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

use std::iter::once;

2 changes: 1 addition & 1 deletion src/test/ui/impl-trait/issues/issue-49376.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

// Tests for nested self-reference which caused a stack overflow.

2 changes: 1 addition & 1 deletion src/test/ui/impl-trait/issues/issue-52128.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![deny(warnings)]

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This used to ICE because it creates an `impl Trait` that captures a
// hidden empty region.

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

fn server() -> impl FilterBase2 {
segment2(|| { loop { } }).map2(|| "")
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
// opaque type. As all regions are now required to outlive the bound in an
// opaque type we avoid the issue here.

// build-pass (FIXME(62277): could be check-pass?)
// check-pass

struct A<F>(F);

2 changes: 1 addition & 1 deletion src/test/ui/imports/issue-53140.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

mod m {
pub struct S(u8);
2 changes: 1 addition & 1 deletion src/test/ui/imports/issue-55811.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// aux-build:issue-55811.rs

extern crate issue_55811;
2 changes: 1 addition & 1 deletion src/test/ui/imports/issue-56263.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// edition:2018

use ::std;
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-10396.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
#[derive(Debug)]
enum Foo<'s> {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-10456.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

pub struct Foo;
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-10763.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-10853.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

#![deny(missing_docs)]
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-10902.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-11384.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

trait Common { fn dummy(&self) { } }
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-11592.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
//! Ensure the private trait Bar isn't complained about.

#![deny(missing_docs)]
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-11612.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// #11612
// We weren't updating the auto adjustments with all the resolved
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-11869.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-1251.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(unused_attributes)]
#![allow(dead_code)]
// pretty-expanded FIXME #23616
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-12729.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13105.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

trait Foo {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13167.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

use std::slice;
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13214.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(dead_code)]
// defining static with struct that contains enum
// with &'static str variant used to cause ICE
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13405.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
#![allow(unused_variables)]
// pretty-expanded FIXME #23616
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13703.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

pub struct Foo<'a, 'b: 'a> { foo: &'a &'b isize }
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13775.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

trait Foo {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-13837.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14082.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

#![allow(unused_imports, dead_code)]
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14254.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

trait Foo: Sized {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14330.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(unused_imports)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14837.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

#[deny(dead_code)]
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14901.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
pub trait Reader {}

enum Wrapper<'a> {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14933.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

pub type BigRat<T = isize> = T;
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14936.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(unused_macros)]
#![allow(dead_code)]
#![feature(asm)]
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-14959.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

#![feature(fn_traits, unboxed_closures)]
4 changes: 0 additions & 4 deletions src/test/ui/issues/issue-15108.rs

This file was deleted.

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-15261.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(dead_code)]
#![allow(non_upper_case_globals)]

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-15689-2.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-15735.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
struct A<'a> {
a: &'a i32,
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-16596.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]

trait MatrixRow { fn dummy(&self) { }}
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-16668.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
struct Parser<'a, I, O> {
parse: Box<dyn FnMut(I) -> Result<O, String> + 'a>
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17121.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616
// ignore-cloudabi no std::fs
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17263.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

#![feature(box_syntax)]

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17336.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(unused_must_use)]
#[allow(dead_code)]
fn check(a: &str) {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17450.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// build-pass
#![allow(dead_code, warnings)]

static mut x: isize = 3;
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17718-const-destructors.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
struct A;
impl Drop for A {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17732.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17746.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// Regression test for #17746

2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-17904.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
// Test that we can parse where clauses on various forms of tuple
// structs.
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-18083.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
#![allow(unused_imports)]
// These crossed imports should resolve fine, and not block on
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-18088.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass

pub trait Indexable<T>: std::ops::Index<usize, Output = T> {
fn index2(&self, i: usize) -> &T {
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-18188.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
// pretty-expanded FIXME #23616

pub trait Promisable: Send + Sync {}
2 changes: 1 addition & 1 deletion src/test/ui/issues/issue-1821.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// build-pass (FIXME(62277): could be check-pass?)
// check-pass
#![allow(dead_code)]
#![allow(non_camel_case_types)]

Loading