[WIP] rustc: push LocalDefId and/or assert_local calls farther back. #66132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
eddyb
force-pushed
the
spread-local-def-id
branch
from
3ad56c0 to
d74b28a
Compare
This comment has been minimized.
This comment has been minimized.
…ocalDefId::from_def_id.
eddyb
force-pushed
the
spread-local-def-id
branch
from
d74b28a to
b3c2aeb
Compare
|
☔ The latest upstream changes (presumably #66225) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
added
S-waiting-on-author
JohnCSimon
added
the
S-inactive
|
Ping from triage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #66131, see that PR for more details.
While working on #66131 I thought I'd replace a couple
DefIds withLocalDefIds to reduce the number ofassert_localcalls (that don't obviously always succeed).However, this ended up being a sprawling refactor, so I split it into its own PR.
We can probably do a lot more than what I did here, especially if we fix e.g.
tcx.hir().local_def_id(...)to returnLocalDefIdinstead ofDefId.