Rollup of 8 pull requests #66160

pietroalbini · 2019-11-06T15:28:57Z

Successful merges:

gate rustc_on_unimplemented under rustc_attrs #65794 (gate rustc_on_unimplemented under rustc_attrs)
HIR docs: mention how to resolve method paths #66076 (HIR docs: mention how to resolve method paths)
Do not require extra LLVM backends for x.py test to pass #66084 (Do not require extra LLVM backends for x.py test to pass)
improve from_raw_parts docs #66111 (improve from_raw_parts docs)
Fixed PhantomData markers in Arc and Rc #66117 (Fixed PhantomData markers in Arc and Rc)
Remove unused parameters in __thread_local_inner #66146 (Remove unused parameters in __thread_local_inner)
Miri: Refactor to_scalar_ptr out of existence #66147 (Miri: Refactor to_scalar_ptr out of existence)
update clippy to fix toolstate #66158 (update clippy to fix toolstate)

Failed merges:

miri: Rename to_{u,i}size to to_machine_{u,i}size #66154 (miri: Rename to_{u,i}size to to_machine_{u,i}size)

r? @ghost

…nd Arc

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

Removed parameters not used in the macro

Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>

@varkor

gate rustc_on_unimplemented under rustc_attrs Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal. Closes rust-lang#29628 r? @varkor

HIR docs: mention how to resolve method paths

Do not require extra LLVM backends for `x.py test` to pass For long time our testing passed with a partially built LLVM ``` [llvm] targets = "X86;ARM" ``` , a [recent PR](rust-lang#65809) changed that.

@Centril

improve from_raw_parts docs Triggered by rust-lang/rfcs#2806. Hopefully this helps clarify that joining slices across allocations is not possible in Rust currently. r? @Centril

…RalfJung Fixed PhantomData markers in Arc and Rc Include owned internal structs in `PhantomData` markers in `Arc` (`PhantomData<T>` => `PhantomData<ArcInner<T>>`) and `Rc` (`PhantomData<T>` => `PhantomData<RcBox<T>>`).

Remove unused parameters in `__thread_local_inner` Fixes rust-lang#65993.

@oli-obk

Miri: Refactor to_scalar_ptr out of existence `to_scalar_ptr` is somewhat subtle as it just throws away the 2nd component of a `ScalarPair` if there is one -- without any check if this is truly a pointer or so. And indeed we used it wrong on two occasions! So I fixed those two, and then refactored things such that everyone calls `ref_to_mplace` instead (which they did anyway, I just moved up the calls), which is the only place that should interpret a `ScalarPair` as a wide ptr -- and it checks the type first. Thus we can remove `to_scalar_ptr` and `to_meta`. r? @oli-obk

@msizanoen1

update clippy to fix toolstate Close rust-lang#66150. Close rust-lang#62558 thanks to @msizanoen1 .

pietroalbini · 2019-11-06T15:29:26Z

@bors r+ p=9 rollup=never

@rustbot modify labels: rollup

bors · 2019-11-06T15:29:28Z

📌 Commit 454032f has been approved by pietroalbini

bors · 2019-11-06T15:29:41Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: improper_ctypes: extern "C" fns #65134

bors · 2019-11-06T15:29:42Z

📌 Commit 454032f has been approved by pietroalbini

bors · 2019-11-06T15:59:44Z

⌛ Testing commit 454032f with merge 90f8ceb495d7bacc43e67365801ba62f0a2b5f05...

tesuji · 2019-11-06T17:29:37Z

#66158 failed
@bors r- retry

bors · 2019-11-06T17:29:38Z

@lzutao: 🔑 Insufficient privileges: Not in reviewers

bors · 2019-11-06T17:29:39Z

@lzutao: 🔑 Insufficient privileges: not in try users

pietroalbini · 2019-11-06T17:32:41Z

@bors r- retry

rust-highfive · 2019-11-06T18:02:05Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-06T15:29:42.2692965Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-06T15:29:42.2886251Z ##[command]git config gc.auto 0
2019-11-06T15:29:42.2962609Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-06T15:29:42.3039187Z ##[command]git config --get-all http.proxy
2019-11-06T15:29:42.3203454Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66160/merge:refs/remotes/pull/66160/merge
---
2019-11-06T17:08:52.2086374Z     Finished release [optimized] target(s) in 10m 40s
2019-11-06T17:10:43.7467263Z Error: there are broken links
2019-11-06T17:10:43.7469074Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-11-06T17:10:43.7469955Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html#method.buffer_lint" returned 404 Not Found
2019-11-06T17:10:43.7471075Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-11-06T17:10:43.7471888Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-11-06T17:10:43.7472250Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-11-06T17:10:43.7472609Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-11-06T17:10:43.7472926Z  Caused By: "https://github.com/rust-lang/chalk/blob/master/src/test/wf.rs" returned 404 Not Found
---
2019-11-06T17:25:15.9614167Z 
2019-11-06T17:25:15.9614406Z ------------------------------------------
2019-11-06T17:25:15.9614473Z stderr:
2019-11-06T17:25:15.9614707Z ------------------------------------------
2019-11-06T17:25:15.9616101Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/lint_without_lint_pass.rs","byte_start":142,"byte_end":168,"line_start":9,"line_end":9,"column_start":1,"column_end":27,"is_primary":true,"text":[{"text":"extern crate clippy_lints;","highlight_start":1,"highlight_end":27}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/lint_without_lint_pass.rs:9:1\n   |\nLL | extern crate clippy_lints;\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T17:25:15.9616835Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T17:25:15.9616908Z 
2019-11-06T17:25:15.9617133Z ------------------------------------------
2019-11-06T17:25:15.9617166Z 
---
2019-11-06T17:25:15.9618696Z expected stderr:
2019-11-06T17:25:15.9618739Z error: trivial regex
2019-11-06T17:25:15.9618963Z   --> $DIR/regex.rs:13:45
2019-11-06T17:25:15.9619006Z    |
2019-11-06T17:25:15.9619050Z LL |     let pipe_in_wrong_position = Regex::new("|");
2019-11-06T17:25:15.9619160Z    |
2019-11-06T17:25:15.9619393Z    = note: `-D clippy::trivial-regex` implied by `-D warnings`
2019-11-06T17:25:15.9619462Z    = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9619494Z 
2019-11-06T17:25:15.9619494Z 
2019-11-06T17:25:15.9619543Z error: trivial regex
2019-11-06T17:25:15.9619745Z   --> $DIR/regex.rs:14:60
2019-11-06T17:25:15.9619806Z    |
2019-11-06T17:25:15.9619853Z LL |     let pipe_in_wrong_position_builder = RegexBuilder::new("|");
2019-11-06T17:25:15.9619967Z    |
2019-11-06T17:25:15.9620010Z    = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9620048Z 
2019-11-06T17:25:15.9620048Z 
2019-11-06T17:25:15.9620096Z error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T17:25:15.9620369Z    |
2019-11-06T17:25:15.9620369Z    |
2019-11-06T17:25:15.9620589Z LL |     let wrong_char_ranice = Regex::new("[z-a]");
2019-11-06T17:25:15.9620698Z    |
2019-11-06T17:25:15.9620698Z    |
2019-11-06T17:25:15.9620928Z    = note: `-D clippy::invalid-regex` implied by `-D warnings`
2019-11-06T17:25:15.9620961Z 
2019-11-06T17:25:15.9621029Z error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T17:25:15.9621285Z    |
2019-11-06T17:25:15.9621285Z    |
2019-11-06T17:25:15.9621527Z LL |     let some_unicode = Regex::new("[é-è]");
2019-11-06T17:25:15.9621607Z 
2019-11-06T17:25:15.9621650Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9621957Z   --> $DIR/regex.rs:18:33
2019-11-06T17:25:15.9622009Z    |
2019-11-06T17:25:15.9622009Z    |
2019-11-06T17:25:15.9622054Z LL |     let some_regex = Regex::new(OPENING_PAREN);
2019-11-06T17:25:15.9622150Z 
2019-11-06T17:25:15.9622191Z error: trivial regex
2019-11-06T17:25:15.9622412Z   --> $DIR/regex.rs:20:53
2019-11-06T17:25:15.9622474Z    |
2019-11-06T17:25:15.9622474Z    |
2019-11-06T17:25:15.9622518Z LL |     let binary_pipe_in_wrong_position = BRegex::new("|");
2019-11-06T17:25:15.9622702Z    |
2019-11-06T17:25:15.9622747Z    = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9622776Z 
2019-11-06T17:25:15.9622820Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9622820Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9623059Z   --> $DIR/regex.rs:21:41
2019-11-06T17:25:15.9623102Z    |
2019-11-06T17:25:15.9623146Z LL |     let some_binary_regex = BRegex::new(OPENING_PAREN);
2019-11-06T17:25:15.9623252Z 
2019-11-06T17:25:15.9623295Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9623498Z   --> $DIR/regex.rs:22:56
2019-11-06T17:25:15.9623560Z    |
2019-11-06T17:25:15.9623560Z    |
2019-11-06T17:25:15.9623607Z LL |     let some_binary_regex_builder = BRegexBuilder::new(OPENING_PAREN);
2019-11-06T17:25:15.9623709Z 
2019-11-06T17:25:15.9623753Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9623964Z   --> $DIR/regex.rs:34:37
2019-11-06T17:25:15.9624006Z    |
2019-11-06T17:25:15.9624006Z    |
2019-11-06T17:25:15.9624275Z LL |     let set_error = RegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T17:25:15.9624596Z 
2019-11-06T17:25:15.9624676Z error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9624941Z   --> $DIR/regex.rs:35:39
2019-11-06T17:25:15.9624985Z    |
2019-11-06T17:25:15.9624985Z    |
2019-11-06T17:25:15.9625241Z LL |     let bset_error = BRegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T17:25:15.9625344Z 
2019-11-06T17:25:15.9625388Z error: regex syntax error: unrecognized escape sequence
2019-11-06T17:25:15.9625611Z   --> $DIR/regex.rs:37:45
2019-11-06T17:25:15.9625653Z    |
2019-11-06T17:25:15.9625653Z    |
2019-11-06T17:25:15.9625698Z LL |     let raw_string_error = Regex::new(r"[...//...]");
2019-11-06T17:25:15.9625802Z 
2019-11-06T17:25:15.9625845Z error: regex syntax error: unrecognized escape sequence
2019-11-06T17:25:15.9626051Z   --> $DIR/regex.rs:38:46
2019-11-06T17:25:15.9626111Z    |
2019-11-06T17:25:15.9626111Z    |
2019-11-06T17:25:15.9626156Z LL |     let raw_string_error = Regex::new(r#"[...//...]"#);
2019-11-06T17:25:15.9626241Z 
2019-11-06T17:25:15.9626301Z error: trivial regex
2019-11-06T17:25:15.9626503Z   --> $DIR/regex.rs:42:33
2019-11-06T17:25:15.9626573Z    |
2019-11-06T17:25:15.9626573Z    |
2019-11-06T17:25:15.9626637Z LL |     let trivial_eq = Regex::new("^foobar$");
2019-11-06T17:25:15.9626725Z    |
2019-11-06T17:25:15.9626725Z    |
2019-11-06T17:25:15.9626786Z    = help: consider using `==` on `str`s
2019-11-06T17:25:15.9626856Z error: trivial regex
2019-11-06T17:25:15.9627067Z   --> $DIR/regex.rs:44:48
2019-11-06T17:25:15.9627127Z    |
2019-11-06T17:25:15.9627127Z    |
2019-11-06T17:25:15.9627182Z LL |     let trivial_eq_builder = RegexBuilder::new("^foobar$");
2019-11-06T17:25:15.9627293Z    |
2019-11-06T17:25:15.9627293Z    |
2019-11-06T17:25:15.9627335Z    = help: consider using `==` on `str`s
2019-11-06T17:25:15.9627404Z error: trivial regex
2019-11-06T17:25:15.9627629Z   --> $DIR/regex.rs:46:42
2019-11-06T17:25:15.9627780Z    |
2019-11-06T17:25:15.9627780Z    |
2019-11-06T17:25:15.9627830Z LL |     let trivial_starts_with = Regex::new("^foobar");
2019-11-06T17:25:15.9627939Z    |
2019-11-06T17:25:15.9627981Z    = help: consider using `str::starts_with`
2019-11-06T17:25:15.9628011Z 
2019-11-06T17:25:15.9628070Z error: trivial regex
2019-11-06T17:25:15.9628070Z error: trivial regex
2019-11-06T17:25:15.9628299Z   --> $DIR/regex.rs:48:40
2019-11-06T17:25:15.9628342Z    |
2019-11-06T17:25:15.9628385Z LL |     let trivial_ends_with = Regex::new("foobar$");
2019-11-06T17:25:15.9628569Z    |
2019-11-06T17:25:15.9628612Z    = help: consider using `str::ends_with`
2019-11-06T17:25:15.9628659Z 
2019-11-06T17:25:15.9628699Z error: trivial regex
---
2019-11-06T17:25:15.9629213Z 
2019-11-06T17:25:15.9629253Z error: trivial regex
2019-11-06T17:25:15.9629457Z   --> $DIR/regex.rs:52:39
2019-11-06T17:25:15.9629519Z    |
2019-11-06T17:25:15.9629564Z LL |     let trivial_contains = Regex::new(NOT_A_REAL_REGEX);
2019-11-06T17:25:15.9629676Z    |
2019-11-06T17:25:15.9629717Z    = help: consider using `str::contains`
2019-11-06T17:25:15.9629754Z 
2019-11-06T17:25:15.9629794Z error: trivial regex
2019-11-06T17:25:15.9629794Z error: trivial regex
2019-11-06T17:25:15.9630015Z   --> $DIR/regex.rs:54:40
2019-11-06T17:25:15.9630058Z    |
2019-11-06T17:25:15.9630100Z LL |     let trivial_backslash = Regex::new("a/.b");
2019-11-06T17:25:15.9630208Z    |
2019-11-06T17:25:15.9630257Z    = help: consider using `str::contains`
2019-11-06T17:25:15.9630286Z 
2019-11-06T17:25:15.9630346Z error: trivial regex
---
2019-11-06T17:25:15.9630832Z 
2019-11-06T17:25:15.9630872Z error: trivial regex
2019-11-06T17:25:15.9631072Z   --> $DIR/regex.rs:59:36
2019-11-06T17:25:15.9631140Z    |
2019-11-06T17:25:15.9631183Z LL |     let trivial_empty = Regex::new("^");
2019-11-06T17:25:15.9631270Z    |
2019-11-06T17:25:15.9631332Z    = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9631362Z 
2019-11-06T17:25:15.9631402Z error: trivial regex
2019-11-06T17:25:15.9631402Z error: trivial regex
2019-11-06T17:25:15.9631625Z   --> $DIR/regex.rs:61:36
2019-11-06T17:25:15.9631676Z    |
2019-11-06T17:25:15.9631719Z LL |     let trivial_empty = Regex::new("^$");
2019-11-06T17:25:15.9631826Z    |
2019-11-06T17:25:15.9631867Z    = help: consider using `str::is_empty`
2019-11-06T17:25:15.9631896Z 
2019-11-06T17:25:15.9631957Z error: trivial regex
2019-11-06T17:25:15.9631957Z error: trivial regex
2019-11-06T17:25:15.9632161Z   --> $DIR/regex.rs:63:44
2019-11-06T17:25:15.9632204Z    |
2019-11-06T17:25:15.9632246Z LL |     let binary_trivial_empty = BRegex::new("^$");
2019-11-06T17:25:15.9632361Z    |
2019-11-06T17:25:15.9632403Z    = help: consider using `str::is_empty`
2019-11-06T17:25:15.9632450Z 
2019-11-06T17:25:15.9632493Z error: aborting due to 23 previous errors
---
2019-11-06T17:25:15.9633152Z -  --> $DIR/regex.rs:13:45
2019-11-06T17:25:15.9633395Z +error[E0463]: can't find crate for `regex`
2019-11-06T17:25:15.9633595Z +  --> $DIR/regex.rs:4:1
2019-11-06T17:25:15.9633639Z     |
2019-11-06T17:25:15.9633881Z -LL |     let pipe_in_wrong_position = Regex::new("|");
2019-11-06T17:25:15.9634290Z -   |
2019-11-06T17:25:15.9634541Z -   = note: `-D clippy::trivial-regex` implied by `-D warnings`
2019-11-06T17:25:15.9634772Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9634889Z +LL | extern crate regex;
2019-11-06T17:25:15.9634889Z +LL | extern crate regex;
2019-11-06T17:25:15.9635119Z +   | ^^^^^^^^^^^^^^^^^^^ can't find crate
2019-11-06T17:25:15.9635183Z  
2019-11-06T17:25:15.9635378Z -error: trivial regex
2019-11-06T17:25:15.9635577Z -  --> $DIR/regex.rs:14:60
2019-11-06T17:25:15.9635776Z -   |
2019-11-06T17:25:15.9636013Z -LL |     let pipe_in_wrong_position_builder = RegexBuilder::new("|");
2019-11-06T17:25:15.9638102Z -   |
2019-11-06T17:25:15.9639007Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9639076Z +error: aborting due to previous error
2019-11-06T17:25:15.9639145Z  
2019-11-06T17:25:15.9639145Z  
2019-11-06T17:25:15.9639676Z -error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T17:25:15.9640188Z -   |
2019-11-06T17:25:15.9640188Z -   |
2019-11-06T17:25:15.9640421Z -LL |     let wrong_char_ranice = Regex::new("[z-a]");
2019-11-06T17:25:15.9640846Z -   |
2019-11-06T17:25:15.9640846Z -   |
2019-11-06T17:25:15.9641102Z -   = note: `-D clippy::invalid-regex` implied by `-D warnings`
2019-11-06T17:25:15.9641281Z -
2019-11-06T17:25:15.9641534Z -error: regex syntax error: invalid character class range, the start must be <= the end
2019-11-06T17:25:15.9641948Z -   |
2019-11-06T17:25:15.9641948Z -   |
2019-11-06T17:25:15.9642176Z -LL |     let some_unicode = Regex::new("[é-è]");
2019-11-06T17:25:15.9642600Z -
2019-11-06T17:25:15.9642825Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9643027Z -  --> $DIR/regex.rs:18:33
2019-11-06T17:25:15.9643226Z -   |
2019-11-06T17:25:15.9643226Z -   |
2019-11-06T17:25:15.9643448Z -LL |     let some_regex = Regex::new(OPENING_PAREN);
2019-11-06T17:25:15.9643884Z -
2019-11-06T17:25:15.9644076Z -error: trivial regex
2019-11-06T17:25:15.9644276Z -  --> $DIR/regex.rs:20:53
2019-11-06T17:25:15.9644471Z -   |
2019-11-06T17:25:15.9644471Z -   |
2019-11-06T17:25:15.9644706Z -LL |     let binary_pipe_in_wrong_position = BRegex::new("|");
2019-11-06T17:25:15.9645125Z -   |
2019-11-06T17:25:15.9645378Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9645560Z -
2019-11-06T17:25:15.9645785Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9645785Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9646007Z -  --> $DIR/regex.rs:21:41
2019-11-06T17:25:15.9646187Z -   |
2019-11-06T17:25:15.9646416Z -LL |     let some_binary_regex = BRegex::new(OPENING_PAREN);
2019-11-06T17:25:15.9647145Z -
2019-11-06T17:25:15.9647372Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9647591Z -  --> $DIR/regex.rs:22:56
2019-11-06T17:25:15.9647789Z -   |
2019-11-06T17:25:15.9647789Z -   |
2019-11-06T17:25:15.9648033Z -LL |     let some_binary_regex_builder = BRegexBuilder::new(OPENING_PAREN);
2019-11-06T17:25:15.9648485Z -
2019-11-06T17:25:15.9648711Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9648913Z -  --> $DIR/regex.rs:34:37
2019-11-06T17:25:15.9649112Z -   |
2019-11-06T17:25:15.9649112Z -   |
2019-11-06T17:25:15.9649528Z -LL |     let set_error = RegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T17:25:15.9650010Z -
2019-11-06T17:25:15.9650238Z -error: regex syntax error on position 0: unclosed group
2019-11-06T17:25:15.9650437Z -  --> $DIR/regex.rs:35:39
2019-11-06T17:25:15.9650632Z -   |
2019-11-06T17:25:15.9650632Z -   |
2019-11-06T17:25:15.9650888Z -LL |     let bset_error = BRegexSet::new(&[OPENING_PAREN, r"[a-z]+/.(com|org|net)"]);
2019-11-06T17:25:15.9651404Z -
2019-11-06T17:25:15.9652617Z -error: regex syntax error: unrecognized escape sequence
2019-11-06T17:25:15.9652841Z -  --> $DIR/regex.rs:37:45
2019-11-06T17:25:15.9653018Z -   |
2019-11-06T17:25:15.9653018Z -   |
2019-11-06T17:25:15.9653272Z -LL |     let raw_string_error = Regex::new(r"[...//...]");
2019-11-06T17:25:15.9653676Z -
2019-11-06T17:25:15.9653928Z -error: regex syntax error: unrecognized escape sequence
2019-11-06T17:25:15.9654136Z -  --> $DIR/regex.rs:38:46
2019-11-06T17:25:15.9654315Z -   |
2019-11-06T17:25:15.9654315Z -   |
2019-11-06T17:25:15.9654544Z -LL |     let raw_string_error = Regex::new(r#"[...//...]"#);
2019-11-06T17:25:15.9656306Z -
2019-11-06T17:25:15.9656756Z -error: trivial regex
2019-11-06T17:25:15.9657043Z -  --> $DIR/regex.rs:42:33
2019-11-06T17:25:15.9657224Z -   |
2019-11-06T17:25:15.9657224Z -   |
2019-11-06T17:25:15.9657444Z -LL |     let trivial_eq = Regex::new("^foobar$");
2019-11-06T17:25:15.9658391Z -   |
2019-11-06T17:25:15.9658391Z -   |
2019-11-06T17:25:15.9658864Z -   = help: consider using `==` on `str`s
2019-11-06T17:25:15.9659269Z -error: trivial regex
2019-11-06T17:25:15.9659825Z -  --> $DIR/regex.rs:44:48
2019-11-06T17:25:15.9660013Z -   |
2019-11-06T17:25:15.9660013Z -   |
2019-11-06T17:25:15.9662588Z -LL |     let trivial_eq_builder = RegexBuilder::new("^foobar$");
2019-11-06T17:25:15.9664665Z -   |
2019-11-06T17:25:15.9664665Z -   |
2019-11-06T17:25:15.9664936Z -   = help: consider using `==` on `str`s
2019-11-06T17:25:15.9665312Z -error: trivial regex
2019-11-06T17:25:15.9665514Z -  --> $DIR/regex.rs:46:42
2019-11-06T17:25:15.9665714Z -   |
2019-11-06T17:25:15.9665714Z -   |
2019-11-06T17:25:15.9665942Z -LL |     let trivial_starts_with = Regex::new("^foobar");
2019-11-06T17:25:15.9667252Z -   |
2019-11-06T17:25:15.9667471Z -   = help: consider using `str::starts_with`
2019-11-06T17:25:15.9667650Z -
2019-11-06T17:25:15.9667860Z -error: trivial regex
2019-11-06T17:25:15.9667860Z -error: trivial regex
2019-11-06T17:25:15.9668062Z -  --> $DIR/regex.rs:48:40
2019-11-06T17:25:15.9668240Z -   |
2019-11-06T17:25:15.9668466Z -LL |     let trivial_ends_with = Regex::new("foobar$");
2019-11-06T17:25:15.9668903Z -   |
2019-11-06T17:25:15.9669120Z -   = help: consider using `str::ends_with`
2019-11-06T17:25:15.9669318Z -
2019-11-06T17:25:15.9669509Z -error: trivial regex
---
2019-11-06T17:25:15.9670989Z -
2019-11-06T17:25:15.9671204Z -error: trivial regex
2019-11-06T17:25:15.9671451Z -  --> $DIR/regex.rs:52:39
2019-11-06T17:25:15.9671652Z -   |
2019-11-06T17:25:15.9671906Z -LL |     let trivial_contains = Regex::new(NOT_A_REAL_REGEX);
2019-11-06T17:25:15.9672387Z -   |
2019-11-06T17:25:15.9672621Z -   = help: consider using `str::contains`
2019-11-06T17:25:15.9672969Z -
2019-11-06T17:25:15.9673714Z -error: trivial regex
2019-11-06T17:25:15.9673714Z -error: trivial regex
2019-11-06T17:25:15.9674257Z -  --> $DIR/regex.rs:54:40
2019-11-06T17:25:15.9674452Z -   |
2019-11-06T17:25:15.9674701Z -LL |     let trivial_backslash = Regex::new("a/.b");
2019-11-06T17:25:15.9675110Z -   |
2019-11-06T17:25:15.9675342Z -   = help: consider using `str::contains`
2019-11-06T17:25:15.9675536Z -
2019-11-06T17:25:15.9675749Z -error: trivial regex
---
2019-11-06T17:25:15.9677763Z -
2019-11-06T17:25:15.9677970Z -error: trivial regex
2019-11-06T17:25:15.9678174Z -  --> $DIR/regex.rs:59:36
2019-11-06T17:25:15.9678361Z -   |
2019-11-06T17:25:15.9678579Z -LL |     let trivial_empty = Regex::new("^");
2019-11-06T17:25:15.9679001Z -   |
2019-11-06T17:25:15.9679223Z -   = help: the regex is unlikely to be useful as it is
2019-11-06T17:25:15.9679419Z -
2019-11-06T17:25:15.9679613Z -error: trivial regex
2019-11-06T17:25:15.9679613Z -error: trivial regex
2019-11-06T17:25:15.9680535Z -  --> $DIR/regex.rs:61:36
2019-11-06T17:25:15.9680732Z -   |
2019-11-06T17:25:15.9680976Z -LL |     let trivial_empty = Regex::new("^$");
2019-11-06T17:25:15.9681981Z -   |
2019-11-06T17:25:15.9682303Z -   = help: consider using `str::is_empty`
2019-11-06T17:25:15.9682500Z -
2019-11-06T17:25:15.9682708Z -error: trivial regex
2019-11-06T17:25:15.9682708Z -error: trivial regex
2019-11-06T17:25:15.9684174Z -  --> $DIR/regex.rs:63:44
2019-11-06T17:25:15.9684935Z -   |
2019-11-06T17:25:15.9685172Z -LL |     let binary_trivial_empty = BRegex::new("^$");
2019-11-06T17:25:15.9685629Z -   |
2019-11-06T17:25:15.9685840Z -   = help: consider using `str::is_empty`
2019-11-06T17:25:15.9686016Z -
2019-11-06T17:25:15.9686252Z -error: aborting due to 23 previous errors
---
2019-11-06T17:25:15.9689805Z 
2019-11-06T17:25:15.9690024Z ------------------------------------------
2019-11-06T17:25:15.9690087Z stderr:
2019-11-06T17:25:15.9690298Z ------------------------------------------
2019-11-06T17:25:15.9691526Z {"message":"can't find crate for `regex`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/regex.rs","byte_start":95,"byte_end":114,"line_start":4,"line_end":4,"column_start":1,"column_end":20,"is_primary":true,"text":[{"text":"extern crate regex;","highlight_start":1,"highlight_end":20}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `regex`\n  --> tests/ui/regex.rs:4:1\n   |\nLL | extern crate regex;\n   | ^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T17:25:15.9692219Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T17:25:15.9692298Z 
2019-11-06T17:25:15.9692517Z ------------------------------------------
2019-11-06T17:25:15.9692550Z 
2019-11-06T17:25:15.9692550Z 
2019-11-06T17:25:15.9692577Z 
2019-11-06T17:25:15.9692821Z ---- [ui] ui/used_underscore_binding.rs stdout ----
2019-11-06T17:25:15.9692869Z normalized stderr:
2019-11-06T17:25:15.9693093Z error[E0463]: can't find crate for `clippy_lints`
2019-11-06T17:25:15.9693312Z   --> $DIR/used_underscore_binding.rs:12:10
2019-11-06T17:25:15.9693376Z    |
2019-11-06T17:25:15.9693419Z LL |   #[derive(DeriveSomething)]
2019-11-06T17:25:15.9693532Z LL | | struct Baz;
2019-11-06T17:25:15.9693573Z LL | |
2019-11-06T17:25:15.9693573Z LL | |
2019-11-06T17:25:15.9693615Z LL | | macro_rules! test_macro {
2019-11-06T17:25:15.9693716Z LL | |
2019-11-06T17:25:15.9693764Z LL | | /// Tests that we lint if we use a binding with a single leading underscore
2019-11-06T17:25:15.9693975Z    | |_^ can't find crate
2019-11-06T17:25:15.9694023Z 
2019-11-06T17:25:15.9694023Z 
2019-11-06T17:25:15.9694074Z error: aborting due to previous error
2019-11-06T17:25:15.9694102Z 
2019-11-06T17:25:15.9694345Z For more information about this error, try `rustc --explain E0463`.
2019-11-06T17:25:15.9694400Z 
2019-11-06T17:25:15.9694425Z 
2019-11-06T17:25:15.9694466Z expected stderr:
2019-11-06T17:25:15.9694521Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9694819Z    |
2019-11-06T17:25:15.9694819Z    |
2019-11-06T17:25:15.9694879Z LL |     _foo + 1
2019-11-06T17:25:15.9694968Z    |
2019-11-06T17:25:15.9695215Z    = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T17:25:15.9695266Z 
2019-11-06T17:25:15.9695266Z 
2019-11-06T17:25:15.9695318Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9695684Z    |
2019-11-06T17:25:15.9695732Z LL |     println!("{}", _foo);
2019-11-06T17:25:15.9695776Z    |                    ^^^^
2019-11-06T17:25:15.9695807Z 
2019-11-06T17:25:15.9695807Z 
2019-11-06T17:25:15.9695878Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9696169Z    |
2019-11-06T17:25:15.9696169Z    |
2019-11-06T17:25:15.9696231Z LL |     assert_eq!(_foo, _foo);
2019-11-06T17:25:15.9696302Z 
2019-11-06T17:25:15.9696302Z 
2019-11-06T17:25:15.9696429Z error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9697117Z    |
2019-11-06T17:25:15.9697117Z    |
2019-11-06T17:25:15.9697159Z LL |     assert_eq!(_foo, _foo);
2019-11-06T17:25:15.9697253Z 
2019-11-06T17:25:15.9697253Z 
2019-11-06T17:25:15.9697318Z error: used binding `_underscore_field` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9697625Z    |
2019-11-06T17:25:15.9697625Z    |
2019-11-06T17:25:15.9697668Z LL |     s._underscore_field += 1;
2019-11-06T17:25:15.9697758Z 
2019-11-06T17:25:15.9697799Z error: aborting due to 5 previous errors
2019-11-06T17:25:15.9697828Z 
2019-11-06T17:25:15.9697853Z 
2019-11-06T17:25:15.9697853Z 
2019-11-06T17:25:15.9697877Z 
2019-11-06T17:25:15.9697936Z diff of stderr:
2019-11-06T17:25:15.9697971Z 
2019-11-06T17:25:15.9698277Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9698752Z +error[E0463]: can't find crate for `clippy_lints`
2019-11-06T17:25:15.9698973Z +  --> $DIR/used_underscore_binding.rs:12:10
2019-11-06T17:25:15.9699026Z     |
2019-11-06T17:25:15.9699026Z     |
2019-11-06T17:25:15.9699239Z -LL |     _foo + 1
2019-11-06T17:25:15.9699608Z -   |
2019-11-06T17:25:15.9699871Z -   = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T17:25:15.9699871Z -   = note: `-D clippy::used-underscore-binding` implied by `-D warnings`
2019-11-06T17:25:15.9699921Z +LL |   #[derive(DeriveSomething)]
2019-11-06T17:25:15.9700025Z +LL | | struct Baz;
2019-11-06T17:25:15.9700066Z +LL | |
2019-11-06T17:25:15.9700066Z +LL | |
2019-11-06T17:25:15.9700108Z +LL | | macro_rules! test_macro {
2019-11-06T17:25:15.9700149Z +...  |
2019-11-06T17:25:15.9700264Z +LL | | /// Tests that we lint if we use a binding with a single leading underscore
2019-11-06T17:25:15.9700474Z +   | |_^ can't find crate
2019-11-06T17:25:15.9700535Z  
2019-11-06T17:25:15.9700535Z  
2019-11-06T17:25:15.9700833Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9701271Z -   |
2019-11-06T17:25:15.9701480Z -LL |     println!("{}", _foo);
2019-11-06T17:25:15.9701683Z -   |                    ^^^^
2019-11-06T17:25:15.9701729Z +error: aborting due to previous error
2019-11-06T17:25:15.9701729Z +error: aborting due to previous error
2019-11-06T17:25:15.9701788Z  
2019-11-06T17:25:15.9702083Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9702515Z -   |
2019-11-06T17:25:15.9702515Z -   |
2019-11-06T17:25:15.9702719Z -LL |     assert_eq!(_foo, _foo);
2019-11-06T17:25:15.9703122Z -
2019-11-06T17:25:15.9703122Z -
2019-11-06T17:25:15.9703412Z -error: used binding `_foo` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9703835Z -   |
2019-11-06T17:25:15.9703835Z -   |
2019-11-06T17:25:15.9704041Z -LL |     assert_eq!(_foo, _foo);
2019-11-06T17:25:15.9705304Z -
2019-11-06T17:25:15.9705304Z -
2019-11-06T17:25:15.9705661Z -error: used binding `_underscore_field` which is prefixed with an underscore. A leading underscore signals that a binding will not be used.
2019-11-06T17:25:15.9706075Z -   |
2019-11-06T17:25:15.9706075Z -   |
2019-11-06T17:25:15.9706302Z -LL |     s._underscore_field += 1;
2019-11-06T17:25:15.9710396Z -
2019-11-06T17:25:15.9710659Z -error: aborting due to 5 previous errors
2019-11-06T17:25:15.9711017Z -
2019-11-06T17:25:15.9711517Z +For more information about this error, try `rustc --explain E0463`.
---
2019-11-06T17:25:15.9714291Z 
2019-11-06T17:25:15.9714886Z ------------------------------------------
2019-11-06T17:25:15.9714940Z stderr:
2019-11-06T17:25:15.9715162Z ------------------------------------------
2019-11-06T17:25:15.9722202Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/used_underscore_binding.rs","byte_start":340,"byte_end":7515520,"line_start":12,"line_end":22,"column_start":10,"column_end":2,"is_primary":true,"text":[],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":{"span":{"file_name":"tests/ui/used_underscore_binding.rs","byte_start":340,"byte_end":355,"line_start":12,"line_end":12,"column_start":10,"column_end":25,"is_primary":false,"text":[{"text":"#[derive(DeriveSomething)]","highlight_start":10,"highlight_end":25}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null},"macro_decl_name":"#[derive(DeriveSomething)]","def_site_span":{"file_name":"/checkout/src/tools/clippy/tests/ui/auxiliary/proc_macro_derive.rs","byte_start":215,"byte_end":549,"line_start":11,"line_end":22,"column_start":1,"column_end":2,"is_primary":false,"text":[{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":1},{"text":"","highlight_start":1,"highlight_end":2}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}}}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/used_underscore_binding.rs:12:10\n   |\nLL |   #[derive(DeriveSomething)]\n   |  __________^\nLL | | struct Baz;\nLL | |\nLL | | macro_rules! test_macro {\n...  |\nLL | |\nLL | | /// Tests that we lint if we use a binding with a single leading underscore\n   | |_^ can't find crate\n\n"}
2019-11-06T17:25:15.9723436Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T17:25:15.9723495Z 
2019-11-06T17:25:15.9723718Z ------------------------------------------
2019-11-06T17:25:15.9723771Z 
---
2019-11-06T17:25:15.9725359Z expected stderr:
2019-11-06T17:25:15.9725402Z error: useless lint attribute
2019-11-06T17:25:15.9725616Z   --> $DIR/useless_attribute.rs:6:1
2019-11-06T17:25:15.9725679Z    |
2019-11-06T17:25:15.9725721Z LL | #[allow(dead_code)]
2019-11-06T17:25:15.9725779Z    | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
2019-11-06T17:25:15.9726083Z    = note: `-D clippy::useless-attribute` implied by `-D warnings`
2019-11-06T17:25:15.9726117Z 
2019-11-06T17:25:15.9726158Z error: useless lint attribute
2019-11-06T17:25:15.9726382Z   --> $DIR/useless_attribute.rs:7:1
2019-11-06T17:25:15.9726382Z   --> $DIR/useless_attribute.rs:7:1
2019-11-06T17:25:15.9726426Z    |
2019-11-06T17:25:15.9726951Z LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
2019-11-06T17:25:15.9727309Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
2019-11-06T17:25:15.9727411Z error: aborting due to 2 previous errors
2019-11-06T17:25:15.9727440Z 
2019-11-06T17:25:15.9727483Z 
2019-11-06T17:25:15.9727508Z 
2019-11-06T17:25:15.9727508Z 
2019-11-06T17:25:15.9727549Z diff of stderr:
2019-11-06T17:25:15.9727576Z 
2019-11-06T17:25:15.9727786Z -error: useless lint attribute
2019-11-06T17:25:15.9728017Z -  --> $DIR/useless_attribute.rs:6:1
2019-11-06T17:25:15.9728367Z +error[E0463]: can't find crate for `clippy_lints`
2019-11-06T17:25:15.9728623Z +  --> $DIR/useless_attribute.rs:14:1
2019-11-06T17:25:15.9728689Z     |
2019-11-06T17:25:15.9728887Z -LL | #[allow(dead_code)]
2019-11-06T17:25:15.9729141Z -   | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
2019-11-06T17:25:15.9729582Z -   = note: `-D clippy::useless-attribute` implied by `-D warnings`
2019-11-06T17:25:15.9729632Z +LL | extern crate clippy_lints;
2019-11-06T17:25:15.9729867Z +   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
2019-11-06T17:25:15.9729990Z  
2019-11-06T17:25:15.9729990Z  
2019-11-06T17:25:15.9730212Z -error: useless lint attribute
2019-11-06T17:25:15.9730424Z -  --> $DIR/useless_attribute.rs:7:1
2019-11-06T17:25:15.9730627Z -   |
2019-11-06T17:25:15.9730858Z -LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
2019-11-06T17:25:15.9731183Z -   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code)`
2019-11-06T17:25:15.9731299Z  
2019-11-06T17:25:15.9731517Z -error: aborting due to 2 previous errors
2019-11-06T17:25:15.9731710Z -
2019-11-06T17:25:15.9731950Z +For more information about this error, try `rustc --explain E0463`.
---
2019-11-06T17:25:15.9735150Z 
2019-11-06T17:25:15.9735370Z ------------------------------------------
2019-11-06T17:25:15.9735434Z stderr:
2019-11-06T17:25:15.9735648Z ------------------------------------------
2019-11-06T17:25:15.9737252Z {"message":"can't find crate for `clippy_lints`","code":{"code":"E0463","explanation":"\nA plugin/crate was declared but cannot be found. Erroneous code example:\n\n```compile_fail,E0463\n#![feature(plugin)]\n#![plugin(cookie_monster)] // error: can't find crate for `cookie_monster`\nextern crate cake_is_a_lie; // error: can't find crate for `cake_is_a_lie`\n```\n\nYou need to link your code to the relevant crate in order to be able to use it\n(through Cargo or the `-L` option of rustc example). Plugins are crates as\nwell, and you link to them the same way.\n"},"level":"error","spans":[{"file_name":"tests/ui/useless_attribute.rs","byte_start":327,"byte_end":353,"line_start":14,"line_end":14,"column_start":1,"column_end":27,"is_primary":true,"text":[{"text":"extern crate clippy_lints;","highlight_start":1,"highlight_end":27}],"label":"can't find crate","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0463]: can't find crate for `clippy_lints`\n  --> tests/ui/useless_attribute.rs:14:1\n   |\nLL | extern crate clippy_lints;\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate\n\n"}
2019-11-06T17:25:15.9738077Z {"message":"For more information about this error, try `rustc --explain E0463`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0463`.\n"}
2019-11-06T17:25:15.9738153Z 
2019-11-06T17:25:15.9738378Z ------------------------------------------
2019-11-06T17:25:15.9738411Z 
---
2019-11-06T18:01:57.5487742Z Verifying status of rustfmt...
2019-11-06T18:01:57.5501678Z Verifying status of clippy-driver...
2019-11-06T18:01:57.5516344Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-11-06T18:01:57.5526898Z 
2019-11-06T18:01:57.5528948Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-11-06T18:01:57.5529069Z 
2019-11-06T18:01:57.5529402Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-11-06T18:01:57.5529464Z commit another update.
2019-11-06T18:01:57.5529496Z 
2019-11-06T18:01:57.5530061Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-11-06T18:01:57.5530402Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-11-06T18:01:57.5530461Z proper steps.
2019-11-06T18:01:57.5554615Z   local time: Wed Nov  6 18:01:57 UTC 2019
2019-11-06T18:01:57.8499583Z   network time: Wed, 06 Nov 2019 18:01:57 GMT
2019-11-06T18:01:57.8503410Z == end clock drift check ==
2019-11-06T18:01:58.4063292Z 
2019-11-06T18:01:58.4063292Z 
2019-11-06T18:01:58.4169609Z ##[error]Bash exited with code '3'.
2019-11-06T18:01:58.4216238Z ##[section]Starting: Checkout
2019-11-06T18:01:58.4218103Z ==============================================================================
2019-11-06T18:01:58.4218165Z Task         : Get sources
2019-11-06T18:01:58.4218217Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

RalfJung and others added 27 commits November 4, 2019 09:50

QPath docs: mention how to resolve them

6515371

also explain how to resolve MethodCall

151e989

Do not require extra LLVM backends for x.py test to pass

d22a659

link from raw slice creation methods to safety requirements

82dc3aa

expand slice from_raw_part docs

1a254e4

also edit String::from_raw_parts while we are at it

6a1f303

fix link to ptr docs

b1d0a68

LinkedList: PhantomData<Box<Node<T>>> => PhantomData<T>

3a54ab7

Reverted PhantomData in LinkedList, fixed PhantomData markers in Rc a…

45f281d

…nd Arc

Apply suggestions from code review

11a48a0

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

Fixed libcore/cell.rs example

6a59319

gate rustc_on_unimplemented under rustc_attrs

1c7595f

Update local.rs

936349c

Removed parameters not used in the macro

miri cast: avoid unnecessary to_scalar_ptr

14ee66a

remvoe to_scalar_ptr and use ref_to_mplace everywhere

32453ce

improve a comment

87edcf0

--bless

2312a56

Fix markdown link

f2ed1e6

Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>

update clippy to fix toolstate

8ec83cf

Rollup merge of rust-lang#65794 - Centril:unimpl-internal, r=varkor

db341c1

gate rustc_on_unimplemented under rustc_attrs Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal. Closes rust-lang#29628 r? @varkor

Rollup merge of rust-lang#66076 - RalfJung:qpath, r=davidtwco,oli-obk

9bfb5cc

HIR docs: mention how to resolve method paths

Rollup merge of rust-lang#66084 - petrochenkov:x86arm, r=alexcrichton

ab08821

Do not require extra LLVM backends for `x.py test` to pass For long time our testing passed with a partially built LLVM ``` [llvm] targets = "X86;ARM" ``` , a [recent PR](rust-lang#65809) changed that.

Rollup merge of rust-lang#66111 - RalfJung:from_raw_parts, r=Centril

5723176

improve from_raw_parts docs Triggered by rust-lang/rfcs#2806. Hopefully this helps clarify that joining slices across allocations is not possible in Rust currently. r? @Centril

Rollup merge of rust-lang#66146 - 3442853561:patch-2, r=Mark-Simulacrum

f573bd8

Remove unused parameters in `__thread_local_inner` Fixes rust-lang#65993.

Rollup merge of rust-lang#66158 - lzutao:clippyup, r=Manishearth

454032f

update clippy to fix toolstate Close rust-lang#66150. Close rust-lang#62558 thanks to @msizanoen1 .

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 6, 2019

rustbot added the rollup A PR which is a rollup label Nov 6, 2019

pietroalbini closed this Nov 6, 2019

pietroalbini deleted the rollup-yk37ged branch November 7, 2019 08:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #66160

Rollup of 8 pull requests #66160

pietroalbini commented Nov 6, 2019

pietroalbini commented Nov 6, 2019 •

edited

Loading

bors commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

tesuji commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

pietroalbini commented Nov 6, 2019

rust-highfive commented Nov 6, 2019

Rollup of 8 pull requests #66160

Rollup of 8 pull requests #66160

Conversation

pietroalbini commented Nov 6, 2019

pietroalbini commented Nov 6, 2019 • edited Loading

bors commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

tesuji commented Nov 6, 2019

bors commented Nov 6, 2019

bors commented Nov 6, 2019

pietroalbini commented Nov 6, 2019

rust-highfive commented Nov 6, 2019

pietroalbini commented Nov 6, 2019 •

edited

Loading