Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rustc-guide #66161

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Update rustc-guide #66161

merged 1 commit into from
Nov 11, 2019

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Nov 6, 2019

r? @ehuss

fix #66144

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@ehuss
Copy link
Contributor

ehuss commented Nov 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 7ddb899 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 8, 2019
@Centril
Rollup merge of rust-lang#66161 - mark-i-m:fix-rustc-guide, r=ehuss
e30dfed 
Update rustc-guide

r? @ehuss

fix rust-lang#66144
@Centril Centril mentioned this pull request Nov 8, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

Failed in #66218 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2019
@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 8, 2019

Oh, I thought we said we didn't want to rollup rustc-guide updates since they frequently break. In this case, the links changed yesterday. I have a PR up to fix them and will update this PR after that.

@mark-i-m
Copy link
Member Author

mark-i-m commented Nov 8, 2019

@ehuss Updated

@Centril norullup please ❤️ Sorry for the trouble.

@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

@bors rollup=never

@ehuss
Copy link
Contributor

ehuss commented Nov 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 8635482 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2019
@bors
Copy link
Contributor

bors commented Nov 10, 2019

⌛ Testing commit 8635482 with merge e2fa952...

bors added a commit that referenced this pull request Nov 10, 2019
@bors
Auto merge of #66161 - mark-i-m:fix-rustc-guide, r=ehuss
e2fa952 
Update rustc-guide

r? @ehuss

fix #66144
@bors
Copy link
Contributor

bors commented Nov 11, 2019

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing e2fa952 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2019
@bors bors merged commit 8635482 into rust-lang:master Nov 11, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #66161!

Tested on commit e2fa952.
Direct link to PR: #66161

🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 11, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#66161!
edbf8c7 
Tested on commit rust-lang/rust@e2fa952.
Direct link to PR: <rust-lang/rust#66161>

🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
@mark-i-m mark-i-m deleted the fix-rustc-guide branch December 11, 2019 21:35
@JohnTitor JohnTitor mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in rustbook
5 participants
@mark-i-m @rust-highfive @ehuss @bors @Centril