Update mdbook.

[ehuss]

This brings in some important updates to fix some rendering issues in the books. In particular fixing hidden lines in code blocks, and some escaping issues. More details at https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md

This also requires updating mdbook-linkcheck.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[ehuss]

cc @mark-i-m @Michael-F-Bryan
I had to remove the timeout filter for mdbook-linkcheck, as the API doesn't seem to provide a way to do it anymore. Would it be possible to extend mdbook-linkcheck to make that a built-in feature?

Also, the API is a little awkward, needing to import a separate crate for the ColorChoice.

[alexcrichton]

@bors: r+

[bors]

📌 Commit 139477d has been approved by alexcrichton

[Michael-F-Bryan]

Would it be possible to extend mdbook-linkcheck to make that a built-in feature?

You can actually remove the hack checking if "timed out" is in the error message because all necessary information is exposed in the invalid link error.

I'm not sure of the exact code you'd write (on phone), but the chain of items you're looking for are:

1. ValidationOutcome::invalid_links
2. InvalidLink::reason
3. Reason::Client(reqwest::Error)
4. reqwest::Error::is_timeout()

Also, the API is a little awkward, needing to import a separate crate for the ColorChoice.

Sorry about the awkward API! I'll see if I can make a new patch release which re-exports the enum so you can avoid adding the dependency to Cargo.toml and keep it in sync.

[ehuss]

Sorry Alex, you're too fast. I forgot to check licenses, and needed to push an update.

@Michael-F-Bryan None of those are pub exposed APIs. Primarily check_links is not pub. It's also a bit unfortunate needing to duplicate all the logic in the run function.

[alexcrichton]

@bors: r+

[bors]

📌 Commit 32d1f47 has been approved by alexcrichton

[mark-i-m]

@ehuss Do you know if it is possible to take advantage of mdbook-linkcheck caching now? That is we would store the link cache. If we do that, then I think we don't need to worry about timeouts as much because we will be making fewer requests to start with... Does Azure pipelines have a way to cache artifacts and restore them?

[ehuss]

if it is possible to take advantage of mdbook-linkcheck caching now?

Azure has a beta preview of caching, but the rust repo does not use it. Typically s3 buckets are used, but I do not know anything about them or whether it would be appropriate to use.

[Michael-F-Bryan]

@Michael-F-Bryan None of those are pub exposed APIs. Primarily check_links is not pub.

Ah, I was looking at mdbook_linkcheck::validate(). I'm guessing it should be fine to make that pub seeing as it's the main way you'd want to programmatically use mdbook-linkcheck once a book has been loaded into memory.