-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dataflow-based const qualification the canonical one #66385
Merged
Commits on Nov 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1924cc8 - Browse repository at this point
Copy the full SHA 1924cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbae15a - Browse repository at this point
Copy the full SHA dbae15aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4881104 - Browse repository at this point
Copy the full SHA 4881104View commit details -
Enable standalone const-checking with
Validator
Unlike the original pass, we check *every* non-cleanup basic block instead of stopping at `SwitchInt`. We use the `is_cfg_cyclic` function to check for loops unlike the original checker which could not differentiate between true cycles and basic blocks with more than two predecessors. The last three functions are all copied verbatim from `qualify_consts`.
Configuration menu - View commit details
-
Copy full SHA for 973b16a - Browse repository at this point
Copy the full SHA 973b16aView commit details -
Use new const-checker for
mir_const_qualif
Now `mir_const_qualif` must be called for `static`s and `const fn`s as well as `const`s since it is responsible for const-checking. We return the qualifs in the return place for everything, even though they will only be used for `const`s.
Configuration menu - View commit details
-
Copy full SHA for 55da0c0 - Browse repository at this point
Copy the full SHA 55da0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4e204 - Browse repository at this point
Copy the full SHA 6d4e204View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7527766 - Browse repository at this point
Copy the full SHA 7527766View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d2bc50 - Browse repository at this point
Copy the full SHA 3d2bc50View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8156b9 - Browse repository at this point
Copy the full SHA c8156b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f5494b - Browse repository at this point
Copy the full SHA 8f5494bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f0ef5 - Browse repository at this point
Copy the full SHA d1f0ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a2e53a - Browse repository at this point
Copy the full SHA 9a2e53aView commit details -
A
Downcast
is now reached when const-checking afor
loopI believe this occurs because the old checker stopped processing basic blocks after a `SwitchInt`.
Configuration menu - View commit details
-
Copy full SHA for a4ce201 - Browse repository at this point
Copy the full SHA a4ce201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 056edc0 - Browse repository at this point
Copy the full SHA 056edc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e840f8 - Browse repository at this point
Copy the full SHA 1e840f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea95e94 - Browse repository at this point
Copy the full SHA ea95e94View commit details -
Remove newtype for qualifs in
rustc_metadata
We have a proper type for these now, so the wrapper is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for a1135cc - Browse repository at this point
Copy the full SHA a1135ccView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.