Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for fixed ICEs #66407

Merged
merged 5 commits into from
Nov 16, 2019
Merged

Add more tests for fixed ICEs #66407

merged 5 commits into from
Nov 16, 2019

Conversation

JohnTitor
Copy link
Member

Closes #36122 (fixed in 1.20.0)
Closes #58094 (fixed in #66054)
Also, fix mistaken test case, from #30904 to #30906 (cc @eddyb)

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2019
@Centril
Copy link
Contributor

Centril commented Nov 14, 2019

r=me rollup with comment ^-- addressed

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-14T09:15:42.4392114Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-14T09:15:42.4595011Z ##[command]git config gc.auto 0
2019-11-14T09:15:42.4672564Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-14T09:15:42.4731808Z ##[command]git config --get-all http.proxy
2019-11-14T09:15:42.4899092Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66407/merge:refs/remotes/pull/66407/merge
---
2019-11-14T09:21:42.6989621Z    Compiling serde_json v1.0.40
2019-11-14T09:21:44.3837934Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-11-14T09:21:54.7443967Z     Finished release [optimized] target(s) in 1m 24s
2019-11-14T09:21:54.7550190Z tidy check
2019-11-14T09:21:54.9518466Z tidy error: /checkout/src/test/ui/parser/issue-58094-missing-right-square-bracket.rs: ignoring trailing newlines unnecessarily
2019-11-14T09:21:57.3356558Z Found 486 error codes
2019-11-14T09:21:57.3357419Z Found 0 error codes with no tests
2019-11-14T09:21:57.3357994Z Done!
2019-11-14T09:21:57.3358387Z some tidy checks failed
2019-11-14T09:21:57.3358387Z some tidy checks failed
2019-11-14T09:21:57.3360647Z 
2019-11-14T09:21:57.3361183Z 
2019-11-14T09:21:57.3365884Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-14T09:21:57.3366688Z 
2019-11-14T09:21:57.3366863Z 
2019-11-14T09:21:57.3378295Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-14T09:21:57.3378878Z Build completed unsuccessfully in 0:01:27
2019-11-14T09:21:57.3378878Z Build completed unsuccessfully in 0:01:27
2019-11-14T09:21:57.3443639Z == clock drift check ==
2019-11-14T09:21:57.3445114Z   local time: Thu Nov 14 09:21:57 UTC 2019
2019-11-14T09:21:57.4954385Z   network time: Thu, 14 Nov 2019 09:21:57 GMT
2019-11-14T09:21:57.4954721Z == end clock drift check ==
2019-11-14T09:21:58.7629442Z 
2019-11-14T09:21:58.7744561Z ##[error]Bash exited with code '1'.
2019-11-14T09:21:58.7767233Z ##[section]Starting: Checkout
2019-11-14T09:21:58.7768779Z ==============================================================================
2019-11-14T09:21:58.7768891Z Task         : Get sources
2019-11-14T09:21:58.7768934Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnTitor
Copy link
Member Author

JohnTitor commented Nov 14, 2019

Ugh, applying suggestion inserted a new line for some reason, fixed.

@Centril
Copy link
Contributor

Centril commented Nov 14, 2019

👍 @bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2019

📌 Commit 9cdd854 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 15, 2019
Add more tests for fixed ICEs

Closes rust-lang#36122 (fixed in 1.20.0)
Closes rust-lang#58094 (fixed in rust-lang#66054)
Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb)

r? @Centril
@JohnTitor
Copy link
Member Author

Failed in #66432 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2019
@Centril
Copy link
Contributor

Centril commented Nov 15, 2019

You'll need to do --bless --compare-mode=nll to fix that error. r=me when done.

@Centril
Copy link
Contributor

Centril commented Nov 15, 2019

Let's give it another go, @bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2019

📌 Commit 614abe4 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 15, 2019
Add more tests for fixed ICEs

Closes rust-lang#36122 (fixed in 1.20.0)
Closes rust-lang#58094 (fixed in rust-lang#66054)
Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb)

r? @Centril
Centril added a commit to Centril/rust that referenced this pull request Nov 15, 2019
Add more tests for fixed ICEs

Closes rust-lang#36122 (fixed in 1.20.0)
Closes rust-lang#58094 (fixed in rust-lang#66054)
Also, fix mistaken test case, from rust-lang#30904 to rust-lang#30906 (cc @eddyb)

r? @Centril
bors added a commit that referenced this pull request Nov 16, 2019
Rollup of 5 pull requests

Successful merges:

 - #66350 (protect creation of destructors by a mutex)
 - #66407 (Add more tests for fixed ICEs)
 - #66415 (Add --force-run-in-process unstable option to libtest)
 - #66427 (Move the JSON error emitter to librustc_errors)
 - #66441 (libpanic_unwind for Miri: make sure we have the SEH lang items when needed)

Failed merges:

r? @ghost
@bors bors merged commit 614abe4 into rust-lang:master Nov 16, 2019
@JohnTitor JohnTitor deleted the add-ice-tests branch November 16, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failed: bpos.to_u32() >= mbc.pos.to_u32() + mbc.bytes as u32' ICE when accessing externed DST
4 participants