Skip to content

Correctly track the source of imports with the same name #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libcore/vec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use old_iter;
use iterator::Iterator;
use kinds::Copy;
use libc;
use old_iter::{BaseIter, CopyableIter};
use old_iter::CopyableIter;
use option::{None, Option, Some};
use ptr::to_unsafe_ptr;
use ptr;
Expand Down
4 changes: 4 additions & 0 deletions src/librustc/middle/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1818,6 +1818,10 @@ pub impl Resolver {
debug!("(building import directive) bumping \
reference");
resolution.outstanding_references += 1;

// the source of this name is different now
resolution.privacy = privacy;
resolution.id = id;
}
None => {
debug!("(building import directive) creating new");
Expand Down
29 changes: 29 additions & 0 deletions src/test/compile-fail/lint-unused-import-tricky-names.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[deny(unused_imports)];

// Regression test for issue #6633

use foo::name::name; //~ ERROR: unused import
use foo::name;

pub mod foo {
pub mod name {
pub type a = int;
pub mod name {
pub type a = float;
}
}
}

fn bar() -> name::a { 1 }

fn main(){}