Skip to content

testsuite: Test for #4780 #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2013
Merged

testsuite: Test for #4780 #6662

merged 1 commit into from
May 21, 2013

Conversation

catamorphism
Copy link
Contributor

No description provided.

@catamorphism catamorphism mentioned this pull request May 21, 2013
Closed
bors added a commit that referenced this pull request May 21, 2013
@bors
auto merge of #6662 : catamorphism/rust/issue-4780, r=catamorphism
02c59bc
@bors bors closed this May 21, 2013
@bors bors merged commit b6cf84f into rust-lang:incoming May 21, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 25, 2021
@bors
Auto merge of rust-lang#6662 - Y-Nak:default-numeric-fallback, r=flip…
e2753f9 
…1995

New lint: default_numeric_fallback

fixes rust-lang#6064
r? `@flip1995`

As we discussed in [here](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Issue.20.236064/near/224647188) and [here](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Issue.20clippy.236064/near/224746333),   I start implementing this lint from the strictest version.
In this PR, I'll allow the below two cases to pass the lint to reduce FPs.

1. Appearances of unsuffixed numeric literals in `Local` if `Local` has a type annotation, for example:
```rust
// Good.
let x: i32 = 1;

// Also good.
let x: (i32, i32) = if cond {
   (1, 2)
} else {
   (2, 3)
};
```

2. Appearances of unsuffixed numeric literals in args of `Call` or `MethodCall`  if corresponding arguments of their signature have concrete types, for example:
```rust
fn foo_mono(x: i32) -> i32 {
    x
}

fn foo_poly<T>(t: T) -> t {
    t
}

// Good.
let x = foo_mono(13);

// Still bad.
let x: i32 = foo_poly(13);
```

changelog: Added restriction lint: `default_numeric_fallback`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catamorphism @bors