Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #6209 #6669

Closed
wants to merge 1 commit into from
Closed

Fix issue #6209 #6669

wants to merge 1 commit into from

Conversation

yjh0502
Copy link
Contributor

@yjh0502 yjh0502 commented May 22, 2013

Fix issue #6209, and some related issues about constant expression

  • unmatched type between arms
  • unmatched type in range

@huonw
Copy link
Member

huonw commented May 22, 2013

There are several instances of match ... { Some(x) if condition => true, Some(_) => false, None => ... }.

Couldn't this be compressed to match ... { Some(x) => condition, None => ... }?

@yjh0502
Copy link
Contributor Author

yjh0502 commented May 22, 2013

@huonw I just fixed the issue.

bors added a commit that referenced this pull request May 23, 2013
@bors
auto merge of #6669 : yjh0502/rust/fix_6209, r=graydon
1d3e84c 
Fix issue #6209, and some related issues about constant expression
 - unmatched type between arms
 - unmatched type in range
@bors bors closed this May 23, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 11, 2021
@bors
Auto merge of rust-lang#6669 - magurotuna:fix-test-name, r=flip1995
876ffa4 
Fix file names of flat_map_identity test

This patch fixes the file names of the `flat_map_identity` test.
Previously, their names were started with `unnecessary_flat_map` even though the lint rule name is `flat_map_identity`. This inconsistency happened probably because the rule name was changed during the discussion in the PR where this rule was introduced.

ref: rust-lang/rust-clippy#4231

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjh0502 @huonw @graydon @bors