Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic machinery comments and tweaks #66766

Merged
merged 8 commits into from
Nov 30, 2019
Merged

Panic machinery comments and tweaks #66766

merged 8 commits into from
Nov 30, 2019

Commits on Nov 25, 2019

  1. Rename continue_panic_fmt to panic_handler, and make it the #[panic_h… 

    …andler] directly

The "continue" in the name was really confusing; it sounds way too much like "resume" which is a totally different concept around panics.
    @RalfJung
    RalfJung committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    cd5d0c7 View commit details
    Browse the repository at this point in the history

  2. better comment and rename BoxMeUp::box_me_up to take_box

    @RalfJung
    RalfJung committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    08f779c View commit details
    Browse the repository at this point in the history

  3. more panicking comments

    @RalfJung
    RalfJung committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    3c48579 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. panic_handler -> begin_panic_handler (and more comments)

    @RalfJung
    RalfJung committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    3a8e1b6 View commit details
    Browse the repository at this point in the history

  2. abort on BoxMeUp misuse

    @RalfJung
    RalfJung committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    3e96ca2 View commit details
    Browse the repository at this point in the history

  3. expand comment

    @RalfJung
    RalfJung committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    61486f4 View commit details
    Browse the repository at this point in the history

  4. explain why __rust_start_panic does not take a Box

    @RalfJung
    RalfJung committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    4a19ef9 View commit details
    Browse the repository at this point in the history

  5. rename update_count_then_panic -> rust_panic_without_hook

    @RalfJung
    RalfJung committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    babe9fc View commit details
    Browse the repository at this point in the history