Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format libstd with rustfmt #66820

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Format libstd with rustfmt #66820

merged 2 commits into from
Nov 30, 2019

Commits on Nov 30, 2019

  1. Format libstd with rustfmt 

    This commit applies rustfmt with rust-lang/rust's default settings to
files in src/libstd *that are not involved in any currently open PR* to
minimize merge conflicts. THe list of files involved in open PRs was
determined by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8

With the list of files from the script in outstanding_files, the
relevant commands were:

    $ find src/libstd -name '*.rs' \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ rg libstd outstanding_files | xargs git checkout --

Repeating this process several months apart should get us coverage of
most of the rest of libstd.

To confirm no funny business:

    $ git checkout $THIS_COMMIT^
    $ git show --pretty= --name-only $THIS_COMMIT \
        | xargs rustfmt --edition=2018 --unstable-features --skip-children
    $ git diff $THIS_COMMIT  # there should be no difference
    @dtolnay
    dtolnay committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    4436c9d View commit details
    Browse the repository at this point in the history

  2. Bless ui test for libstd reformat

    @dtolnay
    dtolnay committed Nov 30, 2019
    Configuration menu
    Copy the full SHA
    9ad0850 View commit details
    Browse the repository at this point in the history