Fix ICE in macros #6686
Closed
Fix ICE in macros #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmr said he'll add a test for this fix in a couple minutes. |
| return lookup_cur_matched_by_matched(r, start); | ||
| match r.interpolations.find_copy(&name) { | ||
| Some(s) => lookup_cur_matched_by_matched(r, s), | ||
| None => r.sp_diag.span_fatal(r.cur_span, "macro variable not found somewhere in this macro") |
There was a problem hiding this comment.
Can you change this to say something along the lines of
unknown macro variable `nonexistent`?
bors
added a commit
that referenced
this pull request
May 22, 2013
The error message is extremely unideal.
This was referenced May 23, 2013
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 11, 2021
lintcheck: support git sources This adds support for git sources in `cargo dev-lintcheck` You can add a git source to `clippy_dev/lintcheck_crates.toml` by having a `git_url` and a `git_hash` key instead of the `versions` array. The repo will the be cloned and checked out to the requested commit before checking it with clippy. Fixes rust-lang/rust-clippy#6642 changelog: lintcheck: support git sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is extremely unideal.