Skip to content

Conversation

RalfJung
Copy link
Member

#66791 made it impossible to access the tcx in the callbacks; this should fix that.

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2019
@RalfJung
Copy link
Member Author

@bors p=1
Needed for toolstate fix

@Zoxc
Copy link
Contributor

Zoxc commented Nov 30, 2019

r=me when CI passes.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 30, 2019

@bors r=Zoxc

@bors
Copy link
Collaborator

bors commented Nov 30, 2019

📌 Commit 7f20198 has been approved by Zoxc

@bors
Copy link
Collaborator

bors commented Nov 30, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 1, 2019
pass Queries to compiler callbacks

rust-lang#66791 made it impossible to access the tcx in the callbacks; this should fix that.

r? @Zoxc
bors added a commit that referenced this pull request Dec 1, 2019
Rollup of 9 pull requests

Successful merges:

 - #66503 (More useful test error messages on should_panic(expected=...) mismatch)
 - #66662 (Miri: run panic-catching tests in liballoc)
 - #66679 (Improve lifetime errors with implicit trait object lifetimes)
 - #66726 (Use recursion_limit for const eval stack limit)
 - #66790 (Do `min_const_fn` checks for `SetDiscriminant`s target)
 - #66832 (const_prop: detect and avoid catching Miri errors that require allocation)
 - #66880 (Add long error code explanation message for E0203)
 - #66890 (Format liballoc with rustfmt)
 - #66896 (pass Queries to compiler callbacks)

Failed merges:

r? @ghost
@bors bors merged commit 7f20198 into rust-lang:master Dec 1, 2019
bors added a commit to rust-lang/miri that referenced this pull request Dec 1, 2019
@RalfJung RalfJung deleted the queries branch December 1, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants