Allocate HIR on an arena 3/4 -- Ty #66942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zoxc
reviewed
Dec 22, 2019
Zoxc
reviewed
Dec 22, 2019
Zoxc
reviewed
Dec 22, 2019
Zoxc
reviewed
Dec 22, 2019
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
hirene-ty
branch
2 times, most recently
from
7246ea5 to
73c260a
Compare
This comment has been minimized.
This comment has been minimized.
|
Rebased with review comments. |
bors
added
the
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 29, 2019
Allocate HIR on an arena 3/4 -- Ty This is the third PR in the series started by #66931 and #66936 Once again, commits don't really make sense on their own. They are mostly split by type of compile error. The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty
|
☀️ Test successful - checks-azure |
This was referenced Dec 30, 2019
|
📣 Toolstate changed by #66942! Tested on commit 2ba0d2a. 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Dec 30, 2019
Tested on commit rust-lang/rust@2ba0d2a. Direct link to PR: <rust-lang/rust#66942> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
This was referenced Dec 30, 2019
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Dec 30, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 30, 2019
Rustup to rust-lang/rust#66942 changelog: none
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Allocate HIR on an arena 4/4 This is the fourth and last PR in the series started by #66931, #66936 and #66942. The last commits should compile on their own. The difference with the previous PR is given by cjgillot/rust@hirene-ty...hirene A few more cleanups may be necessary, please tell me. r? @eddyb like the other cc @Zoxc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR in the series started by #66931 and #66936
Once again, commits don't really make sense on their own.
They are mostly split by type of compile error.
The additional diff is here: cjgillot/rust@hirene-expr...hirene-ty