Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #67284

Merged
merged 36 commits into from
Dec 13, 2019
Merged

Rollup of 7 pull requests #67284

merged 36 commits into from
Dec 13, 2019

Commits on Dec 4, 2019

  1. Clarify handling of exhaustive_patterns in all_constructors

    This is logically equivalent to the previous code.
    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    86fb2ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    063d74f View commit details
    Browse the repository at this point in the history
  3. Add tests

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    922310d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b26aa0b View commit details
    Browse the repository at this point in the history
  5. Tweak error on empty match

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    1bd97ae View commit details
    Browse the repository at this point in the history
  6. Fix erroneous comment

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    1c77a04 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5628d4a View commit details
    Browse the repository at this point in the history
  8. Add tests

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    2099dd1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c0f3c06 View commit details
    Browse the repository at this point in the history
  10. Add tests

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    5a3b7d2 View commit details
    Browse the repository at this point in the history
  11. List missing constructors in an almost empty match

    Actually empty matches are still handled by a different code path
    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    e444346 View commit details
    Browse the repository at this point in the history
  12. Use the default code path to list missing patterns

    This uses the exact same code path that would be used for
    `match x { _ if false => {} }`, since in both cases the resulting matrix
    is empty. Since we think the behaviour in that case is ok, then we can
    remove the special case and use the default code path.
    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    2216318 View commit details
    Browse the repository at this point in the history
  13. Simplify

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    3532835 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d289f55 View commit details
    Browse the repository at this point in the history
  15. Reuse adt_defined_here

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    40f434b View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3e6dc2b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    bfb556f View commit details
    Browse the repository at this point in the history
  18. Only special-case empty matches when exhaustive_patterns is off

    When the feature is on, the special casing is not needed. That way when
    we stabilize the feature this `if` can just be removed.
    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    a591ede View commit details
    Browse the repository at this point in the history
  19. Simplify

    Nadrieril committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    fe5d84d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d44774d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Configuration menu
    Copy the full SHA
    fbd2cd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    189ccf2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    82c09b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    b2392aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ddc027 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    14b2436 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Configuration menu
    Copy the full SHA
    216b9ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f97c37f View commit details
    Browse the repository at this point in the history
  3. docs: std::convert::From: Fix typo

    Fix a minor typo
    shalzz authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    9abde64 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#67026 - Nadrieril:improve-usefulness-empty,…

    … r=varkor,Centril,estebank
    
    Improve diagnostics and code for exhaustiveness of empty matches
    
    There was a completely separate check and diagnostics for the case of an empty match. This led to slightly different error messages and duplicated code.
    This improves code reuse and generally clarifies what happens for empty matches. This also clarifies the action of the `exhaustive_patterns` feature, and ensures that this feature doesn't change diagnostics in places it doesn't need to.
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    df9e491 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#67235 - jonas-schievink:vecdeque-leak, r=Ko…

    …drAus
    
    VecDeque: drop remaining items on destructor panic
    
    Closes rust-lang#67232
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    48164f8 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#67254 - RalfJung:vtable-ice, r=oli-obk

    dont ICE in case of invalid drop fn
    
    Fixes rust-lang/miri#1112
    
    r? @oli-obk
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a0be3a6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#67256 - RalfJung:reduce-allocs, r=oli-obk

    Reduce allocs for validation errors
    
    This probably doesn't really matter, but I just felt like I had to do this...
    
    r? @oli-obk
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    88e702a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#67274 - RalfJung:uninit, r=Centril

    be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init()
    
    Cc @Centril @nikomatsakis
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    83536a5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#67278 - Centril:67273, r=oli-obk

    `coerce_inner`: use initial `expected_ty`
    
    Fixes rust-lang#67273.
    Follow-up to rust-lang#59439.
    
    r? @oli-obk
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    0f30462 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#67280 - shalzz:patch-1, r=jonas-schievink

    docs: std::convert::From: Fix typo
    
    Fix a minor typo
    Centril authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    d0cc289 View commit details
    Browse the repository at this point in the history