Implement split_inclusive for slice and str #67330

golddranks · 2019-12-15T19:26:48Z

Overview

Implement split_inclusive for slice and str and split_inclusive_mut for slice
split_inclusive is a substring/subslice splitting iterator that includes the matched part in the iterated substrings as a terminator.
EDIT: The behaviour has now changed, as per @KodrAus 's input, to the same semantics with the split_terminator function. I updated the examples below.
Two examples below:

    let data = "\nMäry häd ä little lämb\nLittle lämb\n";
    let split: Vec<&str> = data.split_inclusive('\n').collect();
    assert_eq!(split, ["\n", "Märy häd ä little lämb\n", "Little lämb\n"]);

    let uppercase_separated = "SheePSharKTurtlECaT";
    let mut first_char = true;
    let split: Vec<&str> = uppercase_separated.split_inclusive(|c: char| {
        let split = !first_char && c.is_uppercase();
        first_char = split;
        split
    }).collect();
    assert_eq!(split, ["SheeP", "SharK", "TurtlE", "CaT"]);

Justification for the API

I was surprised to find that stdlib currently only has splitting iterators that leave out the matched part. In my experience, wanting to leave a substring terminator as a part of the substring is a pretty common usecase.
This API is strictly more expressive than the standard split API: it's easy to get the behaviour of split by mapping a subslicing operation that drops the terminator. On the other hand it's impossible to derive this behaviour from split without using hacky and brittle unsafe code. The normal way to achieve this functionality would be implementing the iterator yourself.
Especially when dealing with mutable slices, the only way currently is to use split_at_mut. This API provides an ergonomic alternative that plays to the strengths of the iterating capabilities of Rust. (Using split_at_mut iteratively used to be a real pain before NLL, fortunately the situation is a bit better now.)

Discussion items

Does it make sense to mimic split_terminator in that the final empty slice would be left off in case of the string/slice ending with a terminator? It might do, as this use case is naturally geared towards considering the matching part as a terminator instead of a separator.
- EDIT: The behaviour was changed to mimic split_terminator.
Does it make sense to have split_inclusive_mut for &mut str?

rust-highfive · 2019-12-15T19:26:59Z

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-12-15T20:50:25Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-15T19:31:00.6170398Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-15T19:31:00.6358931Z ##[command]git config gc.auto 0
2019-12-15T19:31:00.6432817Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-15T19:31:00.6489859Z ##[command]git config --get-all http.proxy
2019-12-15T19:31:00.6617979Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2019-12-15T20:24:02.2812924Z .................................................................................................... 1600/9380
2019-12-15T20:24:06.0332167Z .................................................................................................... 1700/9380
2019-12-15T20:24:16.6348732Z ...................................................................i................................ 1800/9380
2019-12-15T20:24:22.9234923Z .................................................................................................... 1900/9380
2019-12-15T20:24:36.3144290Z ....................................................iiiii........................................... 2000/9380
2019-12-15T20:24:45.1961993Z .................................................................................................... 2200/9380
2019-12-15T20:24:47.2292627Z .................................................................................................... 2300/9380
2019-12-15T20:24:50.0395419Z .................................................................................................... 2400/9380
2019-12-15T20:25:09.7108095Z .................................................................................................... 2500/9380
---
2019-12-15T20:27:27.8188440Z .............................................................i...............i...................... 4800/9380
2019-12-15T20:27:34.7914922Z .................................................................................................... 4900/9380
2019-12-15T20:27:42.2789650Z .................................................................................................... 5000/9380
2019-12-15T20:27:46.9947270Z .....i.............................................................................................. 5100/9380
2019-12-15T20:27:56.4127138Z .......................................................................ii.ii...........i............ 5200/9380
2019-12-15T20:28:04.1944708Z .......i............................................................................................ 5400/9380
2019-12-15T20:28:13.1442643Z .................................................................................................... 5500/9380
2019-12-15T20:28:19.0067437Z .....................................................i.............................................. 5600/9380
2019-12-15T20:28:25.2768008Z .................................................................................................... 5700/9380
2019-12-15T20:28:25.2768008Z .................................................................................................... 5700/9380
2019-12-15T20:28:34.1860763Z .................................................................................................... 5800/9380
2019-12-15T20:28:40.4725425Z .........................................ii...i..ii...........i..................................... 5900/9380
2019-12-15T20:28:59.9869924Z .................................................................................................... 6100/9380
2019-12-15T20:29:06.8785362Z .................................................................................................... 6200/9380
2019-12-15T20:29:06.8785362Z .................................................................................................... 6200/9380
2019-12-15T20:29:15.7257886Z ..................................................................i..ii............................. 6300/9380
2019-12-15T20:29:40.6389347Z .................................................................................................... 6500/9380
2019-12-15T20:29:42.3975222Z ......................................i............................................................. 6600/9380
2019-12-15T20:29:44.2018610Z .................................................................................................... 6700/9380
2019-12-15T20:29:46.2387787Z ..............................i..................................................................... 6800/9380
---
2019-12-15T20:31:12.6410785Z .................................................................................................... 7400/9380
2019-12-15T20:31:16.8742535Z .................................................................................................... 7500/9380
2019-12-15T20:31:21.7545670Z .................................................................................................... 7600/9380
2019-12-15T20:31:30.1645157Z .................................................................................................... 7700/9380
2019-12-15T20:31:38.0568683Z ...................................................iiii............................................. 7800/9380
2019-12-15T20:31:50.8689730Z .................................................................................................... 8000/9380
2019-12-15T20:31:56.3267975Z .................................................................................................... 8100/9380
2019-12-15T20:32:10.0821740Z .................................................................................................... 8200/9380
2019-12-15T20:32:16.9818930Z .................................................................................................... 8300/9380
---
2019-12-15T20:34:22.5253564Z  finished in 5.553
2019-12-15T20:34:22.5434011Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:34:22.7298944Z 
2019-12-15T20:34:22.7351249Z running 166 tests
2019-12-15T20:34:25.3839606Z iiii......i........ii..iiii...i.............................i..i..................i....i............ 100/166
2019-12-15T20:34:27.2328445Z i.i.i...iii..iiiiiii.......................iii............ii......
2019-12-15T20:34:27.2331980Z 
2019-12-15T20:34:27.2339303Z  finished in 4.690
2019-12-15T20:34:27.2507636Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:34:27.4037691Z 
---
2019-12-15T20:34:29.0971379Z  finished in 1.846
2019-12-15T20:34:29.1137142Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:34:29.2625189Z 
2019-12-15T20:34:29.2628605Z running 9 tests
2019-12-15T20:34:29.2629931Z iiiiiiiii
2019-12-15T20:34:29.2631135Z 
2019-12-15T20:34:29.2631362Z  finished in 0.149
2019-12-15T20:34:29.2791590Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:34:29.4453997Z 
---
2019-12-15T20:34:48.2257043Z  finished in 18.946
2019-12-15T20:34:48.2453568Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:34:48.4124315Z 
2019-12-15T20:34:48.4124482Z running 124 tests
2019-12-15T20:35:09.5455334Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2019-12-15T20:35:13.1908836Z .i.iii.....iiiiii.....ii
2019-12-15T20:35:13.1910681Z 
2019-12-15T20:35:13.1912130Z  finished in 24.945
2019-12-15T20:35:13.1917043Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-15T20:35:13.1917803Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-12-15T20:47:05.5178920Z 
2019-12-15T20:47:05.5184873Z    Doc-tests core
2019-12-15T20:47:09.5680357Z 
2019-12-15T20:47:09.5680750Z running 2441 tests
2019-12-15T20:47:17.4318326Z ......iiiii......................................................................................... 100/2441
2019-12-15T20:47:25.1884366Z ..................................................................................ii................ 200/2441
2019-12-15T20:47:42.9382352Z ................i................................................................................... 400/2441
2019-12-15T20:47:42.9382352Z ................i................................................................................... 400/2441
2019-12-15T20:47:51.0716766Z ................................................................i..i..................iiii.......... 500/2441
2019-12-15T20:48:05.1759184Z .................................................................................................... 700/2441
2019-12-15T20:48:12.6010650Z .................................................................................................... 800/2441
2019-12-15T20:48:20.0285544Z .................................................................................................... 900/2441
2019-12-15T20:48:27.5652569Z .................................................................................................... 1000/2441
---
2019-12-15T20:50:15.9224117Z ................................................i.....F.........................i................... 2400/2441
2019-12-15T20:50:18.9316800Z .........................................
2019-12-15T20:50:18.9316902Z failures:
2019-12-15T20:50:18.9316934Z 
2019-12-15T20:50:18.9320239Z ---- slice/mod.rs - slice::[T]::split_inclusive (line 1174) stdout ----
2019-12-15T20:50:18.9321261Z error[E0658]: use of unstable library feature 'split_inclusive'
2019-12-15T20:50:18.9322848Z   |
2019-12-15T20:50:18.9322848Z   |
2019-12-15T20:50:18.9322892Z 5 | let mut iter = slice.split_inclusive(|num| num % 3 == 0);
2019-12-15T20:50:18.9322995Z   |
2019-12-15T20:50:18.9323036Z   = help: add `#![feature(split_inclusive)]` to the crate attributes to enable
2019-12-15T20:50:18.9323083Z 
2019-12-15T20:50:18.9323120Z error: aborting due to previous error
2019-12-15T20:50:18.9323120Z error: aborting due to previous error
2019-12-15T20:50:18.9323145Z 
2019-12-15T20:50:18.9323503Z For more information about this error, try `rustc --explain E0658`.
2019-12-15T20:50:18.9323712Z Couldn't compile the test.
2019-12-15T20:50:18.9323927Z ---- slice/mod.rs - slice::[T]::split_inclusive (line 1188) stdout ----
2019-12-15T20:50:18.9324151Z error[E0658]: use of unstable library feature 'split_inclusive'
2019-12-15T20:50:18.9324364Z   |
2019-12-15T20:50:18.9324364Z   |
2019-12-15T20:50:18.9324402Z 5 | let mut iter = slice.split_inclusive(|num| num % 3 == 0);
2019-12-15T20:50:18.9324491Z   |
2019-12-15T20:50:18.9324530Z   = help: add `#![feature(split_inclusive)]` to the crate attributes to enable
2019-12-15T20:50:18.9324575Z 
2019-12-15T20:50:18.9324610Z error: aborting due to previous error
2019-12-15T20:50:18.9324610Z error: aborting due to previous error
2019-12-15T20:50:18.9324633Z 
2019-12-15T20:50:18.9324845Z For more information about this error, try `rustc --explain E0658`.
2019-12-15T20:50:18.9325225Z Couldn't compile the test.
2019-12-15T20:50:18.9325650Z ---- slice/mod.rs - slice::[T]::split_inclusive_mut (line 1214) stdout ----
2019-12-15T20:50:18.9326034Z error[E0658]: use of unstable library feature 'split_inclusive'
2019-12-15T20:50:18.9326328Z   |
2019-12-15T20:50:18.9326328Z   |
2019-12-15T20:50:18.9326369Z 6 | for group in v.split_inclusive_mut(|num| *num % 3 == 0) {
2019-12-15T20:50:18.9326461Z   |
2019-12-15T20:50:18.9326503Z   = help: add `#![feature(split_inclusive)]` to the crate attributes to enable
2019-12-15T20:50:18.9326533Z 
2019-12-15T20:50:18.9326586Z error: aborting due to previous error
---
2019-12-15T20:50:18.9327302Z Test executable failed (exit code 101).
2019-12-15T20:50:18.9327424Z 
2019-12-15T20:50:18.9327476Z stderr:
2019-12-15T20:50:18.9327721Z thread 'main' panicked at 'assertion failed: `(left == right)`
2019-12-15T20:50:18.9327769Z   left: `["Mary had a little lamb", "little lamb", "little lamb."]`,
2019-12-15T20:50:18.9328034Z  right: `["Mary had a little lamb\n", "little lamb\n", "little lamb."]`', str/mod.rs:6:1
2019-12-15T20:50:18.9328117Z 
2019-12-15T20:50:18.9328140Z 
2019-12-15T20:50:18.9328161Z 
2019-12-15T20:50:18.9328213Z failures:
---
2019-12-15T20:50:18.9550420Z   local time: Sun Dec 15 20:50:18 UTC 2019
2019-12-15T20:50:19.4985315Z   network time: Sun, 15 Dec 2019 20:50:19 GMT
2019-12-15T20:50:19.4990031Z == end clock drift check ==
2019-12-15T20:50:20.2538540Z 
2019-12-15T20:50:20.2654989Z ##[error]Bash exited with code '1'.
2019-12-15T20:50:20.2704086Z ##[section]Starting: Checkout
2019-12-15T20:50:20.2705654Z ==============================================================================
2019-12-15T20:50:20.2705702Z Task         : Get sources
2019-12-15T20:50:20.2705742Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-12-16T04:52:13Z

r? @SimonSapin

Centril · 2019-12-16T04:52:25Z

cc @bluss @kennytm

rust-highfive · 2019-12-16T07:30:37Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-16T05:40:25.1705533Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-16T05:40:25.1902376Z ##[command]git config gc.auto 0
2019-12-16T05:40:25.1978056Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-16T05:40:25.2044398Z ##[command]git config --get-all http.proxy
2019-12-16T05:40:25.2193272Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2019-12-16T06:39:43.0478468Z .................................................................................................... 1600/9380
2019-12-16T06:39:47.3337694Z .................................................................................................... 1700/9380
2019-12-16T06:39:59.0834040Z ...................................................................i................................ 1800/9380
2019-12-16T06:40:06.2115966Z .................................................................................................... 1900/9380
2019-12-16T06:40:21.2606600Z ....................................................iiiii........................................... 2000/9380
2019-12-16T06:40:31.3755993Z .................................................................................................... 2200/9380
2019-12-16T06:40:33.7429452Z .................................................................................................... 2300/9380
2019-12-16T06:40:36.9525967Z .................................................................................................... 2400/9380
2019-12-16T06:40:59.5396787Z .................................................................................................... 2500/9380
---
2019-12-16T06:43:32.9216429Z .............................................................i...............i...................... 4800/9380
2019-12-16T06:43:40.3097244Z .................................................................................................... 4900/9380
2019-12-16T06:43:48.5538792Z .................................................................................................... 5000/9380
2019-12-16T06:43:53.6058298Z .....i.............................................................................................. 5100/9380
2019-12-16T06:44:03.9458387Z .......................................................................ii.ii...........i............ 5200/9380
2019-12-16T06:44:12.5199702Z .......i............................................................................................ 5400/9380
2019-12-16T06:44:22.4738880Z .................................................................................................... 5500/9380
2019-12-16T06:44:28.8183289Z .....................................................i.............................................. 5600/9380
2019-12-16T06:44:35.6730583Z .................................................................................................... 5700/9380
2019-12-16T06:44:35.6730583Z .................................................................................................... 5700/9380
2019-12-16T06:44:45.5778229Z .................................................................................................... 5800/9380
2019-12-16T06:44:52.4743387Z .........................................ii...i..ii...........i..................................... 5900/9380
2019-12-16T06:45:14.1791790Z .................................................................................................... 6100/9380
2019-12-16T06:45:21.9964185Z .................................................................................................... 6200/9380
2019-12-16T06:45:21.9964185Z .................................................................................................... 6200/9380
2019-12-16T06:45:31.3868595Z ..................................................................i..ii............................. 6300/9380
2019-12-16T06:45:59.4271063Z .................................................................................................... 6500/9380
2019-12-16T06:46:01.6203685Z ......................................i............................................................. 6600/9380
2019-12-16T06:46:03.8373526Z .................................................................................................... 6700/9380
2019-12-16T06:46:06.3124013Z ..............................i..................................................................... 6800/9380
---
2019-12-16T06:47:47.1550528Z .................................................................................................... 7400/9380
2019-12-16T06:47:52.1553857Z .................................................................................................... 7500/9380
2019-12-16T06:47:57.5097500Z .................................................................................................... 7600/9380
2019-12-16T06:48:06.9430215Z .................................................................................................... 7700/9380
2019-12-16T06:48:16.0564108Z ...................................................iiii............................................. 7800/9380
2019-12-16T06:48:31.2490035Z .................................................................................................... 8000/9380
2019-12-16T06:48:37.5815869Z .................................................................................................... 8100/9380
2019-12-16T06:48:53.2288932Z .................................................................................................... 8200/9380
2019-12-16T06:49:01.1433191Z .................................................................................................... 8300/9380
---
2019-12-16T06:51:24.3242942Z  finished in 6.280
2019-12-16T06:51:24.3438976Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:51:24.5381506Z 
2019-12-16T06:51:24.5382459Z running 166 tests
2019-12-16T06:51:27.5896517Z iiii......i........ii..iiii...i.............................i..i..................i....i............ 100/166
2019-12-16T06:51:29.6965090Z i.i.i...iii..iiiiiii.......................iii............ii......
2019-12-16T06:51:29.6969792Z 
2019-12-16T06:51:29.6973756Z  finished in 5.353
2019-12-16T06:51:30.6950997Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:51:30.6955507Z 
---
2019-12-16T06:51:31.9239452Z  finished in 2.206
2019-12-16T06:51:31.9444188Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:51:32.1343854Z 
2019-12-16T06:51:32.1345540Z running 9 tests
2019-12-16T06:51:32.1346413Z iiiiiiiii
2019-12-16T06:51:32.1347150Z 
2019-12-16T06:51:32.1347283Z  finished in 0.189
2019-12-16T06:51:32.1555817Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:51:33.1951971Z 
---
2019-12-16T06:51:51.6011643Z  finished in 19.445
2019-12-16T06:51:51.6237178Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:51:51.8167983Z 
2019-12-16T06:51:51.8168148Z running 124 tests
2019-12-16T06:52:16.8981988Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2019-12-16T06:52:21.1226229Z .i.iii.....iiiiii.....ii
2019-12-16T06:52:21.1228164Z 
2019-12-16T06:52:21.1228419Z  finished in 29.495
2019-12-16T06:52:21.1228860Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-16T06:52:21.1229369Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-12-16T07:05:55.9899916Z 
2019-12-16T07:05:55.9906485Z    Doc-tests core
2019-12-16T07:06:00.5087648Z 
2019-12-16T07:06:00.5088658Z running 2441 tests
2019-12-16T07:06:09.8418635Z ......iiiii......................................................................................... 100/2441
2019-12-16T07:06:19.0416599Z ..................................................................................ii................ 200/2441
2019-12-16T07:06:40.1465756Z ................i................................................................................... 400/2441
2019-12-16T07:06:40.1465756Z ................i................................................................................... 400/2441
2019-12-16T07:06:49.6030685Z ................................................................i..i..................iiii.......... 500/2441
2019-12-16T07:07:06.3088059Z .................................................................................................... 700/2441
2019-12-16T07:07:15.0092256Z .................................................................................................... 800/2441
2019-12-16T07:07:23.6686398Z .................................................................................................... 900/2441
2019-12-16T07:07:32.3927579Z .................................................................................................... 1000/2441
---
2019-12-16T07:11:09.4143586Z ...............................................thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-12-16T07:11:09.4218195Z ....... 300/756
2019-12-16T07:11:09.4856907Z .................................................................................................... 400/756
2019-12-16T07:11:11.5579746Z .................................................................................................... 500/756
2019-12-16T07:11:11.5791834Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.5817226Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.5833918Z thread '<unnamed>' panicked at '.called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5.
2019-12-16T07:11:11.5856287Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.8283930Z ...........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.8296223Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.8303643Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-16T07:11:11.8326421Z .....thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1189:5
2019-12-16T07:11:13.8793633Z ...............thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:627:13
2019-12-16T07:11:13.8801938Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:582:13
2019-12-16T07:11:13.8810632Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:559:13
2019-12-16T07:11:13.8819454Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:687:13
---
2019-12-16T07:11:23.5192397Z 
2019-12-16T07:11:23.5192487Z running 1003 tests
2019-12-16T07:11:41.4527192Z i................................................................................................... 100/1003
2019-12-16T07:11:51.6468257Z .................................................................................................... 200/1003
2019-12-16T07:11:59.0274632Z ..................i.ii.....i......i...i......i...................................................... 300/1003
2019-12-16T07:12:03.9410840Z .................................................................................................... 400/1003
2019-12-16T07:12:10.9027886Z ..........................................i..i.....................................ii............... 500/1003
2019-12-16T07:12:23.8577783Z .................................................................................................... 700/1003
2019-12-16T07:12:23.8577783Z .................................................................................................... 700/1003
2019-12-16T07:12:30.3993222Z .............................iiii................................................................... 800/1003
2019-12-16T07:12:44.5796114Z .................................................................................................... 900/1003
2019-12-16T07:12:51.5728942Z ...................................................iiii............................................. 1000/1003
2019-12-16T07:12:51.6691726Z test result: ok. 983 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2019-12-16T07:12:51.6691769Z 
2019-12-16T07:12:51.6816586Z  finished in 183.039
2019-12-16T07:12:51.6829541Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-12-16T07:30:01.9355839Z     Checking rustc-std-workspace-core v1.99.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-12-16T07:30:02.9415790Z  Documenting alloc v0.0.0 (/checkout/src/liballoc)
2019-12-16T07:30:05.6638981Z     Finished release [optimized] target(s) in 22.51s
2019-12-16T07:30:06.0250753Z  Documenting core v0.0.0 (/checkout/src/libcore)
2019-12-16T07:30:17.4572488Z error: `[split_inclusive_mut]` cannot be resolved, ignoring it.
2019-12-16T07:30:17.4574165Z      |
2019-12-16T07:30:17.4574165Z      |
2019-12-16T07:30:17.4574661Z 3930 | /// This struct is created by the [`split_inclusive_mut`] method on [slices].
2019-12-16T07:30:17.4576530Z      |
2019-12-16T07:30:17.4577048Z note: lint level defined here
2019-12-16T07:30:17.4577510Z     --> src/libcore/lib.rs:64:9
2019-12-16T07:30:17.4577938Z      |
2019-12-16T07:30:17.4577938Z      |
2019-12-16T07:30:17.4578681Z 64   | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2019-12-16T07:30:17.4579727Z      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-12-16T07:30:17.4579924Z 
2019-12-16T07:30:17.4579924Z 
2019-12-16T07:30:17.4597259Z error: `[split_inclusive]` cannot be resolved, ignoring it.
2019-12-16T07:30:17.4599373Z      |
2019-12-16T07:30:17.4599373Z      |
2019-12-16T07:30:17.4599892Z 4330 | /// This struct is created by the [`split_inclusive`] method on [`str`].
2019-12-16T07:30:17.4600639Z      |
2019-12-16T07:30:17.4600976Z      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-12-16T07:30:17.4601016Z 
2019-12-16T07:30:18.3352504Z error: aborting due to 2 previous errors
2019-12-16T07:30:18.3352504Z error: aborting due to 2 previous errors
2019-12-16T07:30:18.3353985Z 
2019-12-16T07:30:18.3354766Z error: Could not document `core`.
2019-12-16T07:30:18.3354953Z 
2019-12-16T07:30:18.3355254Z Caused by:
2019-12-16T07:30:18.3356690Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type lib --crate-name core src/libcore/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/doc --error-format=json --json=diagnostic-rendered-ansi --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.41.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps` (exit code: 1)
2019-12-16T07:30:18.3357140Z 
2019-12-16T07:30:18.3357140Z 
2019-12-16T07:30:18.3358060Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "core" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.41.0" "--index-page" "/checkout/src/doc/index.md"
2019-12-16T07:30:18.3358472Z 
2019-12-16T07:30:18.3358624Z 
2019-12-16T07:30:18.3358781Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-16T07:30:18.3358937Z Build completed unsuccessfully in 1:43:43
2019-12-16T07:30:18.3358937Z Build completed unsuccessfully in 1:43:43
2019-12-16T07:30:18.3359105Z == clock drift check ==
2019-12-16T07:30:18.3359263Z   local time: Mon Dec 16 07:30:17 UTC 2019
2019-12-16T07:30:18.3359415Z   network time: Mon, 16 Dec 2019 07:30:18 GMT
2019-12-16T07:30:18.3360102Z == end clock drift check ==
2019-12-16T07:30:20.9944700Z 
2019-12-16T07:30:21.0049838Z ##[error]Bash exited with code '1'.
2019-12-16T07:30:21.0083707Z ##[section]Starting: Checkout
2019-12-16T07:30:21.0085229Z ==============================================================================
2019-12-16T07:30:21.0085275Z Task         : Get sources
2019-12-16T07:30:21.0085313Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

SimonSapin · 2019-12-16T08:17:25Z

Hi @Centril. If you’d like help specifically from me feel free to mention me. If you believe highfive’s choice of reviewer is not appropriate (maybe that person is away for a couple weeks?) and need to find another reviewer please consider picking from https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json.

r? @sfackler

Dylan-DPC-zz · 2019-12-16T09:59:16Z

r? @KodrAus

SimonSapin · 2019-12-16T10:47:49Z

(Why reassign a third time so soon after the second one?)

Dylan-DPC-zz · 2019-12-16T11:00:28Z

Ah didn't see that you reassigned.

bors · 2020-01-06T12:57:11Z

☔ The latest upstream changes (presumably #67917) made this pull request unmergeable. Please resolve the merge conflicts.

KodrAus · 2020-01-11T11:47:47Z

Does it make sense to mimic split_terminator in that the final empty slice would be left off in case of the string/slice ending with a terminator?

I think this makes sense too, and is how I’d expect this to work.

bors · 2020-01-12T05:41:50Z

☔ The latest upstream changes (presumably #68142) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2020-01-18T23:02:48Z

Ping from triage: @golddranks can you please address the merge conflict?

JohnCSimon · 2020-01-25T06:49:26Z

Pinging again from triage: @golddranks can you please address the merge conflict?

golddranks · 2020-01-25T07:17:40Z

@JohnCSimon Ah, sorry! I'll fix the merge conflict now.

@KodrAus Thanks for the input. I agree. I'll change the behaviour to that and address that in docs.

rust-highfive · 2020-01-25T07:50:57Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T07:31:59.4689436Z ========================== Starting Command Output ===========================
2020-01-25T07:31:59.4691144Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b320d523-0356-4573-8701-85b0434aca3b.sh
2020-01-25T07:31:59.4691179Z 
2020-01-25T07:31:59.4694391Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T07:31:59.4699703Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T07:31:59.4701182Z Task         : Get sources
2020-01-25T07:31:59.4701214Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T07:31:59.4701246Z Version      : 1.0.0
2020-01-25T07:31:59.4701318Z Author       : Microsoft
---
2020-01-25T07:32:00.2087520Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T07:32:00.2181956Z ##[command]git config gc.auto 0
2020-01-25T07:32:00.2236256Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T07:32:00.2288029Z ##[command]git config --get-all http.proxy
2020-01-25T07:32:00.2433159Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T08:52:47Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T08:48:25.3252412Z ========================== Starting Command Output ===========================
2020-01-25T08:48:25.3254226Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/22e2f8ba-5c29-4274-a65d-cc8c7f04dec0.sh
2020-01-25T08:48:25.3254268Z 
2020-01-25T08:48:25.3257510Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T08:48:25.3264997Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T08:48:25.3267052Z Task         : Get sources
2020-01-25T08:48:25.3267089Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T08:48:25.3267127Z Version      : 1.0.0
2020-01-25T08:48:25.3267222Z Author       : Microsoft
---
2020-01-25T08:48:26.3021119Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T08:48:26.3039284Z ##[command]git config gc.auto 0
2020-01-25T08:48:26.3043047Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T08:48:26.3045845Z ##[command]git config --get-all http.proxy
2020-01-25T08:48:26.3080163Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-25T08:52:24.4991968Z Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T08:52:24.5005168Z Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T08:52:24.7679276Z    Compiling cc v1.0.50
2020-01-25T08:52:24.7679664Z     Checking core v0.0.0 (/checkout/src/libcore)
2020-01-25T08:52:24.8875478Z error: expected one of `.`, `?`, `{`, or an operator, found `;`
2020-01-25T08:52:24.8877419Z      |
2020-01-25T08:52:24.8877419Z      |
2020-01-25T08:52:24.8878297Z 3789 |         let idx = match idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T08:52:24.8878810Z      |                   -----                                                   ^ expected one of `.`, `?`, `{`, or an operator
2020-01-25T08:52:24.8879381Z      |                   while parsing this match expression
2020-01-25T08:52:24.8879668Z      |                   help: try removing this `match`
2020-01-25T08:52:24.8879707Z 
2020-01-25T08:52:24.8879707Z 
2020-01-25T08:52:24.8917826Z error: expected one of `.`, `?`, `{`, or an operator, found `;`
2020-01-25T08:52:24.8918499Z      |
2020-01-25T08:52:24.8918499Z      |
2020-01-25T08:52:24.8918863Z 3814 |         let idx = match idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T08:52:24.8919374Z      |                   -----                                                   ^ expected one of `.`, `?`, `{`, or an operator
2020-01-25T08:52:24.8920062Z      |                   while parsing this match expression
2020-01-25T08:52:24.8920430Z      |                   help: try removing this `match`
2020-01-25T08:52:24.8920678Z 
2020-01-25T08:52:24.8920678Z 
2020-01-25T08:52:24.8956874Z error: expected one of `.`, `?`, `{`, or an operator, found `;`
2020-01-25T08:52:24.8957488Z      |
2020-01-25T08:52:24.8957488Z      |
2020-01-25T08:52:24.8957868Z 3978 |         let idx = match idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T08:52:24.8958595Z      |                   -----                                                   ^ expected one of `.`, `?`, `{`, or an operator
2020-01-25T08:52:24.8959304Z      |                   while parsing this match expression
2020-01-25T08:52:24.8959652Z      |                   help: try removing this `match`
2020-01-25T08:52:24.8959720Z 
2020-01-25T08:52:24.8959720Z 
2020-01-25T08:52:24.9036950Z error: expected one of `.`, `?`, `{`, or an operator, found `;`
2020-01-25T08:52:24.9037585Z      |
2020-01-25T08:52:24.9037585Z      |
2020-01-25T08:52:24.9037982Z 4012 |         let idx = match idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T08:52:24.9038472Z      |                   -----                                                   ^ expected one of `.`, `?`, `{`, or an operator
2020-01-25T08:52:24.9039180Z      |                   while parsing this match expression
2020-01-25T08:52:24.9039546Z      |                   help: try removing this `match`
2020-01-25T08:52:24.9039595Z 
2020-01-25T08:52:31.9618002Z    Compiling libc v0.2.66
---
2020-01-25T08:52:34.4959806Z   local time: Sat Jan 25 08:52:34 UTC 2020
2020-01-25T08:52:34.7608517Z   network time: Sat, 25 Jan 2020 08:52:34 GMT
2020-01-25T08:52:34.7609217Z == end clock drift check ==
2020-01-25T08:52:42.4763566Z 
2020-01-25T08:52:42.4891528Z ##[error]Bash exited with code '1'.
2020-01-25T08:52:42.4903515Z ##[section]Finishing: Run build
2020-01-25T08:52:42.4919615Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T08:52:42.4921678Z Task         : Get sources
2020-01-25T08:52:42.4921722Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T08:52:42.4921788Z Version      : 1.0.0
2020-01-25T08:52:42.4921825Z Author       : Microsoft
2020-01-25T08:52:42.4921825Z Author       : Microsoft
2020-01-25T08:52:42.4922044Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T08:52:42.4922114Z ==============================================================================
2020-01-25T08:52:42.8720965Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T08:52:42.8791582Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T08:52:42.8923479Z Cleaning up task key
2020-01-25T08:52:42.8924391Z Start cleaning up orphan processes.
2020-01-25T08:52:42.9086224Z Terminate orphan process: pid (4838) (python)
2020-01-25T08:52:42.9300421Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T09:05:05Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T08:59:47.5238058Z ========================== Starting Command Output ===========================
2020-01-25T08:59:47.5240903Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/ca4e60ee-8a03-4928-99ca-d8efdf4d67d0.sh
2020-01-25T08:59:47.5993712Z 
2020-01-25T08:59:47.6069594Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T08:59:47.6076080Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T08:59:47.6077792Z Task         : Get sources
2020-01-25T08:59:47.6077830Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T08:59:47.6077912Z Version      : 1.0.0
2020-01-25T08:59:47.6077951Z Author       : Microsoft
---
2020-01-25T08:59:51.8107604Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T08:59:51.8443218Z ##[command]git config gc.auto 0
2020-01-25T08:59:51.8501033Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T08:59:51.8561125Z ##[command]git config --get-all http.proxy
2020-01-25T08:59:51.8710913Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-25T09:04:42.5911456Z Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T09:04:42.5931040Z Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T09:04:42.8566674Z    Compiling cc v1.0.50
2020-01-25T09:04:42.8578537Z     Checking core v0.0.0 (/checkout/src/libcore)
2020-01-25T09:04:45.2262259Z error[E0425]: cannot find value `idx_opt` in this scope
2020-01-25T09:04:45.2262907Z      |
2020-01-25T09:04:45.2262907Z      |
2020-01-25T09:04:45.2263250Z 3788 |         let idx = idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T09:04:45.2263700Z 
2020-01-25T09:04:45.2263700Z 
2020-01-25T09:04:45.2378611Z error[E0425]: cannot find value `idx_opt` in this scope
2020-01-25T09:04:45.2379228Z      |
2020-01-25T09:04:45.2379228Z      |
2020-01-25T09:04:45.2379564Z 3813 |         let idx = idx_opt.map(|idx| idx + 1).unwrap_or(self.v.len());
2020-01-25T09:04:45.2379970Z 
2020-01-25T09:04:50.5543880Z    Compiling libc v0.2.66
2020-01-25T09:04:51.4935351Z    Compiling autocfg v0.1.7
2020-01-25T09:04:52.3254944Z error: aborting due to 2 previous errors
---
2020-01-25T09:04:52.8748551Z   local time: Sat Jan 25 09:04:52 UTC 2020
2020-01-25T09:04:53.1596624Z   network time: Sat, 25 Jan 2020 09:04:53 GMT
2020-01-25T09:04:53.1598978Z == end clock drift check ==
2020-01-25T09:05:00.9707985Z 
2020-01-25T09:05:00.9779202Z ##[error]Bash exited with code '1'.
2020-01-25T09:05:00.9792703Z ##[section]Finishing: Run build
2020-01-25T09:05:00.9808586Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T09:05:00.9810457Z Task         : Get sources
2020-01-25T09:05:00.9810513Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T09:05:00.9810583Z Version      : 1.0.0
2020-01-25T09:05:00.9810633Z Author       : Microsoft
2020-01-25T09:05:00.9810633Z Author       : Microsoft
2020-01-25T09:05:00.9810805Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T09:05:00.9810877Z ==============================================================================
2020-01-25T09:05:01.4140718Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T09:05:01.4184244Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T09:05:01.4329556Z Cleaning up task key
2020-01-25T09:05:01.4330542Z Start cleaning up orphan processes.
2020-01-25T09:05:01.4440047Z Terminate orphan process: pid (4385) (python)
2020-01-25T09:05:01.5164415Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

golddranks · 2020-01-25T09:18:08Z

(Sorry for fixing seemingly stupid errors here, the tests/builds take super long to run locally ATM for some reason, so I'm pushing changes "opportunistically".)

rust-highfive · 2020-01-25T09:35:44Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T09:17:19.9015714Z ========================== Starting Command Output ===========================
2020-01-25T09:17:19.9286712Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/97bd428e-4e2d-4ffa-ab15-9308dca4244c.sh
2020-01-25T09:17:19.9286859Z 
2020-01-25T09:17:19.9289439Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T09:17:19.9294149Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T09:17:19.9295500Z Task         : Get sources
2020-01-25T09:17:19.9295529Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T09:17:19.9295594Z Version      : 1.0.0
2020-01-25T09:17:19.9295623Z Author       : Microsoft
---
2020-01-25T09:17:20.6947463Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T09:17:20.7052747Z ##[command]git config gc.auto 0
2020-01-25T09:17:20.7092283Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T09:17:20.7285153Z ##[command]git config --get-all http.proxy
2020-01-25T09:17:20.7292810Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T15:06:17Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T14:48:56.9264782Z ========================== Starting Command Output ===========================
2020-01-25T14:48:56.9266823Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/6dcc6433-73bb-48e8-a8ce-59c7b5721b16.sh
2020-01-25T14:48:56.9267037Z 
2020-01-25T14:48:56.9269920Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T14:48:56.9277300Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T14:48:56.9279113Z Task         : Get sources
2020-01-25T14:48:56.9279150Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T14:48:56.9279237Z Version      : 1.0.0
2020-01-25T14:48:56.9279273Z Author       : Microsoft
---
2020-01-25T14:48:57.9660813Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T14:48:57.9675455Z ##[command]git config gc.auto 0
2020-01-25T14:48:57.9678823Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T14:48:57.9723236Z ##[command]git config --get-all http.proxy
2020-01-25T14:48:57.9798445Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-25T14:54:53.6867558Z tidy error: /checkout/src/libcore/str/mod.rs:1212: undocumented unsafe
2020-01-25T14:54:53.6867899Z tidy error: /checkout/src/libcore/str/mod.rs:1217: undocumented unsafe
2020-01-25T14:54:54.2778191Z thread 'main' panicked at 'assertion failed: `(left != right)`
2020-01-25T14:54:54.2778372Z   left: `0`,
2020-01-25T14:54:54.2778752Z  right: `0`: "none" should be used when there is no issue, not "0"', src/tools/tidy/src/features.rs:417:21
2020-01-25T14:54:54.2778964Z 
2020-01-25T14:54:54.2778998Z 
2020-01-25T14:54:54.2778998Z 
2020-01-25T14:54:54.2779607Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-01-25T14:54:54.2779741Z 
2020-01-25T14:54:54.2779771Z 
2020-01-25T14:54:54.2787657Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-01-25T14:54:54.2787774Z Build completed unsuccessfully in 0:01:33
2020-01-25T14:54:54.2787774Z Build completed unsuccessfully in 0:01:33
2020-01-25T14:54:54.2841067Z == clock drift check ==
2020-01-25T14:54:54.2847922Z   local time: Sat Jan 25 14:54:54 UTC 2020
2020-01-25T14:54:54.5818513Z   network time: Sat, 25 Jan 2020 14:54:54 GMT
2020-01-25T14:54:54.5818624Z == end clock drift check ==
2020-01-25T14:54:55.3337488Z 
2020-01-25T14:54:55.3454773Z ##[error]Bash exited with code '1'.
2020-01-25T14:54:55.3469274Z ##[section]Finishing: Run build
2020-01-25T14:54:55.3485852Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T14:54:55.3488309Z Task         : Get sources
2020-01-25T14:54:55.3488362Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T14:54:55.3488413Z Version      : 1.0.0
2020-01-25T14:54:55.3488475Z Author       : Microsoft
2020-01-25T14:54:55.3488475Z Author       : Microsoft
2020-01-25T14:54:55.3488527Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T14:54:55.3488730Z ==============================================================================
2020-01-25T14:54:55.8142132Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T14:54:55.8187669Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T14:54:55.8312848Z Cleaning up task key
2020-01-25T14:54:55.8313581Z Start cleaning up orphan processes.
2020-01-25T14:54:55.8436100Z Terminate orphan process: pid (3808) (python)
2020-01-25T14:54:55.8665375Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T17:09:05Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T15:56:13.4204751Z ========================== Starting Command Output ===========================
2020-01-25T15:56:13.4206352Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/65c75682-9c75-4c1a-aaff-961968fbd627.sh
2020-01-25T15:56:13.4206385Z 
2020-01-25T15:56:13.4208900Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T15:56:13.4214852Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T15:56:13.4216413Z Task         : Get sources
2020-01-25T15:56:13.4216494Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T15:56:13.4216530Z Version      : 1.0.0
2020-01-25T15:56:13.4216566Z Author       : Microsoft
---
2020-01-25T15:56:17.6036037Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T15:56:17.6526483Z ##[command]git config gc.auto 0
2020-01-25T15:56:17.6604916Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T15:56:17.6655321Z ##[command]git config --get-all http.proxy
2020-01-25T15:56:17.6790743Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-25T16:47:11.4081225Z .................................................................................................... 1700/9552
2020-01-25T16:47:16.8983055Z .................................................................................................... 1800/9552
2020-01-25T16:47:27.7298674Z .......................i............................................................................ 1900/9552
2020-01-25T16:47:34.2370500Z .................................................................................................... 2000/9552
2020-01-25T16:47:47.5815613Z .............iiiii.................................................................................. 2100/9552
2020-01-25T16:47:57.0035132Z .................................................................................................... 2300/9552
2020-01-25T16:47:59.3355651Z .................................................................................................... 2400/9552
2020-01-25T16:48:04.6406337Z .................................................................................................... 2500/9552
2020-01-25T16:48:23.6737263Z .................................................................................................... 2600/9552
---
2020-01-25T16:50:50.2096897Z .................................................................................................... 4800/9552
2020-01-25T16:50:55.0290169Z ..........................................................i...............i......................... 4900/9552
2020-01-25T16:51:02.4867678Z .................................................................................................... 5000/9552
2020-01-25T16:51:09.9423754Z .................................................................................................... 5100/9552
2020-01-25T16:51:14.9772245Z .i.................................................................................................. 5200/9552
2020-01-25T16:51:25.3145815Z .........................................................................ii.ii........i...i......... 5300/9552
2020-01-25T16:51:33.9054287Z ...........i........................................................................................ 5500/9552
2020-01-25T16:51:43.1083444Z .................................................................................................... 5600/9552
2020-01-25T16:51:49.5127145Z ............................................................i....................................... 5700/9552
2020-01-25T16:51:56.4922231Z .................................................................................................... 5800/9552
2020-01-25T16:51:56.4922231Z .................................................................................................... 5800/9552
2020-01-25T16:52:04.5494793Z .................................................................................................... 5900/9552
2020-01-25T16:52:12.4479176Z ...................................................ii...i..i.i..........i........................... 6000/9552
2020-01-25T16:52:33.2561943Z .................................................................................................... 6200/9552
2020-01-25T16:52:40.5431716Z .................................................................................................... 6300/9552
2020-01-25T16:52:40.5431716Z .................................................................................................... 6300/9552
2020-01-25T16:52:45.0039240Z ...............................................................................i..ii................ 6400/9552
2020-01-25T16:53:09.3615322Z .................................................................................................... 6600/9552
2020-01-25T16:53:14.0759563Z .......................................................i............................................ 6700/9552
2020-01-25T16:53:16.2256580Z .................................................................................................... 6800/9552
2020-01-25T16:53:18.3256918Z ......................................................i............................................. 6900/9552
---
2020-01-25T16:54:50.7807225Z .................................................................................................... 7600/9552
2020-01-25T16:54:56.0380288Z .................................................................................................... 7700/9552
2020-01-25T16:55:02.1348757Z .................................................................................................... 7800/9552
2020-01-25T16:55:12.3025229Z .................................................................................................... 7900/9552
2020-01-25T16:55:18.1356626Z ..........iiiiiii................................................................................... 8000/9552
2020-01-25T16:55:31.7312131Z .................................................................................................... 8200/9552
2020-01-25T16:55:42.2825500Z .................................................................................................... 8300/9552
2020-01-25T16:55:54.4364065Z .................................................................................................... 8400/9552
2020-01-25T16:56:00.3145783Z .................................................................................................... 8500/9552
---
2020-01-25T16:58:11.6577459Z  finished in 7.062
2020-01-25T16:58:11.6777342Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:11.8308214Z 
2020-01-25T16:58:11.8308524Z running 169 tests
2020-01-25T16:58:14.6946875Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-25T16:58:16.7692389Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-25T16:58:16.7698072Z 
2020-01-25T16:58:16.7702449Z  finished in 5.092
2020-01-25T16:58:16.7916369Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:16.9317236Z 
---
2020-01-25T16:58:18.8711798Z  finished in 2.081
2020-01-25T16:58:18.8906383Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:19.0409942Z 
2020-01-25T16:58:19.0410435Z running 9 tests
2020-01-25T16:58:19.0411504Z iiiiiiiii
2020-01-25T16:58:19.0412071Z 
2020-01-25T16:58:19.0416211Z  finished in 0.151
2020-01-25T16:58:19.0617903Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:19.2219391Z 
---
2020-01-25T16:58:38.3799081Z  finished in 19.318
2020-01-25T16:58:38.3993084Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:38.5488248Z 
2020-01-25T16:58:38.5489456Z running 116 tests
2020-01-25T16:58:51.0361396Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-25T16:58:52.8238511Z ....iiii.....ii.
2020-01-25T16:58:52.8238965Z 
2020-01-25T16:58:52.8241808Z  finished in 14.425
2020-01-25T16:58:52.8251137Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T16:58:52.8251717Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-25T17:08:59.0469202Z .................................................................................................... 600/618
2020-01-25T17:08:59.0648139Z ..................
2020-01-25T17:08:59.0648959Z failures:
2020-01-25T17:08:59.0649462Z 
2020-01-25T17:08:59.0650639Z ---- slice::test_splitator_inclusive_reverse stdout ----
2020-01-25T17:08:59.0651314Z thread 'slice::test_splitator_inclusive_reverse' panicked at 'assertion failed: `(left == right)`
2020-01-25T17:08:59.0651742Z   left: `[[5], []]`,
2020-01-25T17:08:59.0654586Z  right: `[[5], [3, 4], [1, 2]]`', src/liballoc/../liballoc/tests/slice.rs:879:5
2020-01-25T17:08:59.0660465Z ---- str::test_split_char_iterator_inclusive_rev stdout ----
2020-01-25T17:08:59.0660465Z ---- str::test_split_char_iterator_inclusive_rev stdout ----
2020-01-25T17:08:59.0660932Z thread 'str::test_split_char_iterator_inclusive_rev' panicked at 'assertion failed: `(left == right)`
2020-01-25T17:08:59.0661333Z   left: `["Little lämb", "Märy häd ä little lämb\n", "\n"]`,
2020-01-25T17:08:59.0661791Z  right: `["Little lämb\n", "Märy häd ä little lämb\n", "\n"]`', src/liballoc/../liballoc/tests/str.rs:1274:5
2020-01-25T17:08:59.0662080Z 
2020-01-25T17:08:59.0662249Z failures:
2020-01-25T17:08:59.0662406Z     slice::test_splitator_inclusive_reverse
2020-01-25T17:08:59.0662872Z     str::test_split_char_iterator_inclusive_rev
---
2020-01-25T17:08:59.0809692Z   local time: Sat Jan 25 17:08:59 UTC 2020
2020-01-25T17:08:59.6281720Z   network time: Sat, 25 Jan 2020 17:08:59 GMT
2020-01-25T17:08:59.6283159Z == end clock drift check ==
2020-01-25T17:09:00.0353824Z 
2020-01-25T17:09:00.0485522Z ##[error]Bash exited with code '1'.
2020-01-25T17:09:00.0502936Z ##[section]Finishing: Run build
2020-01-25T17:09:00.0534240Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T17:09:00.0536238Z Task         : Get sources
2020-01-25T17:09:00.0536285Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T17:09:00.0536346Z Version      : 1.0.0
2020-01-25T17:09:00.0536389Z Author       : Microsoft
2020-01-25T17:09:00.0536389Z Author       : Microsoft
2020-01-25T17:09:00.0536435Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T17:09:00.0536514Z ==============================================================================
2020-01-25T17:09:00.4794828Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T17:09:00.4842232Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T17:09:00.4943576Z Cleaning up task key
2020-01-25T17:09:00.4944578Z Start cleaning up orphan processes.
2020-01-25T17:09:00.5041167Z Terminate orphan process: pid (3965) (python)
2020-01-25T17:09:00.5847180Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T17:43:05Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T17:29:57.5905053Z ========================== Starting Command Output ===========================
2020-01-25T17:29:57.5908627Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/042bc763-ad79-4907-b393-0b772a70119a.sh
2020-01-25T17:29:57.5908677Z 
2020-01-25T17:29:57.5912585Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T17:29:57.5919692Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T17:29:57.5921716Z Task         : Get sources
2020-01-25T17:29:57.5921753Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T17:29:57.5921843Z Version      : 1.0.0
2020-01-25T17:29:57.5921880Z Author       : Microsoft
---
2020-01-25T17:29:58.6377899Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T17:29:58.6393026Z ##[command]git config gc.auto 0
2020-01-25T17:29:58.6398857Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T17:29:58.6404454Z ##[command]git config --get-all http.proxy
2020-01-25T17:29:58.6413437Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-25T19:06:46Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-25T17:47:05.0786722Z ========================== Starting Command Output ===========================
2020-01-25T17:47:05.0805571Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/0dcbec26-6aee-4f83-9c84-884bf7ac8829.sh
2020-01-25T17:47:05.1024666Z 
2020-01-25T17:47:05.1120358Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-25T17:47:05.1126494Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T17:47:05.1128193Z Task         : Get sources
2020-01-25T17:47:05.1128231Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T17:47:05.1128269Z Version      : 1.0.0
2020-01-25T17:47:05.1128348Z Author       : Microsoft
---
2020-01-25T17:47:05.9628619Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-25T17:47:05.9718978Z ##[command]git config gc.auto 0
2020-01-25T17:47:05.9805290Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-25T17:47:05.9855005Z ##[command]git config --get-all http.proxy
2020-01-25T17:47:06.0005466Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-25T18:42:19.9173625Z .................................................................................................... 1700/9552
2020-01-25T18:42:25.7941577Z .................................................................................................... 1800/9552
2020-01-25T18:42:37.6122638Z .......................i............................................................................ 1900/9552
2020-01-25T18:42:44.6194496Z .................................................................................................... 2000/9552
2020-01-25T18:42:59.2825785Z .............iiiii.................................................................................. 2100/9552
2020-01-25T18:43:09.0974890Z .................................................................................................... 2300/9552
2020-01-25T18:43:11.5462178Z .................................................................................................... 2400/9552
2020-01-25T18:43:16.7859941Z .................................................................................................... 2500/9552
2020-01-25T18:43:37.3278560Z .................................................................................................... 2600/9552
---
2020-01-25T18:46:12.1269010Z .................................................................................................... 4800/9552
2020-01-25T18:46:17.1528473Z ..........................................................i...............i......................... 4900/9552
2020-01-25T18:46:25.1132119Z .................................................................................................... 5000/9552
2020-01-25T18:46:33.0517805Z .................................................................................................... 5100/9552
2020-01-25T18:46:38.1477595Z .i.................................................................................................. 5200/9552
2020-01-25T18:46:48.7359540Z .........................................................................ii.ii........i...i......... 5300/9552
2020-01-25T18:46:57.2639634Z ...........i........................................................................................ 5500/9552
2020-01-25T18:47:07.2166655Z .................................................................................................... 5600/9552
2020-01-25T18:47:13.6258794Z ............................................................i....................................... 5700/9552
2020-01-25T18:47:20.6955622Z .................................................................................................... 5800/9552
2020-01-25T18:47:20.6955622Z .................................................................................................... 5800/9552
2020-01-25T18:47:28.9701695Z .................................................................................................... 5900/9552
2020-01-25T18:47:37.4276773Z ...................................................ii...i..i.i..........i........................... 6000/9552
2020-01-25T18:47:59.4795594Z .................................................................................................... 6200/9552
2020-01-25T18:48:05.8568435Z .................................................................................................... 6300/9552
2020-01-25T18:48:05.8568435Z .................................................................................................... 6300/9552
2020-01-25T18:48:10.3957593Z ...............................................................................i..ii................ 6400/9552
2020-01-25T18:48:37.1078933Z .................................................................................................... 6600/9552
2020-01-25T18:48:42.1215521Z .......................................................i............................................ 6700/9552
2020-01-25T18:48:44.3081876Z .................................................................................................... 6800/9552
2020-01-25T18:48:46.5638884Z ......................................................i............................................. 6900/9552
---
2020-01-25T18:50:26.9132450Z .................................................................................................... 7600/9552
2020-01-25T18:50:32.5722065Z .................................................................................................... 7700/9552
2020-01-25T18:50:39.0670366Z .................................................................................................... 7800/9552
2020-01-25T18:50:49.6922240Z .................................................................................................... 7900/9552
2020-01-25T18:50:55.8352759Z ..........iiiiiii................................................................................... 8000/9552
2020-01-25T18:51:10.5084928Z .................................................................................................... 8200/9552
2020-01-25T18:51:22.0881323Z .................................................................................................... 8300/9552
2020-01-25T18:51:35.3202759Z .................................................................................................... 8400/9552
2020-01-25T18:51:41.8897095Z .................................................................................................... 8500/9552
---
2020-01-25T18:54:03.9512568Z  finished in 7.481
2020-01-25T18:54:03.9713187Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:04.1833999Z 
2020-01-25T18:54:04.1834462Z running 169 tests
2020-01-25T18:54:07.2255812Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-25T18:54:09.4102399Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-25T18:54:09.4103493Z 
2020-01-25T18:54:09.4108829Z  finished in 5.439
2020-01-25T18:54:09.4317444Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:09.6069729Z 
---
2020-01-25T18:54:11.6441688Z  finished in 2.212
2020-01-25T18:54:11.6642853Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:11.8332466Z 
2020-01-25T18:54:11.8332705Z running 9 tests
2020-01-25T18:54:11.8333492Z iiiiiiiii
2020-01-25T18:54:11.8333904Z 
2020-01-25T18:54:11.8333954Z  finished in 0.168
2020-01-25T18:54:11.8531144Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:12.0577218Z 
---
2020-01-25T18:54:32.0196587Z  finished in 20.166
2020-01-25T18:54:32.0439453Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:32.2563099Z 
2020-01-25T18:54:32.2564231Z running 116 tests
2020-01-25T18:54:45.7315759Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-25T18:54:47.6352616Z ....iiii.....ii.
2020-01-25T18:54:47.6353138Z 
2020-01-25T18:54:47.6353193Z  finished in 15.591
2020-01-25T18:54:47.6357295Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-25T18:54:47.6357685Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-25T19:05:55.3127407Z .................................................................................................... 300/618
2020-01-25T19:05:55.3812300Z .................................................................................................... 400/618
2020-01-25T19:05:55.4229119Z .....F.............................................................................................. 500/618
2020-01-25T19:05:55.5490355Z .................................................................................................... 600/618
2020-01-25T19:06:37.1430019Z .................memory allocation of 17179869184 bytes failederror: test failed, to rerun pass '-p alloc --test collectionstests'
2020-01-25T19:06:37.1459601Z Caused by:
2020-01-25T19:06:37.1459601Z Caused by:
2020-01-25T19:06:37.1460505Z   process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/collectionstests-d541d7078986652f --quiet` (signal: 6, SIGABRT: process abort signal)
2020-01-25T19:06:37.1479086Z 
2020-01-25T19:06:37.1480005Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
2020-01-25T19:06:37.1480119Z expected success, got: exit code: 101
2020-01-25T19:06:37.1480155Z 
---
2020-01-25T19:06:37.5456804Z   local time: Sat Jan 25 19:06:37 UTC 2020
2020-01-25T19:06:38.2685083Z   network time: Sat, 25 Jan 2020 19:06:38 GMT
2020-01-25T19:06:38.2688703Z == end clock drift check ==
2020-01-25T19:06:39.8697053Z 
2020-01-25T19:06:40.1089921Z ##[error]Bash exited with code '1'.
2020-01-25T19:06:40.1382929Z ##[section]Finishing: Run build
2020-01-25T19:06:40.1538504Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T19:06:40.1651391Z Task         : Get sources
2020-01-25T19:06:40.1651521Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-25T19:06:40.1651667Z Version      : 1.0.0
2020-01-25T19:06:40.1651821Z Author       : Microsoft
2020-01-25T19:06:40.1651821Z Author       : Microsoft
2020-01-25T19:06:40.1651947Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-25T19:06:40.1652106Z ==============================================================================
2020-01-25T19:06:40.8033124Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-25T19:06:40.8085172Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-25T19:06:40.8590017Z Cleaning up task key
2020-01-25T19:06:40.8594674Z Start cleaning up orphan processes.
2020-01-25T19:06:40.8915548Z Terminate orphan process: pid (3502) (python)
2020-01-25T19:06:41.0288819Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-26T08:28:58Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-26T07:16:45.1196128Z ========================== Starting Command Output ===========================
2020-01-26T07:16:45.1212561Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/f2010aa5-0913-4f41-9d42-6f61960e6c05.sh
2020-01-26T07:16:45.1474835Z 
2020-01-26T07:16:45.1527718Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-26T07:16:45.1533480Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-26T07:16:45.1535119Z Task         : Get sources
2020-01-26T07:16:45.1535194Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-26T07:16:45.1535229Z Version      : 1.0.0
2020-01-26T07:16:45.1535266Z Author       : Microsoft
---
2020-01-26T07:16:46.4881702Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-26T07:16:46.4972280Z ##[command]git config gc.auto 0
2020-01-26T07:16:46.5443678Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-26T07:16:46.5506446Z ##[command]git config --get-all http.proxy
2020-01-26T07:16:46.5648535Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67330/merge:refs/remotes/pull/67330/merge
---
2020-01-26T08:06:32.8914535Z .................................................................................................... 1700/9556
2020-01-26T08:06:38.2415331Z .................................................................................................... 1800/9556
2020-01-26T08:06:48.4954548Z .......................i............................................................................ 1900/9556
2020-01-26T08:06:54.9070623Z .................................................................................................... 2000/9556
2020-01-26T08:07:07.9822141Z .............iiiii.................................................................................. 2100/9556
2020-01-26T08:07:16.5411699Z .................................................................................................... 2300/9556
2020-01-26T08:07:18.7005339Z .................................................................................................... 2400/9556
2020-01-26T08:07:23.2752322Z .................................................................................................... 2500/9556
2020-01-26T08:07:41.1487080Z .................................................................................................... 2600/9556
---
2020-01-26T08:10:05.1624917Z .................................................................................................... 4800/9556
2020-01-26T08:10:10.2401671Z ..........................................................i...............i......................... 4900/9556
2020-01-26T08:10:17.8233758Z .................................................................................................... 5000/9556
2020-01-26T08:10:25.0046674Z .................................................................................................... 5100/9556
2020-01-26T08:10:29.5453926Z .i.................................................................................................. 5200/9556
2020-01-26T08:10:39.5977181Z ..........................................................................ii.ii........i...i........ 5300/9556
2020-01-26T08:10:47.5263117Z ............i....................................................................................... 5500/9556
2020-01-26T08:10:56.5599485Z .................................................................................................... 5600/9556
2020-01-26T08:11:02.3540401Z .............................................................i...................................... 5700/9556
2020-01-26T08:11:08.9232948Z .................................................................................................... 5800/9556
2020-01-26T08:11:08.9232948Z .................................................................................................... 5800/9556
2020-01-26T08:11:16.2833127Z .................................................................................................... 5900/9556
2020-01-26T08:11:24.2068885Z ....................................................ii...i..ii...........i.......................... 6000/9556
2020-01-26T08:11:44.4073510Z .................................................................................................... 6200/9556
2020-01-26T08:11:48.1063234Z .................................................................................................... 6300/9556
2020-01-26T08:11:48.1063234Z .................................................................................................... 6300/9556
2020-01-26T08:11:52.2083993Z ................................................................................i..ii............... 6400/9556
2020-01-26T08:12:16.0697890Z .................................................................................................... 6600/9556
2020-01-26T08:12:20.9633988Z ........................................................i........................................... 6700/9556
2020-01-26T08:12:22.9441401Z .................................................................................................... 6800/9556
2020-01-26T08:12:24.9678358Z .......................................................i............................................ 6900/9556
---
2020-01-26T08:13:58.7747199Z .................................................................................................... 7600/9556
2020-01-26T08:14:04.0040397Z .................................................................................................... 7700/9556
2020-01-26T08:14:10.3283357Z .................................................................................................... 7800/9556
2020-01-26T08:14:20.7970967Z .................................................................................................... 7900/9556
2020-01-26T08:14:26.7792159Z ...........iiiiiii.................................................................................. 8000/9556
2020-01-26T08:14:40.5313675Z .................................................................................................... 8200/9556
2020-01-26T08:14:50.7195957Z .................................................................................................... 8300/9556
2020-01-26T08:15:03.3729771Z .................................................................................................... 8400/9556
2020-01-26T08:15:09.4876660Z .................................................................................................... 8500/9556
---
2020-01-26T08:17:18.7993023Z  finished in 6.644
2020-01-26T08:17:18.8178914Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:19.0011648Z 
2020-01-26T08:17:19.0012416Z running 169 tests
2020-01-26T08:17:21.7864328Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-26T08:17:23.8099811Z i..ii...iii..iiiiiiiiii.......................iii............ii......
2020-01-26T08:17:23.8100925Z 
2020-01-26T08:17:23.8104902Z  finished in 4.992
2020-01-26T08:17:23.8298445Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:23.9961256Z 
---
2020-01-26T08:17:25.8273361Z  finished in 1.995
2020-01-26T08:17:25.8437511Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:25.9953818Z 
2020-01-26T08:17:25.9954692Z running 9 tests
2020-01-26T08:17:25.9955688Z iiiiiiiii
2020-01-26T08:17:25.9958213Z 
2020-01-26T08:17:25.9960949Z  finished in 0.151
2020-01-26T08:17:26.0149709Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:26.1990782Z 
---
2020-01-26T08:17:44.3740975Z  finished in 18.359
2020-01-26T08:17:44.3976715Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:44.5759419Z 
2020-01-26T08:17:44.5760258Z running 116 tests
2020-01-26T08:17:57.0575358Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-26T08:17:58.7592368Z ....iiii.....ii.
2020-01-26T08:17:58.7592842Z 
2020-01-26T08:17:58.7603673Z  finished in 14.362
2020-01-26T08:17:58.7640739Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-26T08:17:58.7641132Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-26T08:28:09.3321551Z .................................................................................................... 300/618
2020-01-26T08:28:09.4012016Z .................................................................................................... 400/618
2020-01-26T08:28:09.4855213Z .................................................................................................... 500/618
2020-01-26T08:28:09.6146255Z .................................................................................................... 600/618
2020-01-26T08:28:50.4803548Z .................memory allocation of 17179869184 bytes failederror: test failed, to rerun pass '-p alloc --test collectionstests'
2020-01-26T08:28:50.4842371Z Caused by:
2020-01-26T08:28:50.4842371Z Caused by:
2020-01-26T08:28:50.4843238Z   process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/collectionstests-35cbce60c19ae45c --quiet` (signal: 6, SIGABRT: process abort signal)
2020-01-26T08:28:50.4869106Z 
2020-01-26T08:28:50.4874763Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
2020-01-26T08:28:50.4875116Z expected success, got: exit code: 101
2020-01-26T08:28:50.4875309Z 
---
2020-01-26T08:28:51.4190473Z   local time: Sun Jan 26 08:28:50 UTC 2020
2020-01-26T08:28:51.4190529Z   network time: Sun, 26 Jan 2020 08:28:51 GMT
2020-01-26T08:28:51.4190593Z == end clock drift check ==
2020-01-26T08:28:52.7878984Z 
2020-01-26T08:28:52.9943811Z ##[error]Bash exited with code '1'.
2020-01-26T08:28:53.0094065Z ##[section]Finishing: Run build
2020-01-26T08:28:53.0266975Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-26T08:28:53.0328378Z Task         : Get sources
2020-01-26T08:28:53.0328430Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-26T08:28:53.0328494Z Version      : 1.0.0
2020-01-26T08:28:53.0328539Z Author       : Microsoft
2020-01-26T08:28:53.0328539Z Author       : Microsoft
2020-01-26T08:28:53.0328591Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-26T08:28:53.0328660Z ==============================================================================
2020-01-26T08:28:53.6238947Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-26T08:28:53.6306207Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67330/merge to s
2020-01-26T08:28:53.6649346Z Cleaning up task key
2020-01-26T08:28:53.6650491Z Start cleaning up orphan processes.
2020-01-26T08:28:53.6888661Z Terminate orphan process: pid (3510) (python)
2020-01-26T08:28:53.8948308Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

hdhoang · 2020-02-06T06:30:42Z

ping from triage @KodrAus, could you update your review? thanks

KodrAus · 2020-02-07T23:51:31Z

Thanks @golddranks! This looks good to me.

Would you like to squash these commits down and I’ll merge in?

src/liballoc/tests/str.rs

…at includes the matched part in the iterated substrings as a terminator.

…est reverse iteration.

Centril · 2020-02-21T21:31:50Z

👋 @KodrAus

Dylan-DPC-zz · 2020-02-22T01:40:31Z

@bors r=kodraus

bors · 2020-02-22T01:40:32Z

📌 Commit 5c9dc57 has been approved by kodraus

bors · 2020-02-22T03:54:56Z

⌛ Testing commit 5c9dc57 with merge 87e494c...

bors · 2020-02-22T07:26:51Z

☀️ Test successful - checks-azure
Approved by: kodraus
Pushing 87e494c to master...

rust-highfive assigned joshtriplett Dec 15, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2019

rust-highfive assigned SimonSapin and unassigned joshtriplett Dec 16, 2019

rust-highfive assigned sfackler and unassigned SimonSapin Dec 16, 2019

rust-highfive assigned KodrAus and unassigned sfackler Dec 16, 2019

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2020

golddranks force-pushed the split_inclusive branch from 5855eb0 to c493ab3 Compare January 25, 2020 07:31

KodrAus approved these changes Feb 7, 2020

View reviewed changes

src/liballoc/tests/str.rs Show resolved Hide resolved

golddranks added 2 commits February 9, 2020 23:48

Implement split_inclusive for slice and str, an splitting iterator th…

86bf962

…at includes the matched part in the iterated substrings as a terminator.

Don't return empty slice on last iteration with matched terminator. T…

5c9dc57

…est reverse iteration.

golddranks force-pushed the split_inclusive branch from 80784eb to 5c9dc57 Compare February 9, 2020 14:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 22, 2020

bors merged commit 87e494c into rust-lang:master Feb 22, 2020

golddranks deleted the split_inclusive branch February 22, 2020 13:11

This was referenced May 14, 2020

Trim methods on slices rust-lang/rfcs#2547

Open

Tracking Issue for split_inclusive #72360

Closed

martinvonz mentioned this pull request Oct 29, 2021

Make split_inclusive() on an empty slice yield an empty output #89825

Merged

oskgo mentioned this pull request Jan 25, 2024

Provide a split method which doesn't consume the element used to split #53890

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement split_inclusive for slice and str #67330

Implement split_inclusive for slice and str #67330

golddranks commented Dec 15, 2019 •

edited

Loading

rust-highfive commented Dec 15, 2019

rust-highfive commented Dec 15, 2019

Centril commented Dec 16, 2019

Centril commented Dec 16, 2019

rust-highfive commented Dec 16, 2019

SimonSapin commented Dec 16, 2019

Dylan-DPC-zz commented Dec 16, 2019

SimonSapin commented Dec 16, 2019

Dylan-DPC-zz commented Dec 16, 2019

bors commented Jan 6, 2020

KodrAus commented Jan 11, 2020

bors commented Jan 12, 2020

JohnCSimon commented Jan 18, 2020

JohnCSimon commented Jan 25, 2020

golddranks commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

golddranks commented Jan 25, 2020 •

edited

Loading

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 26, 2020

hdhoang commented Feb 6, 2020

KodrAus commented Feb 7, 2020

Centril commented Feb 21, 2020

Dylan-DPC-zz commented Feb 22, 2020

bors commented Feb 22, 2020

bors commented Feb 22, 2020

bors commented Feb 22, 2020

Implement split_inclusive for slice and str #67330

Implement split_inclusive for slice and str #67330

Conversation

golddranks commented Dec 15, 2019 • edited Loading

Overview

Justification for the API

Discussion items

rust-highfive commented Dec 15, 2019

rust-highfive commented Dec 15, 2019

Centril commented Dec 16, 2019

Centril commented Dec 16, 2019

rust-highfive commented Dec 16, 2019

SimonSapin commented Dec 16, 2019

Dylan-DPC-zz commented Dec 16, 2019

SimonSapin commented Dec 16, 2019

Dylan-DPC-zz commented Dec 16, 2019

bors commented Jan 6, 2020

KodrAus commented Jan 11, 2020

bors commented Jan 12, 2020

JohnCSimon commented Jan 18, 2020

JohnCSimon commented Jan 25, 2020

golddranks commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

golddranks commented Jan 25, 2020 • edited Loading

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 25, 2020

rust-highfive commented Jan 26, 2020

hdhoang commented Feb 6, 2020

KodrAus commented Feb 7, 2020

Centril commented Feb 21, 2020

Dylan-DPC-zz commented Feb 22, 2020

bors commented Feb 22, 2020

bors commented Feb 22, 2020

bors commented Feb 22, 2020

golddranks commented Dec 15, 2019 •

edited

Loading

golddranks commented Jan 25, 2020 •

edited

Loading