Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update miri #67579

Merged
merged 2 commits into from
Dec 24, 2019
Merged

update miri #67579

merged 2 commits into from
Dec 24, 2019

Conversation

RalfJung
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2019
@RalfJung
Copy link
Member Author

(Almost) submodule-only, toolstate fix Cc @oli-obk
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 24, 2019

📌 Commit 04c740b has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Dec 24, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2019
@RalfJung
Copy link
Member Author

Looks like no job is running anyway, so...
@bors p=100

aidanhs added a commit to aidanhs/rust that referenced this pull request Dec 24, 2019
@aidanhs
Rollup merge of rust-lang#67579 - RalfJung:miri, r=RalfJung
ac9b4d4 
update miri
@aidanhs aidanhs mentioned this pull request Dec 24, 2019
Closed
@bors
Copy link
Contributor

bors commented Dec 24, 2019

⌛ Testing commit 04c740b with merge 918823fc25bf957286657d1839faf3cf034bb780...

@RalfJung
Copy link
Member Author

Oh lol, @aidanhs and me literally raced on this. ;)
Yielding to rollup.
@bors retry

@rust-highfive

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 24, 2019

⌛ Testing commit 04c740b with merge 84d8f9d...

bors added a commit that referenced this pull request Dec 24, 2019
@bors
Auto merge of #67579 - RalfJung:miri, r=RalfJung
84d8f9d 
update miri
@aidanhs
Copy link
Member

aidanhs commented Dec 24, 2019

Eh, rollup failed, let's leave this to run.

@bors
Copy link
Contributor

bors commented Dec 24, 2019

☀️ Test successful - checks-azure
Approved by: RalfJung
Pushing 84d8f9d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2019
@bors bors merged commit 04c740b into rust-lang:master Dec 24, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #67579!

Tested on commit 84d8f9d.
Direct link to PR: #67579

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Dec 24, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#67579!
1f8dea3 
Tested on commit rust-lang/rust@84d8f9d.
Direct link to PR: <rust-lang/rust#67579>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
@RalfJung RalfJung mentioned this pull request Dec 24, 2019
Closed
@SimonSapin SimonSapin mentioned this pull request Dec 25, 2019
Closed
@RalfJung RalfJung deleted the miri branch December 26, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @bors @aidanhs @alexcrichton