Resolve long compile times when evaluating always valid constants #67667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Dec 27, 2019
wesleywiser
force-pushed
the
speed_up_trivially_valid_constants
branch
from
8a45951
to
dce8826
Compare
|
Force pushed |
wesleywiser
force-pushed
the
speed_up_trivially_valid_constants
branch
from
dce8826
to
19834f3
Compare
tesuji
reviewed
Dec 28, 2019
spastorino
approved these changes
Dec 28, 2019
RalfJung
reviewed
Dec 28, 2019
RalfJung
reviewed
Dec 28, 2019
wesleywiser
force-pushed
the
speed_up_trivially_valid_constants
branch
from
19834f3
to
31e1c41
Compare
|
Force pushed. We're back to the original version with an added |
oli-obk
reviewed
Dec 29, 2019
| const FOO: [Empty; 3] = [foo(); 3]; | ||
|
|
||
| #[warn(const_err)] | ||
| const BAR: [Empty; 3] = [unsafe { std::mem::transmute(()) }; 3]; |
There was a problem hiding this comment.
side note: if you remove this constant and its use, you do get a hard error on the use of FOO, but BAR is what we are actually interested in testing here, because it causes validation to error instead of const eval.
|
@bors r+ |
|
📌 Commit 31e1c41 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 29, 2019
…d_constants, r=oli-obk Resolve long compile times when evaluating always valid constants This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes rust-lang#67539 r? @oli-obk cc @RalfJung @spastorino
|
Seems failed in #67704 (comment) |
bors
added
S-waiting-on-author
This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes rust-lang#67539
wesleywiser
force-pushed
the
speed_up_trivially_valid_constants
branch
from
31e1c41
to
5ca3a1b
Compare
|
Ignored 32-bit platforms in the @bors r=oli-obk |
|
📌 Commit 5ca3a1b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 30, 2019
…, r=oli-obk Resolve long compile times when evaluating always valid constants This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes #67539 r? @oli-obk cc @RalfJung @spastorino
|
☀️ Test successful - checks-azure |
Mark-Simulacrum
added
the
stable-nominated
|
Stable nominating per #68873. |
Mark-Simulacrum
added
the
T-compiler
|
discussed at T-compiler meeting. stable-accepted. |
pnkfelix
added
the
stable-accepted
Mark-Simulacrum
removed
the
stable-nominated
bors
added a commit
that referenced
this pull request
Feb 22, 2020
[stable] 1.41.1 release This backports the following PRs: * Revert "Remove `checked_add` in `Layout::repeat`" #69241 * Do not ICE when encountering `yield` inside `async` block #69175 * Correct ICE caused by macros generating invalid spans. #68611 * Changelog: Demonstrate final build-override syntax #68603 * Resolve long compile times when evaluating always valid constants #67667 * Fix MIR typeck soundness holes #69145 This also includes a commit which rustfmt's files which the latter commits touched (and perhaps a bit more) to make rebasing the PRs go more smoothly (thankfully, this should be the last time we need to do so). I have removed stable-nominated tags from PRs successfully backported.
bors
added a commit
that referenced
this pull request
Feb 24, 2020
[stable] 1.41.1 release This backports the following PRs: * Revert "Remove `checked_add` in `Layout::repeat`" #69241 * Do not ICE when encountering `yield` inside `async` block #69175 * Correct ICE caused by macros generating invalid spans. #68611 * Changelog: Demonstrate final build-override syntax #68603 * Resolve long compile times when evaluating always valid constants #67667 * Fix MIR typeck soundness holes #69145 This also includes a commit which rustfmt's files which the latter commits touched (and perhaps a bit more) to make rebasing the PRs go more smoothly (thankfully, this should be the last time we need to do so). I have removed stable-nominated tags from PRs successfully backported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the existing logic which skips validating every integer or
floating point number type to also skip validating empty structs because
they are also trivially valid.
Fixes #67539
r? @oli-obk
cc @RalfJung @spastorino