Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #67726

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Update Clippy #67726

merged 1 commit into from
Jan 1, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #67716
r? @oli-obk

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Dec 30, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 30, 2019

📌 Commit b746ee10fbfeac563b97e9d8f951155e11c71197 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2019
@bors
Copy link
Contributor

bors commented Dec 30, 2019

⌛ Testing commit b746ee10fbfeac563b97e9d8f951155e11c71197 with merge 50e5663c4a93080af06dec80e2e3ce3ab3caf94a...

@JohnTitor
Copy link
Member Author

Needs more rustup
@bor r- retry

@JohnTitor
Copy link
Member Author

Oops, sorry for mistake!
@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-12-30T23:06:51.3987249Z    Compiling rustbook v0.1.0 (/checkout/src/tools/rustbook)
2019-12-30T23:06:56.6536720Z [RUSTC-TIMING] rustbook test:false 5.243
2019-12-30T23:06:56.6564947Z     Finished release [optimized] target(s) in 10m 13s
2019-12-30T23:06:56.6817986Z [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "rustbook", path: "src/tools/rustbook", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: ["linkcheck"] } -- 613.460
2019-12-30T23:08:32.6026487Z error: The server responded with 404 Not Found for "https://github.com/rust-lang/rust/tree/master/src/libsyntax_expand/mbe"
2019-12-30T23:08:32.6027807Z     ┌── macro-expansion.md:13:1 ───
2019-12-30T23:08:32.6028448Z     │
2019-12-30T23:08:32.6028448Z     │
2019-12-30T23:08:32.6028980Z  13 │ [`src/libsyntax_expand/mbe/`][code_dir]. This chapter aims to explain how macro
2019-12-30T23:08:32.6048779Z     │
2019-12-30T23:08:32.6049135Z 
2019-12-30T23:08:32.6050136Z error: The server responded with 404 Not Found for "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/borrow_check/nll/type_check/index.html"
2019-12-30T23:08:32.6050533Z 
---
2019-12-30T23:43:05.4316540Z Verifying status of rustfmt...
2019-12-30T23:43:05.4316777Z Verifying status of clippy-driver...
2019-12-30T23:43:05.4317043Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-12-30T23:43:05.4317113Z 
2019-12-30T23:43:05.4317365Z We detected that this PR updated 'clippy-driver', but its tests failed.
2019-12-30T23:43:05.4317415Z 
2019-12-30T23:43:05.4317690Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-12-30T23:43:05.4317784Z commit another update.
2019-12-30T23:43:05.4317821Z 
2019-12-30T23:43:05.4319693Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-12-30T23:43:05.4320357Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-12-30T23:43:05.4320460Z proper steps.
2019-12-30T23:43:05.4321164Z Build completed unsuccessfully in 0:00:01
2019-12-30T23:43:05.4377163Z == clock drift check ==
2019-12-30T23:43:05.4391707Z   local time: Mon Dec 30 23:43:05 UTC 2019
2019-12-30T23:43:05.7121687Z   network time: Mon, 30 Dec 2019 23:43:05 GMT
2019-12-30T23:43:05.7121687Z   network time: Mon, 30 Dec 2019 23:43:05 GMT
2019-12-30T23:43:05.7121997Z == end clock drift check ==
2019-12-30T23:43:06.1820813Z 
2019-12-30T23:43:06.1920659Z ##[error]Bash exited with code '1'.
2019-12-30T23:43:06.1956270Z ##[section]Starting: Checkout
2019-12-30T23:43:06.1957850Z ==============================================================================
2019-12-30T23:43:06.1957937Z Task         : Get sources
2019-12-30T23:43:06.1958179Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 31, 2019
@JohnTitor
Copy link
Member Author

latest rustup is included
@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 31, 2019

📌 Commit b5f340c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2019
@bors
Copy link
Contributor

bors commented Dec 31, 2019

⌛ Testing commit b5f340c with merge 38aa6bd...

bors added a commit that referenced this pull request Dec 31, 2019
@bors
Auto merge of #67726 - JohnTitor:clippy-up, r=oli-obk
38aa6bd 
Update Clippy

Fixes #67716
r? @oli-obk
@bors
Copy link
Contributor

bors commented Jan 1, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 38aa6bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2020
@bors bors merged commit b5f340c into rust-lang:master Jan 1, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #67726!

Tested on commit 38aa6bd.
Direct link to PR: #67726

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 1, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#67726!
7ff7610 
Tested on commit rust-lang/rust@38aa6bd.
Direct link to PR: <rust-lang/rust#67726>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@JohnTitor JohnTitor deleted the clippy-up branch January 1, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#66942
4 participants
@JohnTitor @rust-highfive @oli-obk @bors