Skip to content

rustc: Switch ty::node_type_table to smallintmap, cut 400mb memory use off a librustc build. #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

graydon
Copy link
Contributor

@graydon graydon commented May 28, 2013

Smallintmap was being populated with sparse keys during ast deserialization.

…e off a librustc build.

Smallintmap was being populated with sparse keys during ast deserialization.
@alexcrichton
Copy link
Member

Out of curiosity, do you know if this hits perf at all? That was the only thing stopping me from doing this when I saw it.

Also, yay!

@graydon
Copy link
Contributor Author

graydon commented May 28, 2013

The measurements I took show it running slightly faster. Though they were not the most precise, might conflate factors.

bors added a commit that referenced this pull request May 28, 2013
Smallintmap was being populated with sparse keys during ast deserialization.
@bors bors closed this May 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants