-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #65244 for performance reasons #67768
Conversation
This reverts commit f35517e.
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
r? @ghost @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 717702d with merge 5671b03c0b64dbbec704a3846ddc7966a6a7eb59... |
☀️ Try build successful - checks-azure |
Queued 5671b03c0b64dbbec704a3846ddc7966a6a7eb59 with parent 119307a, future comparison URL. |
Finished benchmarking try commit 5671b03c0b64dbbec704a3846ddc7966a6a7eb59, comparison URL. |
Per compiler team triage meeting (see #67706 (comment)), I'm reopening this for merging. |
@bors r+ p=1 rollup=never Approving this per compiler team decision and prioritizing as a regression fix. Also marking as no-rollup since we want to avoid the fixes here masking some other regression. |
📌 Commit 717702d has been approved by |
☀️ Test successful - checks-azure |
This reverts commit f35517e.
Revert #65244 so we can see if it is the cause of the performance issue in #67706
cc #67644