Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move early and late lint mechanisms to librustc_lint. #67788

Merged
merged 3 commits into from
Jan 4, 2020

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jan 1, 2020

As requested, split from #67737

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2020
@Zoxc
Copy link
Contributor

Zoxc commented Jan 2, 2020

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Jan 2, 2020

📌 Commit 1fab03e has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2020
@bors
Copy link
Contributor

bors commented Jan 2, 2020

⌛ Testing commit 1fab03e with merge fa7756b3d399236530c5fd5a64bb659f68e10a02...

@rust-highfive
Copy link
Collaborator

The job i686-mingw-1 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-02T16:41:46.9609177Z do so (now or later) by using -b with the checkout command again. Example:
2020-01-02T16:41:46.9609229Z 
2020-01-02T16:41:46.9609304Z   git checkout -b <new-branch-name>
2020-01-02T16:41:46.9609349Z 
2020-01-02T16:41:46.9609421Z HEAD is now at fa7756b3d Auto merge of #67788 - cjgillot:delint-day, r=Zoxc
2020-01-02T16:41:47.0009969Z ##[section]Starting: Setup environment
2020-01-02T16:41:47.0126798Z ==============================================================================
2020-01-02T16:41:47.0126895Z Task         : Bash
2020-01-02T16:41:47.0127129Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2020-01-02T18:39:19.1010235Z 
2020-01-02T18:39:19.1011012Z 
2020-01-02T18:39:19.1450941Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test --exclude src/test/ui --exclude src/test/compile-fail
2020-01-02T18:39:19.1451604Z Build completed unsuccessfully in 1:47:18
2020-01-02T18:39:19.2060610Z make: *** [Makefile:89: ci-mingw-subset-1] Error 1
2020-01-02T18:39:19.2663715Z   local time: Thu Jan  2 18:39:19 CUT 2020
2020-01-02T18:39:19.7935403Z   network time: Thu, 02 Jan 2020 18:39:19 GMT
2020-01-02T18:39:19.7936437Z == end clock drift check ==
2020-01-02T18:39:19.8841323Z 
2020-01-02T18:39:19.8841323Z 
2020-01-02T18:39:20.2670901Z ##[error]Bash exited with code '2'.
2020-01-02T18:39:20.3219761Z ##[section]Starting: Checkout
2020-01-02T18:39:20.3925852Z ==============================================================================
2020-01-02T18:39:20.3925952Z Task         : Get sources
2020-01-02T18:39:20.3926061Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jan 2, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 2, 2020
@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 2, 2020

2020-01-02T18:39:17.9700216Z �[0m�[0m�[1m�[31merror�[0m�[1m:�[0m failed to remove file D:\a\1\s\build\i686-pc-windows-gnu\stage1-std\i686-pc-windows-gnu\release\deps\libcompiler_builtins-aef45fd8d1060459.rlib
2020-01-02T18:39:17.9701438Z
2020-01-02T18:39:17.9701978Z Caused by:
2020-01-02T18:39:17.9702212Z Access is denied. (os error 5)

Seems spurious.

@Zoxc
Copy link
Contributor

Zoxc commented Jan 3, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2020
@bors
Copy link
Contributor

bors commented Jan 3, 2020

⌛ Testing commit 1fab03e with merge b95ffc723a2b6b3f0b30378788306a6dd41bd66f...

@rust-highfive
Copy link
Collaborator

The job dist-x86_64-linux-alt of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jan 3, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2020
@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 3, 2020

2020-01-03T02:59:10.6687488Z error: failed to download from https://crates.io/api/v1/crates/foreign-types-shared/0.1.1/download
2020-01-03T02:59:10.6688750Z
2020-01-03T02:59:10.6689776Z Caused by:
2020-01-03T02:59:10.6690882Z failed to get 200 response from https://crates.io/api/v1/crates/foreign-types-shared/0.1.1/download, got 500

Spurious again.

@Zoxc
Copy link
Contributor

Zoxc commented Jan 3, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2020
@bors
Copy link
Contributor

bors commented Jan 3, 2020

⌛ Testing commit 1fab03e with merge 211c6ccbe4e6e2d8189cc1e3ea50614d8ec68e7a...

@rust-highfive
Copy link
Collaborator

The job x86_64-msvc-1 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-03T17:46:52.8586999Z command did not execute successfully: "D:\\a\\1\\s\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "test" "-Zconfig-profile" "--target" "x86_64-pc-windows-msvc" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace profiler compiler-builtins-c" "--manifest-path" "D:\\a\\1\\s\\src/libtest/Cargo.toml" "-p" "test" "--"
2020-01-03T17:46:52.8587213Z expected success, got: exit code: 101
2020-01-03T17:46:52.8587258Z 
2020-01-03T17:46:52.8587320Z 
2020-01-03T17:46:52.9880543Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test --exclude src/test/ui --exclude src/test/compile-fail --exclude src/tools/linkchecker
2020-01-03T17:46:52.9880863Z Build completed unsuccessfully in 2:01:26
2020-01-03T17:46:53.0801610Z make: *** [Makefile:80: ci-subset-1] Error 1
2020-01-03T17:46:53.1430849Z   local time: Fri Jan  3 17:46:53 CUT 2020
2020-01-03T17:46:53.5485017Z   network time: Fri, 03 Jan 2020 17:46:53 GMT
2020-01-03T17:46:53.5510578Z == end clock drift check ==
2020-01-03T17:46:53.6701702Z 
2020-01-03T17:46:53.6701702Z 
2020-01-03T17:46:54.0110802Z ##[error]Bash exited with code '2'.
2020-01-03T17:46:54.0626949Z ##[section]Starting: Checkout
2020-01-03T17:46:54.1446024Z ==============================================================================
2020-01-03T17:46:54.1446156Z Task         : Get sources
2020-01-03T17:46:54.1446241Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jan 3, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2020
@Zoxc
Copy link
Contributor

Zoxc commented Jan 4, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2020
@bors
Copy link
Contributor

bors commented Jan 4, 2020

⌛ Testing commit 1fab03e with merge 79cf5e4...

bors added a commit that referenced this pull request Jan 4, 2020
Move early and late lint mechanisms to librustc_lint.

As requested, split from #67737

r? @Zoxc
@bors
Copy link
Contributor

bors commented Jan 4, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 79cf5e4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2020
@bors bors merged commit 1fab03e into rust-lang:master Jan 4, 2020
@cjgillot cjgillot deleted the delint-day branch January 4, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants