Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused #[link_name = "m"] attributes #67848

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Remove unused #[link_name = "m"] attributes #67848

merged 1 commit into from
Jan 4, 2020

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Jan 3, 2020

These were perhaps supposed to be #[link(name = "m")] but linking libm should be handled by the libc crate anyway.

They should have triggered a compile error: #47725

@ollie27
Remove unused #[link_name = "m"] attributes
83333fe 
These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2020

📌 Commit 83333fe has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2020
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 4, 2020
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2020
@GuillaumeGomez
Rollup merge of rust-lang#67848 - ollie27:float_link_name_attr, r=Dyl…
a86a189 
…an-DPC

Remove unused `#[link_name = "m"]` attributes

These were perhaps supposed to be `#[link(name = "m")]` but linking libm should be handled by the libc crate anyway.

They should have triggered a compile error: rust-lang#47725
bors added a commit that referenced this pull request Jan 4, 2020
@bors
Auto merge of #67866 - GuillaumeGomez:rollup-32vsg5b, r=GuillaumeGomez
cd8377d 
Rollup of 4 pull requests

Successful merges:

 - #67822 (Revert `const_err` lint checking of casts)
 - #67823 (improve some `Drop`-related error messages)
 - #67837 (Clean up err codes)
 - #67848 (Remove unused `#[link_name = "m"]` attributes)

Failed merges:

r? @ghost
@bors bors merged commit 83333fe into rust-lang:master Jan 4, 2020
@ollie27 ollie27 deleted the float_link_name_attr branch January 4, 2020 18:36
@Alexendoo Alexendoo mentioned this pull request Jan 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ollie27 @rust-highfive @Dylan-DPC-zz @bors @nikomatsakis