-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly check for opaque types in assoc_ty_def
#67867
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/test/ui/type-alias-impl-trait/incoherent-assoc-imp-trait.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Regression test for issue 67856 | ||
|
||
#![feature(unboxed_closures)] | ||
#![feature(type_alias_impl_trait)] | ||
#![feature(fn_traits)] | ||
|
||
trait MyTrait {} | ||
impl MyTrait for () {} | ||
|
||
impl<F> FnOnce<()> for &F { | ||
//~^ ERROR conflicting implementations | ||
//~| ERROR type parameter `F` must be used | ||
type Output = impl MyTrait; | ||
extern "rust-call" fn call_once(self, _: ()) -> Self::Output {} | ||
} | ||
fn main() {} |
23 changes: 23 additions & 0 deletions
23
src/test/ui/type-alias-impl-trait/incoherent-assoc-imp-trait.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
error[E0119]: conflicting implementations of trait `std::ops::FnOnce<()>` for type `&_`: | ||
--> $DIR/incoherent-assoc-imp-trait.rs:10:1 | ||
| | ||
LL | impl<F> FnOnce<()> for &F { | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
= note: conflicting implementation in crate `core`: | ||
- impl<A, F> std::ops::FnOnce<A> for &F | ||
where F: std::ops::Fn<A>, F: ?Sized; | ||
|
||
error[E0210]: type parameter `F` must be used as the type parameter for some local type (e.g., `MyStruct<F>`) | ||
--> $DIR/incoherent-assoc-imp-trait.rs:10:6 | ||
| | ||
LL | impl<F> FnOnce<()> for &F { | ||
| ^ type parameter `F` must be used as the type parameter for some local type | ||
| | ||
= note: implementing a foreign trait is only possible if at least one of the types for which is it implemented is local | ||
= note: only traits defined in the current crate can be implemented for a type parameter | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
Some errors have detailed explanations: E0119, E0210. | ||
For more information about an error, try `rustc --explain E0119`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks correct to me, but now I'm wondering if the bug! below is reachable for opaque types if the impl is missing the associated opaque type item