Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #67895

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Update Clippy #67895

merged 1 commit into from
Jan 5, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #67859

r? @oli-obk

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 5, 2020

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jan 5, 2020

📌 Commit 88ef686 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 5, 2020

For miri we self-r+ submodule update PRs, imo that's OK for clippy, too

@JohnTitor
Copy link
Member Author

For miri we self-r+ submodule update PRs, imo that's OK for clippy, too

Got it, I'll do that next time!

@bors
Copy link
Collaborator

bors commented Jan 5, 2020

⌛ Testing commit 88ef686 with merge b69f6e6...

bors added a commit that referenced this pull request Jan 5, 2020
@bors
Auto merge of #67895 - JohnTitor:clippy-up, r=oli-obk
b69f6e6 
Update Clippy

Fixes #67859

r? @oli-obk
@bors
Copy link
Collaborator

bors commented Jan 5, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing b69f6e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2020
@bors bors merged commit 88ef686 into rust-lang:master Jan 5, 2020
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #67895!

Tested on commit b69f6e6.
Direct link to PR: #67895

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 5, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#67895!
654abdc 
Tested on commit rust-lang/rust@b69f6e6.
Direct link to PR: <rust-lang/rust#67895>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@JohnTitor JohnTitor deleted the clippy-up branch January 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#67853
4 participants
@JohnTitor @rust-highfive @oli-obk @bors