Improve hygiene of newtype_index
#67898
Merged
+80
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
matthewjasper
force-pushed
the
newtype-index-hygiene
branch
from
443131b to
dcbbdd1
Compare
|
@bors r+ |
|
📌 Commit dcbbdd1ba5d05e946c2174375541dddb58349018 has been approved by |
bors
added
S-waiting-on-bors
Centril
reviewed
Jan 5, 2020
|
@bors r- ^--- to confirm there's no accidental change here. |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Also add unit tests
matthewjasper
force-pushed
the
newtype-index-hygiene
branch
from
dcbbdd1 to
9462c8b
Compare
|
I've fixed the issue and added some unit tests for |
|
@bors r+ |
|
📌 Commit 9462c8b has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 7, 2020
…, r=Centril Improve hygiene of `newtype_index` `newtype_index` no longer needs `rustc_index::vec::Idx` to be in scope. r? @Centril
bors
added a commit
that referenced
this pull request
Jan 7, 2020
Rollup of 13 pull requests Successful merges: - #67566 (Add an unstable conversion from thread ID to u64) - #67671 (Account for `type X = impl Trait;` in lifetime suggestion) - #67727 (Stabilise vec::remove_item) - #67877 (Omit underscore constants from rustdoc) - #67880 (Handle multiple error fix suggestions carefuly) - #67898 (Improve hygiene of `newtype_index`) - #67908 (rustdoc: HTML escape const values) - #67909 (Fix ICE in const pretty printing and resolve FIXME) - #67929 (Formatting an example for method Vec.retain) - #67934 (Clean up E0178 explanation) - #67936 (fire "non_camel_case_types" for associated types) - #67943 (Missing module std in example.) - #67962 (Update books) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 7, 2020
…gisa
Split MIR building into its own crate
This moves `rustc_mir::{build, hair, lints}` to `rustc_mir_build`.
The new crate only has a `provide` function as it's public API.
Based on rust-lang#67898
cc @Centril @rust-lang/compiler
r? @oli-obk
bors
added a commit
that referenced
this pull request
Jan 12, 2020
Split MIR building into its own crate
This moves `rustc_mir::{build, hair, lints}` to `rustc_mir_build`.
The new crate only has a `provide` function as it's public API.
Based on #67898
cc @Centril @rust-lang/compiler
r? @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newtype_indexno longer needsrustc_index::vec::Idxto be in scope.r? @Centril