Skip to content

Conversation

popzxc
Copy link
Contributor

@popzxc popzxc commented Jan 7, 2020

This PR replaces matches like

match var {
    value => true,
    _ => false,
}

with use of matches! macro.

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2020
@Centril
Copy link
Contributor

Centril commented Jan 8, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 8, 2020

📌 Commit 0eb6d796fa08bcb94dd3f504dcbd5dbb662d5d6b has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2020
@Centril
Copy link
Contributor

Centril commented Jan 8, 2020

Oops; looks like this needs ./x.py fmt first. @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2020
@popzxc
Copy link
Contributor Author

popzxc commented Jan 8, 2020

Applied. Sorry, didn't know that rustfmt is used now.

@Centril
Copy link
Contributor

Centril commented Jan 8, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 8, 2020

📌 Commit f720469 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 8, 2020
Use matches macro in libcore and libstd

This PR replaces matches like

```rust
match var {
    value => true,
    _ => false,
}
```

with use of `matches!` macro.

r? @Centril
bors added a commit that referenced this pull request Jan 9, 2020
Rollup of 12 pull requests

Successful merges:

 - #67630 (Treat extern statics just like statics in the "const pointer to static" representation)
 - #67747 (Explain that associated types and consts can't be accessed directly on the trait's path)
 - #67884 (Fix incremental builds of core by allowing unused attribute.)
 - #67966 (Use matches macro in libcore and libstd)
 - #67979 (Move `intravisit` => `rustc_hir` + misc cleanup)
 - #67986 (Display more informative ICE)
 - #67990 (slice patterns: harden match-based borrowck tests)
 - #68005 (Improve E0184 explanation)
 - #68009 (Spell check librustc_error_codes)
 - #68023 (Fix issue #68008)
 - #68024 (Remove `-Z continue-parse-after-error`)
 - #68026 (Small improvements in lexical_region_resolve)

Failed merges:

r? @ghost
@bors bors merged commit f720469 into rust-lang:master Jan 9, 2020
@popzxc popzxc deleted the core-std-matches branch January 9, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants