-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change -Z time event naming scheme and make them generic activities #67988
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Thanks for opening this PR, @Zoxc. I'll take a look shortly. |
As a side note (haven't reviewed this in detail yet): Once #67397 lands, there is a clean way of attaching arguments to events without tripping up the tooling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
|
||
/// Start profiling a sparse pass. Profiling continues until the | ||
/// Start profiling a verbose generic activity. Profiling continues until the | ||
/// VerboseTimingGuard returned from this call is dropped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following to the doc comment:
In addition to recording a
measureme
event, "verbose" generic activities also print a timing entry to the console (if the compiler is invoked with-Ztime
or-Ztime-passes
).
) | ||
} | ||
|
||
/// Start profiling a generic pass. Profiling continues until the | ||
/// Start profiling a extra verbose generic activity. Profiling continues until the | ||
/// VerboseTimingGuard returned from this call is dropped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following to the doc comment:
Note that "extra verbose" generic activities do not record a
measureme
event. They only print a timing entry to the console (if-Ztime-passes
is specified).
(it is -Z time-passes
, right?)
@bors r=michaelwoerister p=1 |
📌 Commit dee4077212f32b86272e9d2a0a5265e06b181269 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #68034) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=michaelwoerister |
📌 Commit 7db4b7e has been approved by |
Change -Z time event naming scheme and make them generic activities I made the `-Z time-passes` only events (which encodes argument in the event id) use a `extra_verbose_generic_activity` function which does not emit self-profiling events. r? @michaelwoerister cc @wesleywiser
Change -Z time event naming scheme and make them generic activities I made the `-Z time-passes` only events (which encodes argument in the event id) use a `extra_verbose_generic_activity` function which does not emit self-profiling events. r? @michaelwoerister cc @wesleywiser
@bors retry rolled up. |
Rollup of 6 pull requests Successful merges: - #67258 (Introduce `X..`, `..X`, and `..=X` range patterns) - #67358 (Add HashSet::get_or_insert_owned) - #67935 (Relax the Sized bounds on Pin::map_unchecked(_mut)) - #67975 (Export public scalar statics in wasm) - #67988 (Change -Z time event naming scheme and make them generic activities) - #68006 (Recognise riscv64 in compiletest) Failed merges: - #67806 (Extract `rustc_ast_passes`, move gating, & refactor linting) r? @ghost
☀️ Test successful - checks-azure |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Add some missing timers Based on rust-lang#67988 r? @wesleywiser
Add some missing timers Based on rust-lang#67988 r? @wesleywiser
I made the
-Z time-passes
only events (which encodes argument in the event id) use aextra_verbose_generic_activity
function which does not emit self-profiling events.r? @michaelwoerister
cc @wesleywiser