perf: Eagerly convert literals to consts #68118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Centril
reviewed
Jan 11, 2020
BenLewis-Seequent
force-pushed
the
eager_lit_eval
branch
from
952247d
to
5a20dba
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Jan 11, 2020
perf: Eagerly convert literals to consts Previousely even literal constants were being converted to an `Unevaluted` constant for evaluation later. This seems unecessary as no more information is needed to be able to convert the literal to a mir constant. Hopefully this will also minimise the performance impact of #67717, as far less constant evaluations are needed.
|
☀️ Try build successful - checks-azure |
|
Queued 3704c43 with parent 543b7d9, future comparison URL. |
|
Finished benchmarking try commit 3704c43, comparison URL. |
varkor
added
S-waiting-on-author
…on unevaluated consts which requires a lot of unnecessary work to evaluate them further down the line.
BenLewis-Seequent
force-pushed
the
eager_lit_eval
branch
from
5a20dba
to
02fffc1
Compare
|
Rebased. |
|
@bors r+ |
|
📌 Commit 02fffc1 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 02fffc1 with merge 05ae4a7c0365d040dda20ff94107b371939003d0... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 583a4fc has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 14, 2020
perf: Eagerly convert literals to consts Previousely even literal constants were being converted to an `Unevaluted` constant for evaluation later. This seems unecessary as no more information is needed to be able to convert the literal to a mir constant. Hopefully this will also minimise the performance impact of rust-lang#67717, as far less constant evaluations are needed.
bors
added a commit
that referenced
this pull request
Jan 15, 2020
perf: Eagerly convert literals to consts Previousely even literal constants were being converted to an `Unevaluted` constant for evaluation later. This seems unecessary as no more information is needed to be able to convert the literal to a mir constant. Hopefully this will also minimise the performance impact of #67717, as far less constant evaluations are needed.
|
☀️ Test successful - checks-azure |
|
@varkor Wait, does this fix |
eddyb
reviewed
Mar 6, 2020
Comment on lines
+6
to
+7
| //[legacy]normalize-stderr-32bit: "hdb62078998ce7ea8" -> "SYMBOL_HASH" | ||
| //[legacy]normalize-stderr-64bit: "h62e540f14f879d56" -> "SYMBOL_HASH" |
There was a problem hiding this comment.
I don't think we care about hashes, you could probably use regex to always normalize away h[0-9a-f]{16}.
There was a problem hiding this comment.
(this scared me when I first saw it, but these are for the target, not the host, and symbol names don't have to be constant between targets)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previousely even literal constants were being converted to an
Unevalutedconstant for evaluation later. This seems unecessary as no more information is needed to be able to convert the literal to a mir constant.Hopefully this will also minimise the performance impact of #67717, as far less constant evaluations are needed.