Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent urls in headings #68224

Merged
merged 4 commits into from
Jan 18, 2020
Merged

Prevent urls in headings #68224

merged 4 commits into from
Jan 18, 2020

Conversation

GuillaumeGomez
Copy link
Member

kinnison
kinnison approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this does fix the raised issue.

@kinnison
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2020

📌 Commit 1bf9f69 has been approved by kinnison

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2020
@ollie27
Copy link
Member

ollie27 commented Jan 14, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2020
@GuillaumeGomez
Copy link
Member Author

Updated!

ollie27
ollie27 reviewed Jan 16, 2020
View reviewed changes
Copy link
Member

@ollie27 ollie27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. r=me with the change to the test applied.

src/test/rustdoc/remove-url-from-headings.rs Outdated

/// fooo
///
/// # Implementing [stuff](http://a.a) somewhere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// # Implementing [stuff](http://a.a) somewhere
/// # Implementing [stuff](http://a.a "title") somewhere

We may as well check that the link title doesn't show up accidentally while we're at it.

@GuillaumeGomez
Copy link
Member Author

Applied suggestion.

@GuillaumeGomez
Copy link
Member Author

@bors: r=ollie27

@bors
Copy link
Contributor

bors commented Jan 18, 2020

📌 Commit 298e8ad has been approved by ollie27

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 18, 2020
@Dylan-DPC
Rollup merge of rust-lang#68224 - GuillaumeGomez:prevent-urls-in-head…
3c57f85 
…ings, r=ollie27

Prevent urls in headings

Fixes rust-lang#68215.

cc @pietroalbini @ollie27

r? @kinnison
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 18, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 18, 2020
@Centril
Rollup merge of rust-lang#68224 - GuillaumeGomez:prevent-urls-in-head…
36e58ea 
…ings, r=ollie27

Prevent urls in headings

Fixes rust-lang#68215.

cc @pietroalbini @ollie27

r? @kinnison
@Centril Centril mentioned this pull request Jan 18, 2020
Merged
bors added a commit that referenced this pull request Jan 18, 2020
@bors
Auto merge of #68351 - Centril:rollup-0gzuh0p, r=Centril
1ce08f9 
Rollup of 5 pull requests

Successful merges:

 - #67712 (Stabilize `#![feature(slice_patterns)]` in 1.42.0)
 - #68224 (Prevent urls in headings)
 - #68340 (clean up e0200 explanation)
 - #68341 (Fix syscalls tables in docs of std::time.)
 - #68342 (improve type_name_of_val docs)

Failed merges:

r? @ghost
@bors bors merged commit 298e8ad into rust-lang:master Jan 18, 2020
@GuillaumeGomez GuillaumeGomez deleted the prevent-urls-in-headings branch January 19, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

@kinnison kinnison kinnison approved these changes

Assignees

@kinnison kinnison

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent links in titles
4 participants
@GuillaumeGomez @kinnison @bors @ollie27