Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array repeat expression lengths must be monomorphic at MIR building time #68285

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Array repeat expression lengths must be monomorphic at MIR building time #68285

merged 1 commit into from
Jan 17, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 16, 2020

fixes #67743

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2020
davidtwco
davidtwco approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me when CI passes

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 16, 2020

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jan 16, 2020

📌 Commit eed0d33 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2020
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 17, 2020

@bors p=1 this unblocks the playground allowing it to update its nightly

@bors
Copy link
Contributor

bors commented Jan 17, 2020

⌛ Testing commit eed0d33 with merge 71c6346...

bors added a commit that referenced this pull request Jan 17, 2020
@bors
Auto merge of #68285 - oli-obk:specialization_regression, r=davidtwco
71c6346 
Array repeat expression lengths must be monomorphic at MIR building time

fixes #67743
@bors
Copy link
Contributor

bors commented Jan 17, 2020

☀️ Test successful - checks-azure
Approved by: davidtwco
Pushing 71c6346 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2020
@bors bors merged commit eed0d33 into rust-lang:master Jan 17, 2020
@oli-obk oli-obk deleted the specialization_regression branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent nightly doesn't support array length from indirectly referenced trait constant
4 participants
@oli-obk @rust-highfive @bors @davidtwco