Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and test predicates using normalize_and_test_predicates for const-prop #68297

Merged
merged 4 commits into from
Jan 21, 2020

Commits on Jan 16, 2020

  1. Configuration menu
    Copy the full SHA
    d088d8a View commit details
    Browse the repository at this point in the history
  2. Filter and test predicates using normalize_and_test_predicates for …

    …const-prop
    
    Fixes rust-lang#68264
    
    Previously, I attempted to use
    `substitute_normalize_and_test_predicates` to detect unsatisfiable
    bounds. Unfortunately, since const-prop runs in a generic environment
    (we don't have any of the function's generic parameters substituted),
    this could lead to cycle errors when attempting to normalize predicates.
    
    This check is replaced with a more precise check. We now only call
    `normalize_and_test_predicates` on predicates that have the possibility
    of being proved unsatisfiable - that is, predicates that don't depend
    on anything local to the function (e.g. generic parameters). This
    ensures that we don't hit cycle errors when we normalize said
    predicates, while still ensuring that we detect unsatisfiable
    predicates.
    Aaron1011 committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    171fe82 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Fix typo

    Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>
    Aaron1011 and oli-obk authored Jan 17, 2020
    Configuration menu
    Copy the full SHA
    c431cd7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fef3d8 View commit details
    Browse the repository at this point in the history