Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that we error when calling "const extern fn" with wrong convention #68370

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Ensure that we error when calling "const extern fn" with wrong convention #68370

merged 1 commit into from
Jan 27, 2020
+44 −0

Conversation

Aaron1011
Copy link
Member

See #64926

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2020
@Centril Centril added the F-const_extern_fn `#![feature(const_extern_fn)]` label Jan 20, 2020
@Centril
Copy link
Contributor

Centril commented Jan 20, 2020

r? @RalfJung

@RalfJung
Copy link
Member

(I hope this is not urgent, I am traveling this week)

@Aaron1011
Copy link
Member Author

This is just a test to ensure that the current, correct behavior doesn't change. It's not urgent at all.

@Aaron1011
Copy link
Member Author

@RalfJung: Updated

@RalfJung
Copy link
Member

Thanks!

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jan 27, 2020

📌 Commit 4a65032 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2020
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 27, 2020
@pietroalbini
Rollup merge of rust-lang#68370 - Aaron1011:const-extern-test, r=Ralf…
7e82434 
…Jung

Ensure that we error when calling "const extern fn" with wrong convention

See rust-lang#64926
@pietroalbini pietroalbini mentioned this pull request Jan 27, 2020
Merged
bors added a commit that referenced this pull request Jan 27, 2020
@bors
Auto merge of #68566 - pietroalbini:rollup-22hbo3e, r=pietroalbini
8a79d08 
Rollup of 4 pull requests

Successful merges:

 - #67928 (Update RELEASES.md for 1.41.0)
 - #68370 (Ensure that we error when calling "const extern fn" with wrong convention)
 - #68531 ([self-profiler] Two small cleanups)
 - #68562 (Fix spelling errors)

Failed merges:

r? @ghost
@bors bors merged commit 4a65032 into rust-lang:master Jan 27, 2020
@Aaron1011 Aaron1011 deleted the const-extern-test branch January 27, 2020 15:50
@Aaron1011 Aaron1011 mentioned this pull request Mar 16, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
F-const_extern_fn `#![feature(const_extern_fn)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Aaron1011 @rust-highfive @Centril @RalfJung @bors @alexcrichton