Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprust: use as_deref #68441

Merged
merged 1 commit into from
Jan 23, 2020
Merged

pprust: use as_deref #68441

merged 1 commit into from
Jan 23, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 22, 2020

Some drive-by cleanup.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 22, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Not entirely sure that I like the new form better, but overall I wish this wasn't necessary, and it doesn't seem too much worse :)

@bors
Copy link
Contributor

bors commented Jan 22, 2020

📌 Commit 7962ccb has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jan 22, 2020

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Jan 22, 2020
…ulacrum

pprust: use as_deref

Some drive-by cleanup.
@petrochenkov
Copy link
Contributor

r? @Mark-Simulacrum

tmandry added a commit to tmandry/rust that referenced this pull request Jan 22, 2020
…ulacrum

pprust: use as_deref

Some drive-by cleanup.
tmandry added a commit to tmandry/rust that referenced this pull request Jan 23, 2020
…ulacrum

pprust: use as_deref

Some drive-by cleanup.
bors added a commit that referenced this pull request Jan 23, 2020
Rollup of 10 pull requests

Successful merges:

 - #67195 ([experiment] Add `-Z no-link` flag)
 - #68253 (add bare metal ARM Cortex-A targets to rustc)
 - #68361 (Unbreak linking with lld 9 on FreeBSD 13.0-CURRENT i386)
 - #68388 (Make `TooGeneric` error in WF checking a proper error)
 - #68409 (Micro-optimize OutputFilenames)
 - #68410 (Export weak symbols used by MemorySanitizer)
 - #68425 (Fix try-op diagnostic in E0277 for methods)
 - #68440 (bootstrap: update clippy subcmd decription)
 - #68441 (pprust: use as_deref)
 - #68462 (librustc_mir: don't allocate vectors where slices will do.)

Failed merges:

r? @ghost
@bors bors merged commit 7962ccb into rust-lang:master Jan 23, 2020
@Centril Centril deleted the pprust-as_deref branch January 23, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants