-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split lang_items to crates rustc_hir
and rustc_passes
.
#68554
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #68635) made this pull request unmergeable. Please resolve the merge conflicts. |
rustc_lang_items
and rustc_passes
.rustc_hir
and rustc_passes
.
☔ The latest upstream changes (presumably #67688) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #68080) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #68133) made this pull request unmergeable. Please resolve the merge conflicts. |
Sorry, I haven't had time to look at this. I think it's better to reassign to r? @Zoxc, who suggested the change. |
src/librustc/middle/lang_items.rs
Outdated
@@ -417,4 +30,36 @@ impl<'tcx> TyCtxt<'tcx> { | |||
} | |||
}) | |||
} | |||
|
|||
pub fn fn_trait_lang_item(&self, id: DefId) -> Option<ty::ClosureKind> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be named fn_trait_kind_from_lang_item
. It currently sounds like it returns a lang item.
src/librustc_hir/lang_items.rs
Outdated
$( item_refs.insert($name, ($variant as usize, $target)); )* | ||
item_refs | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe fix up the indentation in this macro?
@bors r+ |
📌 Commit fc73e19 has been approved by |
Split lang_items to crates `rustc_hir` and `rustc_passes`. As discussed in comment rust-lang#67688 (comment)
Rollup of 11 pull requests Successful merges: - #67695 (Added dyn and true keyword docs) - #68487 ([experiment] Support linking from a .rlink file) - #68554 (Split lang_items to crates `rustc_hir` and `rustc_passes`.) - #68937 (Test failure of unchecked arithmetic intrinsics in const eval) - #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup) - #68999 (remove dependency on itertools) - #69026 (Remove common usage pattern from `AllocRef`) - #69027 (Add missing `_zeroed` varants to `AllocRef`) - #69058 (Preparation for allocator aware `Box`) - #69070 (Add self to .mailmap) - #69077 (Fix outdated doc comment.) Failed merges: r? @ghost
This was rolled up into cd5441f, which has caused some compile time regressions: https://perf.rust-lang.org/compare.html?start=7cba853b4f6080bf7831169fe5632ec9b6833242&end=cd5441faf4e56d136d7c05d5eb55b4a41396edaf&stat=instructions:u Could this PR have caused them? |
@jonas-schievink The regressions seem to be in LLVM though, maybe it's the |
Ah, yeah, maybe that was it |
As discussed in comment #67688 (comment)