Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
added
beta-nominated
|
@bors r+ |
|
📌 Commit 979f5b4 has been approved by |
bors
added
S-waiting-on-bors
|
r? @pnkfelix |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 29, 2020
Make conflicting_repr_hints a deny-by-default c-future-compat lint Closes rust-lang#68428. cc rust-lang#68585. r? @petrochenkov @pnkfelix
bors
added a commit
that referenced
this pull request
Jan 29, 2020
Rollup of 7 pull requests Successful merges: - #67722 (Minor: note how Any is an unsafe trait in SAFETY comments) - #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint) - #68598 (Fix null synthetic_implementors error) - #68603 (Changelog: Demonstrate final build-override syntax) - #68609 (Set lld flavor for MSVC to link.exe) - #68611 (Correct ICE caused by macros generating invalid spans.) - #68627 (Document that write_all will not call write if given an empty buffer) Failed merges: r? @ghost
Centril
removed
T-compiler
Mark-Simulacrum
added
beta-nominated
|
Re-adding beta-nomination, AFAICT this didn't get into beta. error[E0566]: conflicting representation hintsNumber of crates regressed: 2 |
|
discussed at T-compiler meeting. Approved for beta backport. |
pnkfelix
added
the
beta-accepted
Merged
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Feb 24, 2020
[beta] beta backports This backports the following PRs: * Revert "Remove `checked_add` in `Layout::repeat`" #69241 * Do not ICE when encountering `yield` inside `async` block #69175 * Fix MIR typeck soundness holes #69145 * Fix extra subslice lowering #69128 * Correct ICE caused by macros generating invalid spans. #68611 * Make conflicting_repr_hints a deny-by-default c-future-compat lint #68586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68428.
cc #68585.
r? @petrochenkov @pnkfelix