Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an early-exit to QueryNormalizer::fold_ty #68606

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add an early-exit to QueryNormalizer::fold_ty #68606

merged 1 commit into from
Jan 28, 2020

Conversation

jonas-schievink
Copy link
Contributor

Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2020
@jonas-schievink jonas-schievink mentioned this pull request Jan 28, 2020
Merged
4 tasks
@jonas-schievink

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Jan 28, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jan 28, 2020

⌛ Trying commit 474d0e3 with merge 0c5d24e029a4ba74ad3647cefef127bf15ae6200...

@jonas-schievink

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Jan 28, 2020

@bors rollup=never since this is a perf win, and we want to avoid masking regressions from other PRs in the rollup.

@Centril
Copy link
Contributor

Centril commented Jan 28, 2020

Seems like we already did the perf testing @bors try-

@Zoxc
Copy link
Contributor

Zoxc commented Jan 28, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2020

📌 Commit 474d0e3 has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2020
@Zoxc
Copy link
Contributor

Zoxc commented Jan 28, 2020

@bors p=1

@bors
Copy link
Contributor

bors commented Jan 28, 2020

⌛ Testing commit 474d0e3 with merge 3761dcd...

bors added a commit that referenced this pull request Jan 28, 2020
@bors
Auto merge of #68606 - jonas-schievink:normalize-fastpath, r=Zoxc
3761dcd 
Add an early-exit to `QueryNormalizer::fold_ty`

Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.

r? @Zoxc
@bors
Copy link
Contributor

bors commented Jan 28, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 3761dcd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 28, 2020
@bors bors merged commit 474d0e3 into rust-lang:master Jan 28, 2020
@jonas-schievink jonas-schievink deleted the normalize-fastpath branch January 28, 2020 23:50
@Zoxc Zoxc mentioned this pull request Jan 29, 2020
Closed
@bstrie bstrie mentioned this pull request Jan 31, 2020
Closed
@tmandry tmandry mentioned this pull request Feb 3, 2020
Closed
bors added a commit that referenced this pull request Feb 3, 2020
@bors
Auto merge of #68811 - tmandry:back-to-intofuture, r=<try>
976ac3b 
Re-land "add IntoFuture trait and support for await"

Testing the code from #65244 to see if the performance regressions are still there. #68606 and #68672 made perf optimizations that might interact with this change.

If this lands, fixes #67982.

cc @seanmonstar @jonas-schievink
r? @cramertj
@jonas-schievink jonas-schievink mentioned this pull request Feb 5, 2020
Closed
@jonas-schievink jonas-schievink mentioned this pull request Mar 7, 2020
Closed
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 13, 2020
@jonas-schievink jonas-schievink added the relnotes-perf Performance improvements that should be mentioned in the release notes. label Mar 13, 2020
@jonas-schievink jonas-schievink added this to the 1.43 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Zoxc Zoxc

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. relnotes-perf Performance improvements that should be mentioned in the release notes. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.
6 participants
@jonas-schievink @Centril @rust-timer @bors @Zoxc @rust-highfive