Skip to content

Do not ICE in type-alias-impl-trait with save-analysis #68744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 1, 2020

FIxes #68621
Fixes #68750

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2020
@Centril Centril added the F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` label Feb 2, 2020
@cramertj
Copy link
Member

cramertj commented Feb 3, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 3, 2020

📌 Commit ae22bf9 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 3, 2020
…cramertj

Do not ICE in `type-alias-impl-trait` with save-analysis

FIxes rust-lang#68621
Fixes rust-lang#68750
bors added a commit that referenced this pull request Feb 3, 2020
Rollup of 8 pull requests

Successful merges:

 - #68678 (Install robots.txt into rust-docs tarballs)
 - #68711 (Added upper bound of what vecs and boxes can allocate)
 - #68744 (Do not ICE in `type-alias-impl-trait` with save-analysis)
 - #68777 (Clean up E0263 explanation)
 - #68787 (Optimize core::ptr::align_offset (part 1))
 - #68797 (Fix links to types instead of modules)
 - #68798 (Test that `#[track_caller]` as `fn()` respects RT / CTFE equivalence)
 - #68800 (Stabilize `core::iter::once_with()`)

Failed merges:

r? @ghost
@bors bors merged commit ae22bf9 into rust-lang:master Feb 3, 2020
@JohnTitor JohnTitor deleted the fix-ice-save-analysis branch February 4, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Development

Successfully merging this pull request may close these issues.

ice on glacier 63279.rs with -Zsave-anaylsis save-analysis causes ICE
5 participants