Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #68747

Closed
wants to merge 16 commits into from
Closed

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

tomjakubowski and others added 16 commits January 30, 2020 13:38
On the backend, rustdoc now emits `paths` entries to a crate's search
index for struct-like enum variants, and index items of type structfield
which belong to such variants point to their variant parents in the
`paths` table, rather than their enum grandparents.  The path entry for
a variant is the fully qualified module path plus the enum name.

On the frontend, the search code recognizes structfields belonging to
structlike variants in the `paths` table and re-constructs the URL to
the field's anchor on the enum documentation page.

closes rust-lang#16017
rustc is now using rustfmt, not the old formatter.
…mulacrum

Use BufWriter for emitting MIR

I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
…-search, r=kinnison

Struct variant field search

Fixes rust-lang#16017.

Reopening of rust-lang#64724.

cc @tomjakubowski
cc @ollie27

r? @kinnison
…if-on-nightly, r=centril

[docs] remind bug reporters to update nightly

Hi and thanks for rust! Today I reported a bug in nightly that was already fixed, so I thought other potential bug reporters might appreciate a reminder to update before reporting.  I wasn't sure if this would apply for other channels as well.
…=Mark-Simulacrum

Ignore `build` dir formatting

I've noticed that rustfmt tries to parse and check the formatting of code in `build` if `.git` is missing (which includes test artifacts and generated code). This should fix that.
Added upper bound of what vecs and boxes can allocate

Fixed issue rust-lang#68593
I added a line of documentation to these two files to reflect that vectors and boxes ensure that they never allocate more than `isize::MAX` bytes.
r? @steveklabnik
…inter-in-format-tests, r=jonas-schievink

Remove a comment about pretty printer in formatting tests

rustc is now using rustfmt, not the old formatter.
…=Centril

Do not suggest things named underscore

Fixes rust-lang#68719

r? @estebank
@JohnTitor
Copy link
Member Author

@bors r+ p=7 rollup=never

@bors
Copy link
Collaborator

bors commented Feb 1, 2020

📌 Commit b6efab8 has been approved by JohnTitor

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 1, 2020
@bors
Copy link
Collaborator

bors commented Feb 1, 2020

⌛ Testing commit b6efab8 with merge ba1394d84b529447279206477a35009e844f330f...

@JohnTitor JohnTitor added the rollup A PR which is a rollup label Feb 1, 2020
@rust-highfive
Copy link
Contributor

The job x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-01T23:21:52.6133070Z ---- [js-doc-test] rustdoc-js/struct-like-variant.rs stdout ----
2020-02-01T23:21:52.6133140Z 
2020-02-01T23:21:52.6133620Z error: rustdoc-js test failed!
2020-02-01T23:21:52.6133710Z status: exit code: 1
2020-02-01T23:21:52.6134590Z command: "/usr/local/bin/node" "/Users/runner/runners/2.164.6/work/1/s/src/tools/rustdoc-js/tester.js" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/test/rustdoc-js" "struct-like-variant"
2020-02-01T23:21:52.6135310Z ------------------------------------------
2020-02-01T23:21:52.6135820Z Checking "struct-like-variant" ... 
2020-02-01T23:21:52.6135870Z 
2020-02-01T23:21:52.6136350Z ------------------------------------------
2020-02-01T23:21:52.6136350Z ------------------------------------------
2020-02-01T23:21:52.6136450Z stderr:
2020-02-01T23:21:52.6136940Z ------------------------------------------
2020-02-01T23:21:52.6137020Z FAILED
2020-02-01T23:21:52.6137570Z ==> Result not found in 'others': '{"path":"struct_like_variant::Enum::Bar::name","name":"l"}'
2020-02-01T23:21:52.6138140Z ------------------------------------------
2020-02-01T23:21:52.6138220Z 
2020-02-01T23:21:52.6138250Z 
2020-02-01T23:21:52.6138290Z 
---
2020-02-01T23:21:52.6140090Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-01T23:21:52.6140220Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-01T23:21:52.6140310Z 
2020-02-01T23:21:52.6140350Z 
2020-02-01T23:21:52.6143030Z command did not execute successfully: "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "--rustdoc-path" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustdoc" "--src-base" "/Users/runner/runners/2.164.6/work/1/s/src/test/rustdoc-js" "--build-base" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/test/rustdoc-js" "--stage-id" "stage2-x86_64-apple-darwin" "--mode" "js-doc-test" "--target" "x86_64-apple-darwin" "--host" "x86_64-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.164.6/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.1-rust-1.42.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-01T23:21:52.6144130Z 
2020-02-01T23:21:52.6144170Z 
2020-02-01T23:21:52.6150650Z failed to run: /Users/runner/runners/2.164.6/work/1/s/build/bootstrap/debug/bootstrap test
2020-02-01T23:21:52.6150810Z Build completed unsuccessfully in 1:27:21
2020-02-01T23:21:52.6150810Z Build completed unsuccessfully in 1:27:21
2020-02-01T23:21:52.6212600Z == clock drift check ==
2020-02-01T23:21:52.6273570Z   local time: Sat Feb  1 23:21:52 UTC 2020
2020-02-01T23:21:52.7010630Z   network time: Sat, 01 Feb 2020 23:21:52 GMT
2020-02-01T23:21:52.7012280Z == end clock drift check ==
2020-02-01T23:21:52.7052700Z 
2020-02-01T23:21:52.7181500Z ##[error]Bash exited with code '1'.
2020-02-01T23:21:52.7222740Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-01T23:21:52.7225620Z ==============================================================================
2020-02-01T23:21:52.7225700Z Task         : Get sources
2020-02-01T23:21:52.7225790Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Collaborator

bors commented Feb 1, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 1, 2020
@JohnTitor JohnTitor closed this Feb 1, 2020
@JohnTitor JohnTitor deleted the rollup-klhrp3c branch February 1, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants