Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Backport disabling of Clippy lint debug_assert_with_mut_call #68753

Merged
merged 1 commit into from
Feb 4, 2020
Merged

[beta] Backport disabling of Clippy lint debug_assert_with_mut_call #68753

merged 1 commit into from
Feb 4, 2020

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Feb 1, 2020

This disables the Clippy lint debug_assert_with_mut_call, see rust-lang/rust-clippy#5112.

Since this is a deny-by-default lint, that landed with 1.41.0, we want to disable this lint rather sooner than later, that's why the backport.

Clippy branch for the backport: https://github.com/rust-lang/rust-clippy/tree/rust-1.42.0

r? @Mark-Simulacrum

cc (from the Clippy side) @Manishearth @oli-obk

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 1, 2020
@flip1995 flip1995 mentioned this pull request Feb 1, 2020
Merged
Manishearth
Manishearth approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ cc @pietro if I need to do something special for the backport

@Manishearth
Copy link
Member

Er, @pietroalbini

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

I think this is fine to land as-is; beta backports are more than a week away most likely so we can get this in in the meantime.

@bors
Copy link
Collaborator

bors commented Feb 2, 2020

📌 Commit faeed78 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2020
@bors
Copy link
Collaborator

bors commented Feb 2, 2020

⌛ Testing commit faeed78 with merge 0b02c7a7d92d51a64118bf9a04dde357566f9783...

@rust-highfive
Copy link
Contributor

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Collaborator

bors commented Feb 2, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2020
@flip1995
Copy link
Member Author

flip1995 commented Feb 3, 2020

ping @Mark-Simulacrum The azure build was canceled by @alexcrichton. Do I have to change something or does it just need a retry?

@Mark-Simulacrum
Copy link
Member

2020-02-02T16:56:48.5390161Z fatal: write error: No space left on device

Odd. I suspect (hope!) this is spurious. @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2020
@bors
Copy link
Collaborator

bors commented Feb 4, 2020

⌛ Testing commit faeed78 with merge 3d2613e...

bors added a commit that referenced this pull request Feb 4, 2020
@bors
Auto merge of #68753 - flip1995:clippy-backport, r=Mark-Simulacrum
3d2613e 
[beta] Backport disabling of Clippy lint debug_assert_with_mut_call

This disables the Clippy lint `debug_assert_with_mut_call`, see rust-lang/rust-clippy#5112.

Since this is a deny-by-default lint, that landed with `1.41.0`, we want to disable this lint rather sooner than later, that's why the backport.

Clippy branch for the backport: https://github.com/rust-lang/rust-clippy/tree/rust-1.42.0

r? @Mark-Simulacrum

cc (from the Clippy side) @Manishearth @oli-obk
@bors
Copy link
Collaborator

bors commented Feb 4, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 3d2613e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2020
@bors bors merged commit faeed78 into rust-lang:beta Feb 4, 2020
@flip1995 flip1995 deleted the clippy-backport branch February 4, 2020 08:14
bors added a commit to rust-lang/rust-clippy that referenced this pull request Feb 4, 2020
@bors
Auto merge of #5124 - flip1995:backport_back_merge, r=flip1995
ef4eec1 
Merge backport branch back into master

Merge back backport branch rust-1.42.0 into master.

Waiting on rust-lang/rust#68753

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this pull request Feb 4, 2020
@bors
Auto merge of #5124 - flip1995:backport_back_merge, r=flip1995
d33c603 
Merge backport branch back into master

Merge back backport branch rust-1.42.0 into master.

Waiting on rust-lang/rust#68753

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flip1995 @rust-highfive @Manishearth @Mark-Simulacrum @bors