-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the type_of
return a generic type for generators
#68884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
📌 Commit 98c51fd has been approved by |
@nikomatsakis It fixes the |
OK, I missed the second case, I suspect that should be broken into its own issue. |
Make the `type_of` return a generic type for generators Fixes rust-lang#67651. r? @nikomatsakis
Failed in rollup @bors r- |
@bors r=nikomatsakis |
📌 Commit 1ae614f has been approved by |
Make the `type_of` return a generic type for generators Fixes rust-lang#67651. r? @nikomatsakis
Failed in rollup @bors r- |
☔ The latest upstream changes (presumably #70305) made this pull request unmergeable. Please resolve the merge conflicts. |
Specifically I think that this PR requires a |
@bors r=nikomatsakis |
📌 Commit 47a84f2 has been approved by |
Make the `type_of` return a generic type for generators Fixes rust-lang#67651. r? @nikomatsakis
⌛ Testing commit 47a84f2 with merge a81c062c169ef64f4ff9cd719dc23d78e21c7dd9... |
@bors retry |
Rollup of 8 pull requests Successful merges: - rust-lang#68884 (Make the `type_of` return a generic type for generators) - rust-lang#69788 (Fix sequence of Type and Trait in optin-builtin-traits in Unstable Book) - rust-lang#70074 (Expand: nix all fatal errors) - rust-lang#70077 (Store idents for `DefPathData` into crate metadata) - rust-lang#70213 (traits/fulfill: allow `stalled_on` to track `ty::Const::Infer(_)` (unused yet).) - rust-lang#70259 (Use Reveal::All in MIR optimizations) - rust-lang#70284 (correctly handle const params in type_of) - rust-lang#70289 (Refactor `codegen`) Failed merges: r? @ghost
if gen.is_some() { | ||
return tcx.typeck_tables_of(def_id).node_type(hir_id); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's funny, I almost did the opposite last week, trying to make #69968 work.
(It was a bad idea and the solution was to fix the actual code that couldn't handle unsubstitued closure types)
Closes rust-lang#66312. This issue was fixed by rust-lang#68884.
Add test for rust-lang#66312 Closes rust-lang#66312. This issue was fixed by rust-lang#68884. r? @Zoxc
Add test for rust-lang#66312 Closes rust-lang#66312. This issue was fixed by rust-lang#68884. r? @Zoxc
Add test for rust-lang#66312 Closes rust-lang#66312. This issue was fixed by rust-lang#68884. r? @Zoxc
Fixes #67651.
r? @nikomatsakis