Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up E0283 explanation #69007

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2020
@@ -1,7 +1,7 @@
This error occurs when the compiler doesn't have enough information
to unambiguously choose an implementation.
An implementation cannot be chose unambiguously because of the lack of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An implementation cannot be chose unambiguously because of the lack of
An implementation cannot be chosen unambiguously because of lack of

@@ -27,7 +27,9 @@ fn main() {
}
```

To resolve this error use the concrete type:
This error can be solved by adding type annotations to give the missing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This error can be solved by adding type annotations to give the missing
This error can be solved by adding type annotations that provide the missing

@@ -27,7 +27,9 @@ fn main() {
}
```

To resolve this error use the concrete type:
This error can be solved by adding type annotations to give the missing
information to the compier. In this case, the solution is to use a concrete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
information to the compier. In this case, the solution is to use a concrete
information to the compiler. In this case, the solution is to use a concrete

@GuillaumeGomez
Copy link
Member Author

Updated!

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 10, 2020

📌 Commit ded6292 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 10, 2020
bors added a commit that referenced this pull request Feb 10, 2020
Rollup of 6 pull requests

Successful merges:

 - #68897 (clean up E0275 explanation)
 - #68908 (Add long error code explanation message for E0637 )
 - #68932 (self-profile: Support arguments for generic_activities.)
 - #68986 (Make ASCII ctype functions unstably const )
 - #69007 (Clean up E0283 explanation)
 - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Feb 10, 2020
Rollup of 6 pull requests

Successful merges:

 - #68897 (clean up E0275 explanation)
 - #68908 (Add long error code explanation message for E0637 )
 - #68932 (self-profile: Support arguments for generic_activities.)
 - #68986 (Make ASCII ctype functions unstably const )
 - #69007 (Clean up E0283 explanation)
 - #69014 (change an instance of span_bug() to struct_span_err() to avoid ICE)

Failed merges:

r? @ghost
@bors bors merged commit ded6292 into rust-lang:master Feb 11, 2020
@GuillaumeGomez GuillaumeGomez deleted the clean-up-e0283 branch February 11, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants