Add initial debug fmt for Backtrace #69038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'm starting with this most basic version of a Debug format that just derives everything and doesn't force any symbol resolution as a starting point for the rest of the PR, I still haven't tested how this looks in practice because compile times but I'm working on getting a unit test that I can use as a playground to render the format pre and post resolution so I can paste that into this issue for review. |
|
This is the current format from this PR, lmk what further changes are necessary. As generated by this small snippet #[cfg(test)]
mod tests {
use super::*;
#[test]
fn debug_backtrace_fmt() {
let bt = Backtrace::capture();
eprintln!("uncaptured: {:?}", bt);
let bt = Backtrace::force_capture();
eprintln!("captured: {:?}", bt);
eprintln!("display print: {}", bt);
eprintln!("resolved: {:?}", bt);
unimplemented!();
}
} |
|
r? @dtolnay |
dtolnay
requested changes
Feb 10, 2020
There was a problem hiding this comment.
That representation looks extremely verbose to me. I expect that debug-printed backtraces are going to be a thing that humans see somewhat often (unfortunately) from unwrapped or debug printed error objects containing a backtrace. Could you see if you can strip out everything that wouldn't be informative to the reader?
Before:
Backtrace {
inner: Captured(
Mutex {
data: Capture {
actual_start: 2,
resolved: true,
frames: [
BacktraceFrame {
frame: Frame {
ip: 0x55c1fc866e5d,
symbol_address: 0x55c1fc866de0,
},
symbols: [
BacktraceSymbol {
name: Some(
std::backtrace::Backtrace::create,
),
filename: None,
lineno: None,
},
],
},
BacktraceFrame {
frame: Frame {
ip: 0x55c1fc866dd0,
symbol_address: 0x55c1fc866dc0,
},
symbols: [
BacktraceSymbol {
name: Some(
std::backtrace::Backtrace::force_capture,
),
filename: None,
lineno: None,
},
],
},
...
...
...
],
},
},
),
}More reasonable:
Backtrace [
"std::backtrace::Backtrace::create",
"std::backtrace::Backtrace::force_capture",
"core::ops::function::FnOnce::call_once @ /rustc/src/libcore/ops/function.rs:231",
]or list-of-maps style as suggested in #65280:
Backtrace [
{ fn: "std::backtrace::Backtrace::create" },
{ fn: "std::backtrace::Backtrace::force_capture" },
{ fn: "core::ops::function::FnOnce::call_once", file: "/rustc/src/libcore/ops/function.rs", line: 231 },
]
|
Sure, but I'm not sure how to handle the fact that a backtrace frame can have multiple symbols. Also, I'd personally prefer the to use How do you feel about this format |
|
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The logic within |
yaahc
force-pushed
the
backtrace-debug
branch
from
9d73fbf to
c0ba79e
Compare
|
Okay, independent of my previous comment, here is the current format @dtolnay with the changes you've requested. Fixing the |
|
Current version, this adds some |
dtolnay
requested changes
Feb 11, 2020
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Okay here is the current version I manually added |
yaahc
commented
Feb 11, 2020
|
and here we go again, for possibly the last time she says with great hubris |
|
Sigh... Why are these lines being skipped in the display impl ._. investigates Edit: its because of |
|
Nice! Almost there I think. Thanks for sticking with this.
|
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I believe the display impl prints the hashes for Here's the comparison between the alt and default display impls
They feel equally easy to read to me, so I have no preference, if you want my vote I'm gonna vote for no Edit: One thing I think might be important is how easily the debug impl can be parsed, so if you think that adding |
|
Oh I just noticed the resolved / non-opt debug print for Backtrace had hashes, thats definitely wrong, fixing. |
|
And now its backwards, because apparently they switched the meanings of alt where they use the alt print for PrintFmt::Short which is selected when alt is false 🙃 Gonna just make an executive decision here and not try to maintain exact compat with old behavior. |
|
Final-final-v2-format.jpg |
dtolnay
approved these changes
Feb 11, 2020
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r+ |
|
📌 Commit ec8ee7f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 12, 2020
Add initial debug fmt for Backtrace Fixes the first point in rust-lang#65280 related to rust-lang#53487
bors
added a commit
that referenced
this pull request
Feb 12, 2020
Rollup of 7 pull requests Successful merges: - #67954 (Support new LLVM pass manager) - #68981 ( Account for type params on method without parentheses) - #69002 (miri: improve and simplify overflow detection) - #69038 (Add initial debug fmt for Backtrace) - #69040 (Cleanup SGX entry code) - #69086 (Update compiler-builtins to 0.1.25) - #69095 (Minified theme check) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first point in #65280
related to #53487