Rollup of 11 pull requests #69056

jonas-schievink · 2020-02-11T10:58:12Z

Successful merges:

Improve ty.needs_drop #68679 (Improve ty.needs_drop)
Hasten macro parsing #68848 (Hasten macro parsing)
Python script PEP8 style guide space formatting and minor Python source cleanup #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup)
miri: improve and simplify overflow detection #69002 (miri: improve and simplify overflow detection)
traits: preallocate 2 Vecs of known initial size #69022 (traits: preallocate 2 Vecs of known initial size)
Remove common usage pattern from AllocRef #69026 (Remove common usage pattern from AllocRef)
Add missing _zeroed varants to AllocRef #69027 (Add missing _zeroed varants to AllocRef)
Use dyn Trait more in tests #69031 (Use dyn Trait more in tests)
ICE in nightly-2020-02-08: handle TerminatorKind::Yield in librustc_mir::transform::promote_consts::Validator method #69032 (ICE in nightly-2020-02-08: handle TerminatorKind::Yield in librustc_mir::transform::promote_consts::Validator method)
parser: Remove Parser::prev_token_kind #69034 (parser: Remove Parser::prev_token_kind)
Don't rustfmt check the vendor directory. #69047 (Don't rustfmt check the vendor directory.)

Failed merges:

Union fields have the ParamEnv of the union.

* Handle cycles in `needs_drop` correctly * Normalize types when computing `needs_drop` * Move queries from rustc to rustc_ty

* Handle arrays with const-generic lengths * Use closure for repeated code.

Currently, every iteration of the main loop in `generic_extension` instantiates a `Parser`, which is expensive because `Parser` is a large type. Many of those instantiations are only used immutably, particularly for simple-but-repetitive macros of the sort seen in `html5ever` and PR 68836. This commit initializes a single "base" parser outside the loop, and then uses `Cow` to avoid cloning it except for the mutating iterations. This speeds up `html5ever` runs by up to 15%.

The previous commit wrapped `Parser` within a `Cow` for the hot macro parsing path. As a result, there's no need for the `Cow` within `Directory`, because it lies within `Parser`.

This is a small win, because `Failure` is much more common than `Success`.

Co-Authored-By: varkor <github@varkor.com>

…y ops

Improve `ty.needs_drop` * Handle cycles in `needs_drop` correctly * Normalize types when computing `needs_drop` * Move queries from rustc to rustc_ty * Avoid query in simple cases reopens #65918

@eddyb

…nkov Hasten macro parsing r? @eddyb

Python script PEP8 style guide space formatting and minor Python source cleanup This PR includes the following changes in the Python sources based on a flake8 3.7.9 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.7.6 on Darwin lint: - PEP8 style guide spacing updates *without* line length changes - removal of unused local variable assignments in context managers and exception handling - removal of unused Python import statements - removal of unnecessary semicolons

@oli-obk

…iser miri: improve and simplify overflow detection This simplifies the overflow detection for signed binary operators, and adds overflow detection to unary operators so that const-prop doesn't have to crudely hand-roll that. It also fixes some bugs in the operator implementation that however, I think, were not observable. r? @oli-obk @wesleywiser

traits: preallocate 2 Vecs of known initial size The 2 preallocations are pretty obvious; both vectors will be as big as or larger than the collections they are created from. In `WfPredicates::normalize` the change from a functional style improves readability and should be perf-friendly, too.

@Amanieu

Remove common usage pattern from `AllocRef` This removes the common usage patterns from `AllocRef`: - `alloc_one` - `dealloc_one` - `alloc_array` - `realloc_array` - `dealloc_array` Actually, they add nothing to `AllocRef` except a [convenience wrapper around `Layout` and other methods in this trait](https://doc.rust-lang.org/1.41.0/src/core/alloc.rs.html#1076-1240) but have a major flaw: The documentation of `AllocRefs` notes, that > some higher-level allocation methods (`alloc_one`, `alloc_array`) are well-defined on zero-sized types and can optionally support them: it is left up to the implementor whether to return `Err`, or to return `Ok` with some pointer. With the current API, `GlobalAlloc` does not have those methods, so they cannot be overridden for `liballoc::Global`, which means that even if the global allocator would support zero-sized allocations, `alloc_one`, `alloc_array`, and `realloc_array` for `liballoc::Global` will error, while calling `alloc` with a zeroed-size `Layout` could succeed. Even worse: allocating with `alloc` and deallocating with `dealloc_{one,array}` could end up with not calling `dealloc` at all! For the full discussion please see rust-lang/wg-allocators#18 r? @Amanieu

@Amanieu

Add missing `_zeroed` varants to `AllocRef` The majority of the allocator wg has decided to add the missing `_zeroed` variants to `AllocRef`: > these should be added since they can be efficiently implemented with the `mremap` system call on Linux. `mremap` allows you to move/grow/shrink a memory mapping, and any new pages added for growth are guaranteed to be zeroed. > > If `AllocRef` does not have these methods then the user will have to manually write zeroes to the added memory since the API makes no guarantees on their contents. For the full discussion please see rust-lang/wg-allocators#14. This PR provides default implementations for `realloc_zeroed`, `alloc_excess_zeroed`, `realloc_excess_zeroed`, and `grow_in_place_zeroed`. r? @Amanieu

Use `dyn Trait` more in tests Here are some tests using the old trait object type syntax which are not testing the syntax itself. This has been extracted from #66364.

@jonas-schievink

…trochenkov ICE in nightly-2020-02-08: handle TerminatorKind::Yield in librustc_mir::transform::promote_consts::Validator method IR: #69017 regressed commit: f8fd462 Source: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=55e65a869e1f5fef64cc4462b1a5a087 Addresses ICE reported in #69017 by handling `TerminatorKind::Yield` in https://github.com/rust-lang/rust/blob/4d1241f5158ffd66730e094d8f199ed654ed52ae/src/librustc_mir/transform/promote_consts.rs#L465-L468. <details><summary>Nightly build</summary> <p> ``` $ cargo +nightly build Compiling yielder v0.1.0 (/Users/chris/Desktop/tests/rustlang-tests/yielder) error: internal compiler error: src/librustc_mir/transform/promote_consts.rs:467: _1 = suspend(move _21) -> [resume: bb2, drop: bb3] not promotable --> src/main.rs:8:27 | 8 | println!("-> {}", yield); | ^^^^^ thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports note: rustc 1.43.0-nightly (71c7e14 2020-02-09) running on x86_64-apple-darwin note: compiler flags: -C debuginfo=2 -C incremental --crate-type bin note: some of the compiler flags provided by cargo are hidden error: aborting due to previous error error: could not compile `yielder`. To learn more, run the command again with --verbose. ``` </p> </details> <details><summary>Stage 1 dev build</summary> <p> ``` $ cargo +stage1 build Compiling yielder v0.1.0 (/Users/chris/Desktop/tests/rustlang-tests/yielder) warning: function is never used: `gen` --> src/main.rs:6:4 | 6 | fn gen() -> impl Generator<usize> { | ^^^ | = note: `#[warn(dead_code)]` on by default Finished dev [unoptimized + debuginfo] target(s) in 0.53s ``` </p> </details> @jonas-schievink @oli-obk

@Centril

parser: Remove `Parser::prev_token_kind` Follow-up to #69006. r? @Centril

Don't rustfmt check the vendor directory. I need to be able to run `x.py tidy` to do license checks (which requires vendored dependencies). However, when vendoring is enabled, it wants to rustfmt check the entire vendor directory, which doesn't work.

jonas-schievink · 2020-02-11T10:58:48Z

@bors r+ p=11 rollup=never

bors · 2020-02-11T10:58:50Z

📌 Commit 4f1f2b5 has been approved by jonas-schievink

bors · 2020-02-11T13:09:10Z

⌛ Testing commit 4f1f2b5 with merge e193950a7a682952d315319eb7c01f2de7b2c055...

rust-highfive · 2020-02-11T14:44:39Z

The job test-various of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-11T14:43:37.2234905Z 
2020-02-11T14:43:37.2235869Z ---- [ui] ui/recursion/recursion.rs stdout ----
2020-02-11T14:43:37.2237514Z diff of stderr:
2020-02-11T14:43:37.2237702Z 
2020-02-11T14:43:37.2239755Z - error: overflow while checking whether `Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Nil>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>` requires drop
2020-02-11T14:43:37.2240644Z - 
2020-02-11T14:43:37.2241001Z 3 error: reached the recursion limit while instantiating `test::<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Nil>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>`
2020-02-11T14:43:37.2241629Z 5    |
2020-02-11T14:43:37.2241674Z 
2020-02-11T14:43:37.2241754Z 12 LL | | }
2020-02-11T14:43:37.2241817Z 13    | |_^
---
2020-02-11T14:43:37.2242567Z 
2020-02-11T14:43:37.2242621Z 
2020-02-11T14:43:37.2242691Z The actual stderr differed from the expected stderr.
2020-02-11T14:43:37.2243109Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/recursion/recursion/recursion.stderr
2020-02-11T14:43:37.2243417Z To update references, rerun the tests and pass the `--bless` flag
2020-02-11T14:43:37.2243751Z To only update this specific test, also pass `--test-args recursion/recursion.rs`
2020-02-11T14:43:37.2243894Z error: 1 errors occurred comparing output.
2020-02-11T14:43:37.2243974Z status: exit code: 1
2020-02-11T14:43:37.2243974Z status: exit code: 1
2020-02-11T14:43:37.2244894Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/recursion/recursion.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/recursion/recursion" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-C" "opt-level=0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/recursion/recursion/auxiliary" "-A" "unused"
2020-02-11T14:43:37.2245385Z ------------------------------------------
2020-02-11T14:43:37.2245452Z 
2020-02-11T14:43:37.2245683Z ------------------------------------------
2020-02-11T14:43:37.2245782Z stderr:
2020-02-11T14:43:37.2245782Z stderr:
2020-02-11T14:43:37.2246014Z ------------------------------------------
2020-02-11T14:43:37.2246375Z error: reached the recursion limit while instantiating `test::<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Cons<Nil>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>`
2020-02-11T14:43:37.2247396Z    |
2020-02-11T14:43:37.2247396Z    |
2020-02-11T14:43:37.2247878Z LL | / fn test<T:Dot> (n:isize, i:isize, first:T, second:T) ->isize { //~ ERROR recursion limit
2020-02-11T14:43:37.2248003Z LL | |   match n {    0 => {first.dot(second)}
2020-02-11T14:43:37.2249400Z LL | |       // FIXME(#4287) Error message should be here. It should be
2020-02-11T14:43:37.2249507Z LL | |       // a type error to instantiate `test` at a type other than T.
2020-02-11T14:43:37.2249947Z LL | |     _ => {test (n-1, i+1, Cons {head:2*i+1, tail:first}, Cons{head:i*i, tail:second})}
2020-02-11T14:43:37.2250121Z LL | | }
2020-02-11T14:43:37.2250182Z    | |_^
2020-02-11T14:43:37.2250239Z 
2020-02-11T14:43:37.2250303Z error: aborting due to previous error
---
2020-02-11T14:43:37.2277659Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-02-11T14:43:37.2277999Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-02-11T14:43:37.2285229Z 
2020-02-11T14:43:37.2285379Z 
2020-02-11T14:43:37.2287723Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-unknown/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-wasm32-unknown-unknown" "--mode" "ui" "--target" "wasm32-unknown-unknown" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/node-v9.2.0-linux-x64/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.1-rust-1.43.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-11T14:43:37.2288433Z 
2020-02-11T14:43:37.2288474Z 
2020-02-11T14:43:37.2298678Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/compile-fail src/test/mir-opt src/test/codegen-units src/libcore
2020-02-11T14:43:37.2299034Z Build completed unsuccessfully in 1:25:07
2020-02-11T14:43:37.2299034Z Build completed unsuccessfully in 1:25:07
2020-02-11T14:43:37.2369278Z == clock drift check ==
2020-02-11T14:43:37.2396504Z   local time: Tue Feb 11 14:43:37 UTC 2020
2020-02-11T14:43:37.5388549Z   network time: Tue, 11 Feb 2020 14:43:37 GMT
2020-02-11T14:43:37.5395784Z == end clock drift check ==
2020-02-11T14:43:38.3650603Z 
2020-02-11T14:43:38.3726295Z ##[error]Bash exited with code '1'.
2020-02-11T14:43:38.3764629Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-11T14:43:38.3766415Z ==============================================================================
2020-02-11T14:43:38.3766494Z Task         : Get sources
2020-02-11T14:43:38.3766583Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-11T14:44:53Z

💔 Test failed - checks-azure

matthewjasper and others added 30 commits February 2, 2020 21:46

Don't requery the param_env of a union

91cf0e7

Union fields have the ParamEnv of the union.

Remove unnecessary features in rustc_ty

570c161

Add IS_MANUALLY_DROP to AdtFlags

3973322

Improve needs_drop query

d196521

* Handle cycles in `needs_drop` correctly * Normalize types when computing `needs_drop` * Move queries from rustc to rustc_ty

Address review comments

d20646b

* Handle arrays with const-generic lengths * Use closure for repeated code.

Use correct ParamEnv in Instance::resolve

465b862

Remove the Cow from Directory.

f840a95

The previous commit wrapped `Parser` within a `Cow` for the hot macro parsing path. As a result, there's no need for the `Cow` within `Directory`, because it lies within `Parser`.

Change condition ordering in parse_tt.

2a13b24

This is a small win, because `Failure` is much more common than `Success`.

remove unnecessary local variable assignment in context manager

3998249

PEP8 format spacing

19aaf63

PEP8 format spacing

6ce8d2b

PEP8 format spacing

adde3d4

remove unnecessary semicolons

60889d4

PEP8 format spacing

e30dd86

remove unnecessary sys import

f38e270

PEP8 format spacing

d366343

PEP8 format spacing, split import statements

a53f45f

remove unnecessary import statement

8d04b95

PEP8 format spacing, remove unnecessary local variable assignment

85e3661

PEP8 format spacing

814aa06

remove unnecessary import statement, PEP8 format spacing

9b10fc4

shorten comment blocks to < 100 characters

77d158d

Apply suggestions from code review

3eb5241

Co-Authored-By: varkor <github@varkor.com>

cache adt_drop_tys

842938a

miri: simplify singed operator overflow detection

202d401

bring back extra check for int_min%-1

28f85c6

miri: equip unary_op with overflow detection

7d2f6ae

const-prop: use overflowing_unary_op for overflowing checking of unar…

ae23f70

…y ops

add test that checks overflows on arithmetic operators

b434d7e

petrochenkov and others added 18 commits February 10, 2020 20:29

parser: Remove Parser::prev_token_kind

8d79921

Remove common usage pattern from AllocRef

25de80a

Add missing _zeroed varants to AllocRef

97d1f8d

add main function to issue-69017 test

53b16fb

remove outdated comment

c561d23

Specify opt-level in test

c38b4b6

Don't rustfmt the vendor directory.

6575abc

Rollup merge of #68679 - matthewjasper:needs-type-op, r=varkor

98b3d21

Improve `ty.needs_drop` * Handle cycles in `needs_drop` correctly * Normalize types when computing `needs_drop` * Move queries from rustc to rustc_ty * Avoid query in simple cases reopens #65918

Rollup merge of #68848 - nnethercote:hasten-macro-parsing, r=petroche…

2125b06

…nkov Hasten macro parsing r? @eddyb

Rollup merge of #69031 - Centril:dyntest, r=eddyb

ff8d628

Use `dyn Trait` more in tests Here are some tests using the old trait object type syntax which are not testing the syntax itself. This has been extracted from #66364.

Rollup merge of #69034 - petrochenkov:notokind, r=Centril

8fcb1a3

parser: Remove `Parser::prev_token_kind` Follow-up to #69006. r? @Centril

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 11, 2020

jonas-schievink added the rollup A PR which is a rollup label Feb 11, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 11, 2020

jonas-schievink mentioned this pull request Feb 11, 2020

Improve ty.needs_drop #68679

Merged

jonas-schievink closed this Feb 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 11 pull requests #69056

Rollup of 11 pull requests #69056

jonas-schievink commented Feb 11, 2020

jonas-schievink commented Feb 11, 2020

bors commented Feb 11, 2020

bors commented Feb 11, 2020

rust-highfive commented Feb 11, 2020

bors commented Feb 11, 2020

Rollup of 11 pull requests #69056

Rollup of 11 pull requests #69056

Conversation

jonas-schievink commented Feb 11, 2020

jonas-schievink commented Feb 11, 2020

bors commented Feb 11, 2020

bors commented Feb 11, 2020

rust-highfive commented Feb 11, 2020

bors commented Feb 11, 2020