Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #69108 #69199

Closed
wants to merge 2 commits into from
Closed

Conversation

ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Feb 15, 2020

...to see if it caused the regression in #69197.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2020
@ecstatic-morse
Copy link
Contributor Author

@bors try
@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Feb 15, 2020

⌛ Trying commit bcebc99 with merge 82f73f2...

bors added a commit that referenced this pull request Feb 15, 2020
Revert #69108

... to see if it caused the regression in #69197.

@bors try
@rust-timer queue
@bors
Copy link
Contributor

bors commented Feb 16, 2020

☀️ Try build successful - checks-azure
Build commit: 82f73f2 (82f73f2cdddfe955259459e7c7241fed5638e644)

@rust-timer
Copy link
Collaborator

Queued 82f73f2 with parent 61d9231, future comparison URL.

@ecstatic-morse
Copy link
Contributor Author

ecstatic-morse commented Feb 16, 2020

Perf results indicate that #69197 did not cause the regression.

@ecstatic-morse ecstatic-morse deleted the revert-69108 branch February 16, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants