-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition when allocating source files in SourceMap #69266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. If you don't think it's worthwhile, feel free to r=me this.
cc @matklad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a minor typo and am interested in trying to learn a little more about rust if you have the time to answer some questions :-) Also, I don't see any notes in CONTRIBUTING.md
about reviewing PRs so I hope I'm not out of line in reviewing this. If there are some docs regarding when/how to review PRs - please link me to them so I don't make the mistake again.
@mlodato517 If you have additional questions feel free to ask! Otherwise I'm going to mark those parts of your review resolved to keep this PR clean. |
cc4375b
to
437f56e
Compare
@bors r=wesleywiser |
📌 Commit 437f56e has been approved by |
…iser Fix race condition when allocating source files in SourceMap This makes allocating address space in the source map an atomic operation. `rustc` does not currently do this in parallel, so this bug can't trigger, but parsing files in parallel could trigger it, and that is something we want to do. Fixes rust-lang#69261. r? @wesleywiser
Rollup of 5 pull requests Successful merges: - #68705 (Add LinkedList::remove()) - #68945 (Stabilize Once::is_completed) - #68978 (Make integer exponentiation methods unstably const) - #69266 (Fix race condition when allocating source files in SourceMap) - #69287 (Clean up E0317 explanation) Failed merges: r? @ghost
This makes allocating address space in the source map an atomic operation.
rustc
does not currently do this in parallel, so this bug can't trigger, but parsing files in parallel could trigger it, and that is something we want to do.Fixes #69261.
r? @wesleywiser